From: "Wei, David" <david.wei@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Andrew Fish <afish@apple.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>,
"Wei, David" <david.wei@intel.com>
Subject: Re: [PATCH] CorebootModulePkg, EmulatorPkg, Vlv2TbltDevicePkg: .inf whitespace fixes
Date: Tue, 2 May 2017 09:37:25 +0000 [thread overview]
Message-ID: <89954A0B46707A448411A627AD4EEE3468F2C0FC@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20170428163858.GO1657@bivouac.eciton.net>
Only one comment: Please also update the year of copyright to 2017, such as changing "Copyright (c) 2006 - 2014" to "Copyright (c) 2006 - 2017".
Reviewed-by: zwei4 <david.wei@intel.com>
Thanks,
David Wei
-----Original Message-----
From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
Sent: Saturday, April 29, 2017 12:39 AM
To: edk2-devel@lists.01.org
Cc: Andrew Fish <afish@apple.com>; Agyeman, Prince <prince.agyeman@intel.com>; Wei, David <david.wei@intel.com>
Subject: Re: [edk2] [PATCH] CorebootModulePkg, EmulatorPkg, Vlv2TbltDevicePkg: .inf whitespace fixes
Andrew, Prince/David - any comments?
On Mon, Apr 24, 2017 at 10:49:48AM -0700, Jordan Justen wrote:
> On 2017-04-24 02:43:08, Leif Lindholm wrote:
> > Incorrect line endings, trailing spaces and missing line break at end
> > of file.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> >
> > This addresses only issues found when hacking on some scripts for
> > sanity checking .inf files.
> >
> > Since trivial[1], would prefer not to split into one patch per
> > package.
> >
> > [1] git diff -w --word-diff-regex=[^[:space:]] HEAD~1
> > does not generate any output.
>
> Also: git diff --ignore-space-at-eol HEAD~
>
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
>
> >
> > CorebootModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf | 96 ++++++++++++------------
> > CorebootModulePkg/Library/CbPlatformSupportLibNull/CbPlatformSupportLibNull.inf | 70 +++++++++---------
> > CorebootModulePkg/SataControllerDxe/SataControllerDxe.inf | 98 ++++++++++++------------
> > EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.inf | 96 ++++++++++++------------
> > EmulatorPkg/Library/PeiEmuPeCoffExtraActionLib/PeiEmuPeCoffExtraActionLib.inf | 98 ++++++++++++------------
> > EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf | 94 ++++++++++++------------
> > Vlv2TbltDevicePkg/PlatformInitPei/PlatformInitPei.inf | 18 ++---
> > Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf | 290 ++++++++++++++++++++++++++++++++++++------------------------------------
> > 8 files changed, 430 insertions(+), 430 deletions(-)
> >
> > diff --git a/CorebootModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf b/CorebootModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf
> > index cd758ae4bf..77075ccc95 100644
> > --- a/CorebootModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf
> > +++ b/CorebootModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf
> > @@ -1,48 +1,48 @@
> > -## @file
> > -# SerialPortLib instance for 16550 UART.
> > -#
> > -# Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
> > -# This program and the accompanying materials
> > -# are licensed and made available under the terms and conditions of the BSD License
> > -# which accompanies this distribution. The full text of the license may be found at
> > -# http://opensource.org/licenses/bsd-license.php
> > -#
> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > -#
> > -##
> > -
> > -[Defines]
> > - INF_VERSION = 0x00010005
> > - BASE_NAME = BaseSerialPortLib16550
> > - MODULE_UNI_FILE = BaseSerialPortLib16550.uni
> > - FILE_GUID = 9E7C00CF-355A-4d4e-BF60-0428CFF95540
> > - MODULE_TYPE = BASE
> > - VERSION_STRING = 1.1
> > - LIBRARY_CLASS = SerialPortLib
> > -
> > -[Packages]
> > - MdePkg/MdePkg.dec
> > - MdeModulePkg/MdeModulePkg.dec
> > -
> > -[LibraryClasses]
> > - PcdLib
> > - IoLib
> > - PlatformHookLib
> > - PciLib
> > -
> > -[Sources]
> > - BaseSerialPortLib16550.c
> > -
> > -[Pcd]
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio ## CONSUMES
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl ## CONSUMES
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialDetectCable ## SOMETIMES_CONSUMES
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase ## CONSUMES
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate ## CONSUMES
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialLineControl ## CONSUMES
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialFifoControl ## CONSUMES
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialClockRate ## CONSUMES
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialPciDeviceInfo ## CONSUMES
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialExtendedTxFifoSize ## CONSUMES
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride ## CONSUMES
> > +## @file
> > +# SerialPortLib instance for 16550 UART.
> > +#
> > +# Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
> > +# This program and the accompanying materials
> > +# are licensed and made available under the terms and conditions of the BSD License
> > +# which accompanies this distribution. The full text of the license may be found at
> > +# http://opensource.org/licenses/bsd-license.php
> > +#
> > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > +#
> > +##
> > +
> > +[Defines]
> > + INF_VERSION = 0x00010005
> > + BASE_NAME = BaseSerialPortLib16550
> > + MODULE_UNI_FILE = BaseSerialPortLib16550.uni
> > + FILE_GUID = 9E7C00CF-355A-4d4e-BF60-0428CFF95540
> > + MODULE_TYPE = BASE
> > + VERSION_STRING = 1.1
> > + LIBRARY_CLASS = SerialPortLib
> > +
> > +[Packages]
> > + MdePkg/MdePkg.dec
> > + MdeModulePkg/MdeModulePkg.dec
> > +
> > +[LibraryClasses]
> > + PcdLib
> > + IoLib
> > + PlatformHookLib
> > + PciLib
> > +
> > +[Sources]
> > + BaseSerialPortLib16550.c
> > +
> > +[Pcd]
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio ## CONSUMES
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl ## CONSUMES
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialDetectCable ## SOMETIMES_CONSUMES
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase ## CONSUMES
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate ## CONSUMES
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialLineControl ## CONSUMES
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialFifoControl ## CONSUMES
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialClockRate ## CONSUMES
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialPciDeviceInfo ## CONSUMES
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialExtendedTxFifoSize ## CONSUMES
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride ## CONSUMES
> > diff --git a/CorebootModulePkg/Library/CbPlatformSupportLibNull/CbPlatformSupportLibNull.inf b/CorebootModulePkg/Library/CbPlatformSupportLibNull/CbPlatformSupportLibNull.inf
> > index 7e25df3345..bbf088f3f3 100644
> > --- a/CorebootModulePkg/Library/CbPlatformSupportLibNull/CbPlatformSupportLibNull.inf
> > +++ b/CorebootModulePkg/Library/CbPlatformSupportLibNull/CbPlatformSupportLibNull.inf
> > @@ -1,35 +1,35 @@
> > -## @file
> > -# Include all platform specific features which can be customized by IBV/OEM.
> > -#
> > -# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> > -# This program and the accompanying materials
> > -# are licensed and made available under the terms and conditions of the BSD License
> > -# which accompanies this distribution. The full text of the license may be found at
> > -# http://opensource.org/licenses/bsd-license.php
> > -#
> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > -#
> > -##
> > -
> > -[Defines]
> > - INF_VERSION = 0x00010005
> > - BASE_NAME = CbPlatformSupportLib
> > - MODULE_UNI_FILE = CbPlatformSupportLibNull.uni
> > - FILE_GUID = B42AA265-00CA-4d4b-AC14-DBD5268E1BC7
> > - MODULE_TYPE = BASE
> > - VERSION_STRING = 1.0
> > - LIBRARY_CLASS = CbPlatformSupportLib
> > -
> > -#
> > -# The following information is for reference only and not required by the build tools.
> > -#
> > -# VALID_ARCHITECTURES = IA32 X64 EBC
> > -#
> > -
> > -[Sources]
> > - CbPlatformSupportLibNull.c
> > -
> > -[Packages]
> > - MdePkg/MdePkg.dec
> > - CorebootModulePkg/CorebootModulePkg.dec
> > +## @file
> > +# Include all platform specific features which can be customized by IBV/OEM.
> > +#
> > +# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> > +# This program and the accompanying materials
> > +# are licensed and made available under the terms and conditions of the BSD License
> > +# which accompanies this distribution. The full text of the license may be found at
> > +# http://opensource.org/licenses/bsd-license.php
> > +#
> > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > +#
> > +##
> > +
> > +[Defines]
> > + INF_VERSION = 0x00010005
> > + BASE_NAME = CbPlatformSupportLib
> > + MODULE_UNI_FILE = CbPlatformSupportLibNull.uni
> > + FILE_GUID = B42AA265-00CA-4d4b-AC14-DBD5268E1BC7
> > + MODULE_TYPE = BASE
> > + VERSION_STRING = 1.0
> > + LIBRARY_CLASS = CbPlatformSupportLib
> > +
> > +#
> > +# The following information is for reference only and not required by the build tools.
> > +#
> > +# VALID_ARCHITECTURES = IA32 X64 EBC
> > +#
> > +
> > +[Sources]
> > + CbPlatformSupportLibNull.c
> > +
> > +[Packages]
> > + MdePkg/MdePkg.dec
> > + CorebootModulePkg/CorebootModulePkg.dec
> > diff --git a/CorebootModulePkg/SataControllerDxe/SataControllerDxe.inf b/CorebootModulePkg/SataControllerDxe/SataControllerDxe.inf
> > index b0ed2f4db5..5db89dcd28 100644
> > --- a/CorebootModulePkg/SataControllerDxe/SataControllerDxe.inf
> > +++ b/CorebootModulePkg/SataControllerDxe/SataControllerDxe.inf
> > @@ -1,49 +1,49 @@
> > -## @file
> > -#
> > -# Component description file for the Sata Controller driver.
> > -#
> > -# Copyright (c) 2011, Intel Corporation. All rights reserved.<BR>
> > -# This program and the accompanying materials
> > -# are licensed and made available under the terms and conditions of the BSD License
> > -# which accompanies this distribution. The full text of the license may be found at
> > -# http://opensource.org/licenses/bsd-license.php
> > -#
> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > -#
> > -##
> > -
> > -[Defines]
> > - INF_VERSION = 0x00010005
> > - BASE_NAME = SataController
> > - FILE_GUID = 8F4CD826-A5A0-4e93-9522-CFB0AB72926C
> > - MODULE_TYPE = UEFI_DRIVER
> > - VERSION_STRING = 1.0
> > - ENTRY_POINT = InitializeSataControllerDriver
> > -
> > -#
> > -# The following information is for reference only and not required by the build tools.
> > -#
> > -# VALID_ARCHITECTURES = IA32 X64 IPF EBC
> > -#
> > -
> > -[Sources]
> > - ComponentName.c
> > - SataController.c
> > - SataController.h
> > -
> > -[Packages]
> > - MdePkg/MdePkg.dec
> > -
> > -[LibraryClasses]
> > - UefiDriverEntryPoint
> > - DebugLib
> > - UefiLib
> > - BaseLib
> > - BaseMemoryLib
> > - MemoryAllocationLib
> > - UefiBootServicesTableLib
> > -
> > -[Protocols]
> > - gEfiPciIoProtocolGuid
> > - gEfiIdeControllerInitProtocolGuid
> > +## @file
> > +#
> > +# Component description file for the Sata Controller driver.
> > +#
> > +# Copyright (c) 2011, Intel Corporation. All rights reserved.<BR>
> > +# This program and the accompanying materials
> > +# are licensed and made available under the terms and conditions of the BSD License
> > +# which accompanies this distribution. The full text of the license may be found at
> > +# http://opensource.org/licenses/bsd-license.php
> > +#
> > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > +#
> > +##
> > +
> > +[Defines]
> > + INF_VERSION = 0x00010005
> > + BASE_NAME = SataController
> > + FILE_GUID = 8F4CD826-A5A0-4e93-9522-CFB0AB72926C
> > + MODULE_TYPE = UEFI_DRIVER
> > + VERSION_STRING = 1.0
> > + ENTRY_POINT = InitializeSataControllerDriver
> > +
> > +#
> > +# The following information is for reference only and not required by the build tools.
> > +#
> > +# VALID_ARCHITECTURES = IA32 X64 IPF EBC
> > +#
> > +
> > +[Sources]
> > + ComponentName.c
> > + SataController.c
> > + SataController.h
> > +
> > +[Packages]
> > + MdePkg/MdePkg.dec
> > +
> > +[LibraryClasses]
> > + UefiDriverEntryPoint
> > + DebugLib
> > + UefiLib
> > + BaseLib
> > + BaseMemoryLib
> > + MemoryAllocationLib
> > + UefiBootServicesTableLib
> > +
> > +[Protocols]
> > + gEfiPciIoProtocolGuid
> > + gEfiIdeControllerInitProtocolGuid
> > diff --git a/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.inf b/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.inf
> > index f79ebc78e2..682231b83e 100644
> > --- a/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.inf
> > +++ b/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.inf
> > @@ -1,48 +1,48 @@
> > -## @file
> > -# PeCoff extra action libary for DXE phase that run Emu emulator.
> > -#
> > -# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
> > -# Portions copyright (c) 2011, Apple Inc. All rights reserved.
> > -# This program and the accompanying materials
> > -# are licensed and made available under the terms and conditions of the BSD License
> > -# which accompanies this distribution. The full text of the license may be found at
> > -# http://opensource.org/licenses/bsd-license.php
> > -#
> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > -
> > -#
> > -#
> > -##
> > -
> > -[Defines]
> > - INF_VERSION = 0x00010005
> > - BASE_NAME = DxeEmuPeCoffExtraActionLib
> > - FILE_GUID = 68FCD487-D230-6846-95B1-5E1F2EF942C4
> > - MODULE_TYPE = DXE_DRIVER
> > - VERSION_STRING = 1.0
> > - LIBRARY_CLASS = PeCoffExtraActionLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_DRIVER
> > -
> > - CONSTRUCTOR = DxeEmuPeCoffLibExtraActionConstructor
> > -
> > -#
> > -# The following information is for reference only and not required by the build tools.
> > -#
> > -# VALID_ARCHITECTURES = IA32
> > -#
> > -
> > -[Sources]
> > - DxeEmuPeCoffExtraActionLib.c
> > -
> > -[Packages]
> > - MdePkg/MdePkg.dec
> > - EmulatorPkg/EmulatorPkg.dec
> > -
> > -[LibraryClasses]
> > - DebugLib
> > - HobLib
> > - BaseMemoryLib
> > -
> > -[Protocols]
> > - gEmuThunkProtocolGuid # PROTOCOL ALWAYS_CONSUMED
> > -
> > +## @file
> > +# PeCoff extra action libary for DXE phase that run Emu emulator.
> > +#
> > +# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
> > +# Portions copyright (c) 2011, Apple Inc. All rights reserved.
> > +# This program and the accompanying materials
> > +# are licensed and made available under the terms and conditions of the BSD License
> > +# which accompanies this distribution. The full text of the license may be found at
> > +# http://opensource.org/licenses/bsd-license.php
> > +#
> > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > +
> > +#
> > +#
> > +##
> > +
> > +[Defines]
> > + INF_VERSION = 0x00010005
> > + BASE_NAME = DxeEmuPeCoffExtraActionLib
> > + FILE_GUID = 68FCD487-D230-6846-95B1-5E1F2EF942C4
> > + MODULE_TYPE = DXE_DRIVER
> > + VERSION_STRING = 1.0
> > + LIBRARY_CLASS = PeCoffExtraActionLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_DRIVER
> > +
> > + CONSTRUCTOR = DxeEmuPeCoffLibExtraActionConstructor
> > +
> > +#
> > +# The following information is for reference only and not required by the build tools.
> > +#
> > +# VALID_ARCHITECTURES = IA32
> > +#
> > +
> > +[Sources]
> > + DxeEmuPeCoffExtraActionLib.c
> > +
> > +[Packages]
> > + MdePkg/MdePkg.dec
> > + EmulatorPkg/EmulatorPkg.dec
> > +
> > +[LibraryClasses]
> > + DebugLib
> > + HobLib
> > + BaseMemoryLib
> > +
> > +[Protocols]
> > + gEmuThunkProtocolGuid # PROTOCOL ALWAYS_CONSUMED
> > +
> > diff --git a/EmulatorPkg/Library/PeiEmuPeCoffExtraActionLib/PeiEmuPeCoffExtraActionLib.inf b/EmulatorPkg/Library/PeiEmuPeCoffExtraActionLib/PeiEmuPeCoffExtraActionLib.inf
> > index 9a757f7294..fdaf19ab6c 100644
> > --- a/EmulatorPkg/Library/PeiEmuPeCoffExtraActionLib/PeiEmuPeCoffExtraActionLib.inf
> > +++ b/EmulatorPkg/Library/PeiEmuPeCoffExtraActionLib/PeiEmuPeCoffExtraActionLib.inf
> > @@ -1,49 +1,49 @@
> > -## @file
> > -# PeCoff extra action libary for Pei phase that run Emu emulator.
> > -#
> > -# Lib to provide memory journal status code reporting Routines
> > -# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
> > -# Portions copyright (c) 2011, Apple Inc. All rights reserved.
> > -# This program and the accompanying materials
> > -# are licensed and made available under the terms and conditions of the BSD License
> > -# which accompanies this distribution. The full text of the license may be found at
> > -# http://opensource.org/licenses/bsd-license.php
> > -#
> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > -
> > -#
> > -#
> > -##
> > -
> > -[Defines]
> > - INF_VERSION = 0x00010005
> > - BASE_NAME = PeiEmuPeCoffExtraActionLib
> > - FILE_GUID = 79C4E72A-730B-F040-8129-95877B3A97A8
> > - MODULE_TYPE = PEIM
> > - VERSION_STRING = 1.0
> > - LIBRARY_CLASS = PeCoffExtraActionLib|PEI_CORE PEIM
> > -
> > -#
> > -# The following information is for reference only and not required by the build tools.
> > -#
> > -# VALID_ARCHITECTURES = IA32
> > -#
> > -
> > -[Sources]
> > - PeiEmuPeCoffExtraActionLib.c
> > -
> > -[Packages]
> > - MdePkg/MdePkg.dec
> > - EmulatorPkg/EmulatorPkg.dec
> > -
> > -[LibraryClasses]
> > - BaseLib
> > - PeiServicesLib
> > - DebugLib
> > -
> > -[Ppis]
> > - gEmuThunkPpiGuid # PPI ALWAYS_CONSUMED
> > -
> > -[Pcd]
> > - gEmulatorPkgTokenSpaceGuid.PcdPeiServicesTablePage
> > +## @file
> > +# PeCoff extra action libary for Pei phase that run Emu emulator.
> > +#
> > +# Lib to provide memory journal status code reporting Routines
> > +# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
> > +# Portions copyright (c) 2011, Apple Inc. All rights reserved.
> > +# This program and the accompanying materials
> > +# are licensed and made available under the terms and conditions of the BSD License
> > +# which accompanies this distribution. The full text of the license may be found at
> > +# http://opensource.org/licenses/bsd-license.php
> > +#
> > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > +
> > +#
> > +#
> > +##
> > +
> > +[Defines]
> > + INF_VERSION = 0x00010005
> > + BASE_NAME = PeiEmuPeCoffExtraActionLib
> > + FILE_GUID = 79C4E72A-730B-F040-8129-95877B3A97A8
> > + MODULE_TYPE = PEIM
> > + VERSION_STRING = 1.0
> > + LIBRARY_CLASS = PeCoffExtraActionLib|PEI_CORE PEIM
> > +
> > +#
> > +# The following information is for reference only and not required by the build tools.
> > +#
> > +# VALID_ARCHITECTURES = IA32
> > +#
> > +
> > +[Sources]
> > + PeiEmuPeCoffExtraActionLib.c
> > +
> > +[Packages]
> > + MdePkg/MdePkg.dec
> > + EmulatorPkg/EmulatorPkg.dec
> > +
> > +[LibraryClasses]
> > + BaseLib
> > + PeiServicesLib
> > + DebugLib
> > +
> > +[Ppis]
> > + gEmuThunkPpiGuid # PPI ALWAYS_CONSUMED
> > +
> > +[Pcd]
> > + gEmulatorPkgTokenSpaceGuid.PcdPeiServicesTablePage
> > diff --git a/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf b/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf
> > index adcd7ef08e..9442ff8581 100644
> > --- a/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf
> > +++ b/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf
> > @@ -1,47 +1,47 @@
> > -## @file
> > -# SMBIOS Library
> > -#
> > -# Copyright (c) 2012, Apple Inc. All rights reserved.
> > -# Portions copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
> > -#
> > -# This program and the accompanying materials
> > -# are licensed and made available under the terms and conditions of the BSD License
> > -# which accompanies this distribution. The full text of the license may be found at
> > -# http://opensource.org/licenses/bsd-license.php
> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > -#
> > -#
> > -##
> > -
> > -[Defines]
> > - INF_VERSION = 0x00010005
> > - BASE_NAME = SmbiosLib
> > - FILE_GUID = 881863A2-09FD-3E44-8D62-7AE038D03747
> > - MODULE_TYPE = DXE_DRIVER
> > - VERSION_STRING = 1.0
> > - LIBRARY_CLASS = PcdLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_APPLICATION UEFI_DRIVER
> > -
> > - CONSTRUCTOR = SmbiosLibConstructor
> > -
> > -
> > -[Sources]
> > - SmbiosLib.c
> > -
> > -[Packages]
> > - MdePkg/MdePkg.dec
> > - EmulatorPkg/EmulatorPkg.dec
> > -
> > -[LibraryClasses]
> > - BaseLib
> > - BaseMemoryLib
> > - DebugLib
> > - MemoryAllocationLib
> > - UefiBootServicesTableLib
> > - UefiLib
> > -
> > -[Protocols]
> > - gEfiSmbiosProtocolGuid
> > -
> > -[Depex]
> > - gEfiSmbiosProtocolGuid
> > \ No newline at end of file
> > +## @file
> > +# SMBIOS Library
> > +#
> > +# Copyright (c) 2012, Apple Inc. All rights reserved.
> > +# Portions copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
> > +#
> > +# This program and the accompanying materials
> > +# are licensed and made available under the terms and conditions of the BSD License
> > +# which accompanies this distribution. The full text of the license may be found at
> > +# http://opensource.org/licenses/bsd-license.php
> > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > +#
> > +#
> > +##
> > +
> > +[Defines]
> > + INF_VERSION = 0x00010005
> > + BASE_NAME = SmbiosLib
> > + FILE_GUID = 881863A2-09FD-3E44-8D62-7AE038D03747
> > + MODULE_TYPE = DXE_DRIVER
> > + VERSION_STRING = 1.0
> > + LIBRARY_CLASS = PcdLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_APPLICATION UEFI_DRIVER
> > +
> > + CONSTRUCTOR = SmbiosLibConstructor
> > +
> > +
> > +[Sources]
> > + SmbiosLib.c
> > +
> > +[Packages]
> > + MdePkg/MdePkg.dec
> > + EmulatorPkg/EmulatorPkg.dec
> > +
> > +[LibraryClasses]
> > + BaseLib
> > + BaseMemoryLib
> > + DebugLib
> > + MemoryAllocationLib
> > + UefiBootServicesTableLib
> > + UefiLib
> > +
> > +[Protocols]
> > + gEfiSmbiosProtocolGuid
> > +
> > +[Depex]
> > + gEfiSmbiosProtocolGuid
> > diff --git a/Vlv2TbltDevicePkg/PlatformInitPei/PlatformInitPei.inf b/Vlv2TbltDevicePkg/PlatformInitPei/PlatformInitPei.inf
> > index 309487d854..04a2b54665 100644
> > --- a/Vlv2TbltDevicePkg/PlatformInitPei/PlatformInitPei.inf
> > +++ b/Vlv2TbltDevicePkg/PlatformInitPei/PlatformInitPei.inf
> > @@ -1,15 +1,15 @@
> > #
> > #
> > # Copyright (c) 1999 - 2016, Intel Corporation. All rights reserved
> > -#
> > -# This program and the accompanying materials are licensed and made available under
> > -# the terms and conditions of the BSD License that accompanies this distribution.
> > -# The full text of the license may be found at
> > -# http://opensource.org/licenses/bsd-license.php.
> > -#
> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > -#
> > +#
> > +# This program and the accompanying materials are licensed and made available under
> > +# the terms and conditions of the BSD License that accompanies this distribution.
> > +# The full text of the license may be found at
> > +# http://opensource.org/licenses/bsd-license.php.
> > +#
> > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > +#
> > #
> > #
> > # Module Name:
> > diff --git a/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf b/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> > index 332d2376d8..d539deebdf 100644
> > --- a/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> > +++ b/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> > @@ -1,145 +1,145 @@
> > -## @file
> > -# Component name for module MiscSubclass
> > -#
> > -# FIX ME!
> > -# Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
> > -#
> > -# This program and the accompanying materials are licensed and made available under
> > -# the terms and conditions of the BSD License that accompanies this distribution.
> > -# The full text of the license may be found at
> > -# http://opensource.org/licenses/bsd-license.php.
> > -#
> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > -#
> > -#
> > -#
> > -#
> > -##
> > -
> > -[Defines]
> > - INF_VERSION = 0x00010005
> > - BASE_NAME = MiscSubclass
> > - FILE_GUID = 4EFFB560-B28B-4e57-9DAD-4344E32EA3BA
> > - MODULE_TYPE = DXE_DRIVER
> > - VERSION_STRING = 1.0
> > - ENTRY_POINT = MiscSubclassDriverEntryPoint
> > -
> > -#
> > -# The following information is for reference only and not required by the build tools.
> > -#
> > -# VALID_ARCHITECTURES = IA32 X64 IPF EBC
> > -#
> > -
> > -[Sources]
> > - MiscBaseBoardManufacturer.uni
> > - MiscBaseBoardManufacturerData.c
> > - MiscBaseBoardManufacturerFunction.c
> > - MiscBiosVendor.uni
> > - MiscBiosVendorData.c
> > - MiscBiosVendorFunction.c
> > - MiscBootInformationData.c
> > - MiscBootInformationFunction.c
> > - MiscChassisManufacturer.uni
> > - MiscChassisManufacturerData.c
> > - MiscChassisManufacturerFunction.c
> > - MiscNumberOfInstallableLanguagesData.c
> > - MiscNumberOfInstallableLanguagesFunction.c
> > - MiscOemString.uni
> > - MiscOemStringData.c
> > - MiscOemStringFunction.c
> > - MiscOnboardDevice.uni
> > - MiscOnboardDeviceData.c
> > - MiscOnboardDeviceFunction.c
> > - MiscPortInternalConnectorDesignator.uni
> > - MiscPortInternalConnectorDesignatorData.c
> > - MiscPortInternalConnectorDesignatorFunction.c
> > - MiscResetCapabilitiesData.c
> > - MiscResetCapabilitiesFunction.c
> > - MiscSystemLanguageString.uni
> > - MiscSystemLanguageStringData.c
> > - MiscSystemLanguageStringFunction.c
> > - MiscSystemManufacturer.uni
> > - MiscSystemManufacturerData.c
> > - MiscSystemManufacturerFunction.c
> > - MiscSystemOptionString.uni
> > - MiscSystemOptionStringData.c
> > - MiscSystemOptionStringFunction.c
> > - MiscSystemSlotDesignation.uni
> > - MiscSystemSlotDesignationData.c
> > - MiscSystemSlotDesignationFunction.c
> > - MiscSubclassDriver.h
> > - MiscSubclassDriver.uni
> > - MiscSubclassDriverDataTable.c
> > - MiscSubclassDriverEntryPoint.c
> > - CommonHeader.h
> > - MiscOemType0x90Function.c
> > - MiscOemType0x90Data.c
> > - MiscOemType0x90.uni
> > - MiscProcessorInformation.uni
> > - MiscProcessorInformationData.c
> > - MiscProcessorInformationFunction.c
> > - MiscProcessorCache.uni
> > - MiscProcessorCacheData.c
> > - MiscProcessorCacheFunction.c
> > - MiscPhysicalArray.uni
> > - MiscPhysicalArrayData.c
> > - MiscPhysicalArrayFunction.c
> > - MiscMemoryDevice.uni
> > - MiscMemoryDeviceData.c
> > - MiscMemoryDeviceFunction.c
> > -
> > -[Packages]
> > - MdeModulePkg/MdeModulePkg.dec
> > - Vlv2TbltDevicePkg/PlatformPkg.dec
> > - MdePkg/MdePkg.dec
> > - IntelFrameworkPkg/IntelFrameworkPkg.dec
> > - Vlv2DeviceRefCodePkg/Vlv2DeviceRefCodePkg.dec
> > -
> > -[LibraryClasses]
> > - HiiLib
> > - DevicePathLib
> > - UefiBootServicesTableLib
> > - UefiRuntimeServicesTableLib
> > - UefiDriverEntryPoint
> > - BaseMemoryLib
> > - DebugLib
> > - BaseLib
> > - MemoryAllocationLib
> > - PcdLib
> > - UefiLib
> > - BiosIdLib
> > - PrintLib
> > - CpuIA32Lib
> > - PchPlatformLib
> > - I2cLib
> > - NetLib
> > - HobLib
> > -
> > -[Guids]
> > - gEfiProcessorSubClassGuid
> > - gEfiCacheSubClassGuid
> > - gEfiNormalSetupGuid
> > - gEfiPlatformInfoGuid
> > - gEfiVlv2VariableGuid
> > -
> > -[Protocols]
> > - gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED
> > - gEfiDxeSmmReadyToLockProtocolGuid # PROTOCOL ALWAYS_CONSUMED
> > - gEfiDataHubProtocolGuid
> > - gEfiMpServiceProtocolGuid
> > - gMemInfoProtocolGuid
> > - gEfiTdtOperationProtocolGuid
> > - gDxePchPlatformPolicyProtocolGuid
> > - gEfiSpiProtocolGuid
> > - gEfiSimpleNetworkProtocolGuid
> > -
> > -[Pcd]
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareReleaseDateString
> > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
> > - gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLang
> > - gEfiVLVTokenSpaceGuid.PcdEmmcManufacturerId
> > - gEfiVLVTokenSpaceGuid.PcdProductSerialNumber
> > -
> > -[Depex]
> > - gEfiSmbiosProtocolGuid AND gMemInfoProtocolGuid AND gEfiMpServiceProtocolGuid AND gEfiSimpleNetworkProtocolGuid
> > +## @file
> > +# Component name for module MiscSubclass
> > +#
> > +# FIX ME!
> > +# Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
> > +#
> > +# This program and the accompanying materials are licensed and made available under
> > +# the terms and conditions of the BSD License that accompanies this distribution.
> > +# The full text of the license may be found at
> > +# http://opensource.org/licenses/bsd-license.php.
> > +#
> > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > +#
> > +#
> > +#
> > +#
> > +##
> > +
> > +[Defines]
> > + INF_VERSION = 0x00010005
> > + BASE_NAME = MiscSubclass
> > + FILE_GUID = 4EFFB560-B28B-4e57-9DAD-4344E32EA3BA
> > + MODULE_TYPE = DXE_DRIVER
> > + VERSION_STRING = 1.0
> > + ENTRY_POINT = MiscSubclassDriverEntryPoint
> > +
> > +#
> > +# The following information is for reference only and not required by the build tools.
> > +#
> > +# VALID_ARCHITECTURES = IA32 X64 IPF EBC
> > +#
> > +
> > +[Sources]
> > + MiscBaseBoardManufacturer.uni
> > + MiscBaseBoardManufacturerData.c
> > + MiscBaseBoardManufacturerFunction.c
> > + MiscBiosVendor.uni
> > + MiscBiosVendorData.c
> > + MiscBiosVendorFunction.c
> > + MiscBootInformationData.c
> > + MiscBootInformationFunction.c
> > + MiscChassisManufacturer.uni
> > + MiscChassisManufacturerData.c
> > + MiscChassisManufacturerFunction.c
> > + MiscNumberOfInstallableLanguagesData.c
> > + MiscNumberOfInstallableLanguagesFunction.c
> > + MiscOemString.uni
> > + MiscOemStringData.c
> > + MiscOemStringFunction.c
> > + MiscOnboardDevice.uni
> > + MiscOnboardDeviceData.c
> > + MiscOnboardDeviceFunction.c
> > + MiscPortInternalConnectorDesignator.uni
> > + MiscPortInternalConnectorDesignatorData.c
> > + MiscPortInternalConnectorDesignatorFunction.c
> > + MiscResetCapabilitiesData.c
> > + MiscResetCapabilitiesFunction.c
> > + MiscSystemLanguageString.uni
> > + MiscSystemLanguageStringData.c
> > + MiscSystemLanguageStringFunction.c
> > + MiscSystemManufacturer.uni
> > + MiscSystemManufacturerData.c
> > + MiscSystemManufacturerFunction.c
> > + MiscSystemOptionString.uni
> > + MiscSystemOptionStringData.c
> > + MiscSystemOptionStringFunction.c
> > + MiscSystemSlotDesignation.uni
> > + MiscSystemSlotDesignationData.c
> > + MiscSystemSlotDesignationFunction.c
> > + MiscSubclassDriver.h
> > + MiscSubclassDriver.uni
> > + MiscSubclassDriverDataTable.c
> > + MiscSubclassDriverEntryPoint.c
> > + CommonHeader.h
> > + MiscOemType0x90Function.c
> > + MiscOemType0x90Data.c
> > + MiscOemType0x90.uni
> > + MiscProcessorInformation.uni
> > + MiscProcessorInformationData.c
> > + MiscProcessorInformationFunction.c
> > + MiscProcessorCache.uni
> > + MiscProcessorCacheData.c
> > + MiscProcessorCacheFunction.c
> > + MiscPhysicalArray.uni
> > + MiscPhysicalArrayData.c
> > + MiscPhysicalArrayFunction.c
> > + MiscMemoryDevice.uni
> > + MiscMemoryDeviceData.c
> > + MiscMemoryDeviceFunction.c
> > +
> > +[Packages]
> > + MdeModulePkg/MdeModulePkg.dec
> > + Vlv2TbltDevicePkg/PlatformPkg.dec
> > + MdePkg/MdePkg.dec
> > + IntelFrameworkPkg/IntelFrameworkPkg.dec
> > + Vlv2DeviceRefCodePkg/Vlv2DeviceRefCodePkg.dec
> > +
> > +[LibraryClasses]
> > + HiiLib
> > + DevicePathLib
> > + UefiBootServicesTableLib
> > + UefiRuntimeServicesTableLib
> > + UefiDriverEntryPoint
> > + BaseMemoryLib
> > + DebugLib
> > + BaseLib
> > + MemoryAllocationLib
> > + PcdLib
> > + UefiLib
> > + BiosIdLib
> > + PrintLib
> > + CpuIA32Lib
> > + PchPlatformLib
> > + I2cLib
> > + NetLib
> > + HobLib
> > +
> > +[Guids]
> > + gEfiProcessorSubClassGuid
> > + gEfiCacheSubClassGuid
> > + gEfiNormalSetupGuid
> > + gEfiPlatformInfoGuid
> > + gEfiVlv2VariableGuid
> > +
> > +[Protocols]
> > + gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED
> > + gEfiDxeSmmReadyToLockProtocolGuid # PROTOCOL ALWAYS_CONSUMED
> > + gEfiDataHubProtocolGuid
> > + gEfiMpServiceProtocolGuid
> > + gMemInfoProtocolGuid
> > + gEfiTdtOperationProtocolGuid
> > + gDxePchPlatformPolicyProtocolGuid
> > + gEfiSpiProtocolGuid
> > + gEfiSimpleNetworkProtocolGuid
> > +
> > +[Pcd]
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareReleaseDateString
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
> > + gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLang
> > + gEfiVLVTokenSpaceGuid.PcdEmmcManufacturerId
> > + gEfiVLVTokenSpaceGuid.PcdProductSerialNumber
> > +
> > +[Depex]
> > + gEfiSmbiosProtocolGuid AND gMemInfoProtocolGuid AND gEfiMpServiceProtocolGuid AND gEfiSimpleNetworkProtocolGuid
> > --
> > 2.11.0
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-05-02 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 9:43 [PATCH] CorebootModulePkg, EmulatorPkg, Vlv2TbltDevicePkg: .inf whitespace fixes Leif Lindholm
2017-04-24 17:49 ` Jordan Justen
2017-04-28 16:38 ` Leif Lindholm
2017-05-02 9:37 ` Wei, David [this message]
2017-05-04 9:32 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89954A0B46707A448411A627AD4EEE3468F2C0FC@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox