From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 774BC21EA35AE for ; Wed, 6 Sep 2017 22:51:59 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2017 22:54:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,356,1500966000"; d="scan'208";a="148492148" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 06 Sep 2017 22:54:49 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Sep 2017 22:54:49 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Sep 2017 22:54:48 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.168]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Thu, 7 Sep 2017 13:54:47 +0800 From: "Wei, David" To: Gary Lin CC: "edk2-devel@lists.01.org" , "Liu, XianhuiX" Thread-Topic: [edk2] [PATCH] Add UBUNTU boot loader Thread-Index: AQHTJ52CVYry37ZTrk+Q0VHdONpR6qKo7C5w Date: Thu, 7 Sep 2017 05:54:47 +0000 Message-ID: <89954A0B46707A448411A627AD4EEE3468F7BB17@SHSMSX101.ccr.corp.intel.com> References: <20170907025430.4836-1-david.wei@intel.com> <20170907055149.kcff352cavtpatmd@localhost> In-Reply-To: <20170907055149.kcff352cavtpatmd@localhost> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] Add UBUNTU boot loader X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2017 05:51:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please ignore this patch. I sent another one with title [edk2] [PATCH][edk2= -platforms] Ubuntu boot Thanks, David Wei =20 > -----Original Message----- > From: Gary Lin [mailto:glin@suse.com] > Sent: Thursday, September 7, 2017 1:52 PM > To: Wei, David > Cc: edk2-devel@lists.01.org; Liu, XianhuiX > Subject: Re: [edk2] [PATCH] Add UBUNTU boot loader >=20 > On Thu, Sep 07, 2017 at 10:54:30AM +0800, zwei4 wrote: > > From: xianhu2x > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Is there any reason to add an ubuntu specific boot path? It's not > defined in UEFI spec and the default path to \EFI\BOOT\BOOT.efi > should be sufficient for a removable device. >=20 > Gary Lin >=20 > > Signed-off-by: xianhu2x > > --- > > .../Library/GenericBdsLib/BdsBoot.c | 26 > ++++++++++++++++++++++ > > Core/MdePkg/Include/Uefi/UefiSpec.h | 11 ++++----- > > 2 files changed, 32 insertions(+), 5 deletions(-) > > > > diff --git > a/Core/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c > b/Core/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c > > index d1da635f3..dec5d8cef 100644 > > --- a/Core/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c > > +++ b/Core/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c > > @@ -2384,6 +2384,21 @@ BdsLibBootViaBootOption ( > > 0, > > &ImageHandle > > ); > > + // > > + //Try UBUNTU boot loader > > + // > > + if (EFI_ERROR(Status)) { > > + FilePath =3D FileDevicePath (Handle, > EFI_REMOVABLE_MEDIA_FILE_NAME_UBUNTU); > > + Status =3D gBS->LoadImage ( > > + TRUE, > > + gImageHandle, > > + FilePath, > > + NULL, > > + 0, > > + &ImageHandle > > + ); > > + } > > + > > } > > } > > } > > @@ -3721,6 +3736,17 @@ BdsLibGetBootableHandle ( > > &DosHeader, > > Hdr > > ); > > + // > > + //Try UBUNTU boot loader > > + // > > + if (EFI_ERROR(Status)) { > > + Status =3D BdsLibGetImageHeader ( > > + SimpleFileSystemHandles[Index], > > + EFI_REMOVABLE_MEDIA_FILE_NAME_UBUNTU, > > + &DosHeader, > > + Hdr > > + ); > > + } > > if (!EFI_ERROR (Status) && > > EFI_IMAGE_MACHINE_TYPE_SUPPORTED (Hdr.Pe32- > >FileHeader.Machine) && > > Hdr.Pe32->OptionalHeader.Subsystem =3D=3D > EFI_IMAGE_SUBSYSTEM_EFI_APPLICATION) { > > diff --git a/Core/MdePkg/Include/Uefi/UefiSpec.h > b/Core/MdePkg/Include/Uefi/UefiSpec.h > > index 57cb4e804..e5556952b 100644 > > --- a/Core/MdePkg/Include/Uefi/UefiSpec.h > > +++ b/Core/MdePkg/Include/Uefi/UefiSpec.h > > @@ -2166,11 +2166,12 @@ typedef struct { > > // > > // EFI File location to boot from on removable media devices > > // > > -#define EFI_REMOVABLE_MEDIA_FILE_NAME_IA32 > L"\\EFI\\BOOT\\BOOTIA32.EFI" > > -#define EFI_REMOVABLE_MEDIA_FILE_NAME_IA64 > L"\\EFI\\BOOT\\BOOTIA64.EFI" > > -#define EFI_REMOVABLE_MEDIA_FILE_NAME_X64 > L"\\EFI\\BOOT\\BOOTX64.EFI" > > -#define EFI_REMOVABLE_MEDIA_FILE_NAME_ARM > L"\\EFI\\BOOT\\BOOTARM.EFI" > > -#define EFI_REMOVABLE_MEDIA_FILE_NAME_AARCH64 > L"\\EFI\\BOOT\\BOOTAA64.EFI" > > +#define EFI_REMOVABLE_MEDIA_FILE_NAME_IA32 > L"\\EFI\\BOOT\\BOOTIA32.EFI" > > +#define EFI_REMOVABLE_MEDIA_FILE_NAME_IA64 > L"\\EFI\\BOOT\\BOOTIA64.EFI" > > +#define EFI_REMOVABLE_MEDIA_FILE_NAME_X64 > L"\\EFI\\BOOT\\BOOTX64.EFI" > > +#define EFI_REMOVABLE_MEDIA_FILE_NAME_ARM > L"\\EFI\\BOOT\\BOOTARM.EFI" > > +#define EFI_REMOVABLE_MEDIA_FILE_NAME_AARCH64 > L"\\EFI\\BOOT\\BOOTAA64.EFI" > > +#define EFI_REMOVABLE_MEDIA_FILE_NAME_UBUNTU_X64 > L"\\EFI\\UBUNTU\\GRUBX64.EFI" > > > > #if defined (MDE_CPU_IA32) > > #define EFI_REMOVABLE_MEDIA_FILE_NAME > EFI_REMOVABLE_MEDIA_FILE_NAME_IA32 > > -- > > 2.14.1.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > >