From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=david.wei@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5068B21F322AD for ; Wed, 27 Sep 2017 18:47:09 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2017 18:50:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,447,1500966000"; d="scan'208,217,223";a="133039399" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 27 Sep 2017 18:50:22 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Sep 2017 18:50:22 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Sep 2017 18:50:21 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Thu, 28 Sep 2017 09:50:19 +0800 From: "Wei, David" To: "Yoon, Yeon Sil" , "'edk2-devel@lists.01.org'" CC: "Rytkonen, Teemu S" , "Loeppert, Anthony" , "Guo, Mang" Thread-Topic: [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek Thread-Index: AdM3+zv+uN/9N0NoS6SM6BwE4c691Q== Date: Thu, 28 Sep 2017 01:50:18 +0000 Message-ID: <89954A0B46707A448411A627AD4EEE3468F96141@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: [PATCH] [edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 01:47:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Yeon Sil, Only one comment: We need to add some code in _STA to make sure that this d= evice is only reported to OS when it is actually present on the board. We w= ill make some change to your patch as reference. Thanks, David Wei Intel SSG/STO/UEFI BIOS From: Yoon, Yeon Sil Sent: Thursday, September 28, 2017 6:32 AM To: 'edk2-devel@lists.01.org' Cc: Rytkonen, Teemu S ; Loeppert, Anthony ; Wei, David Subject: Review request for patch to enable SueCreek on Benson Glacier Hello, This is a patch to enable SueCreek module on Benson Glacier h/w. Can you please review it? Thanks! Regards, Yeonsil