From: "Wei, David" <david.wei@intel.com>
To: "Lu, ShifeiX A" <shifeix.a.lu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Blue tooth device.
Date: Fri, 13 Oct 2017 05:39:55 +0000 [thread overview]
Message-ID: <89954A0B46707A448411A627AD4EEE3468FA43AA@SHSMSX151.ccr.corp.intel.com> (raw)
In-Reply-To: <8cc2e618-3c74-41af-bd36-41650e408f5a@SHWDEOPENPSI011.local>
Reviewed-by: zwei4 <david.wei@intel.com>
Thanks,
David Wei
Intel SSG/STO/UEFI BIOS
> -----Original Message-----
> From: Lu, ShifeiX A
> Sent: Friday, October 13, 2017 1:38 PM
> To: edk2-devel@lists.01.org
> Cc: Wei, David <david.wei@intel.com>
> Subject: [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Blue tooth
> device.
>
> Use Pcd to select blue tooth device.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: lushifex <shifeix.a.lu@intel.com>
> ---
> .../Board/MinnowBoard3/BoardInitPostMem/BoardInit.c | 7
> +++++++
> .../Board/MinnowBoard3/BoardInitPostMem/BoardInitMiscs.h | 7
> +++++++
> .../Board/MinnowBoard3/BoardInitPostMem/BoardInitPostMem.inf | 1 +
> .../BroxtonPlatformPkg/Common/Acpi/AcpiPlatformDxe/AcpiPlatform.c | 2
> +-
> .../Common/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 +
> .../PlatformSettings/PlatformSetupDxe/SouthClusterConfig.vfi | 2 ++
> Platform/BroxtonPlatformPkg/PlatformPkg.dec | 2 ++
> 7 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git
> a/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInit.c
> b/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInit.c
> index 0aa9246..60a9d5b 100644
> ---
> a/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInit.c
> +++
> b/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInit.c
> @@ -57,6 +57,7 @@ MinnowBoard3PostMemInitCallback (
> UINT8 BoardId;
> UINT8 FabId;
> UINT8 ResetType;
> + UINT8 BtDevice;
> UINTN BufferSize;
>
> Status = PeiServicesLocatePpi (
> @@ -92,6 +93,12 @@ MinnowBoard3PostMemInitCallback (
> PcdSet8 (PcdResetType, (UINT8) ResetType);
>
> //
> + // Select bluetooth device.
> + //
> + BtDevice = SELECT_BLUE_TOOTH_BCM2E40;
> + PcdSet8 (PcdBtDevice, (UINT8) BtDevice);
> +
> + //
> // Board specific VBT table.
> //
> BufferSize = sizeof (EFI_GUID);
> diff --git
> a/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInitMiscs.h
> b/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInitMiscs.h
> index 2c8c7eb..37faf87 100644
> ---
> a/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInitMiscs.h
> +++
> b/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInitMiscs.h
> @@ -23,6 +23,13 @@
> //
> #define RES_MEM32_MIN_LEN 0x38000000
>
> +//
> +// Bluetooth device identifier.
> +//
> +#define SELECT_BLUE_TOOTH_DISABLE 0x00
> +#define SELECT_BLUE_TOOTH_BCM2E40 0x01
> +#define SELECT_BLUE_TOOTH_BCM2EA1 0x02
> +
> #define RES_IO_BASE 0x0D00
> #define RES_IO_LIMIT 0xFFFF
>
> diff --git
> a/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInitPostMem.inf
> b/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInitPostMem.inf
> index 8fa5ffa..9b42a9f 100644
> ---
> a/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInitPostMem.inf
> +++
> b/Platform/BroxtonPlatformPkg/Board/MinnowBoard3/BoardInitPostMem/
> BoardInitPostMem.inf
> @@ -60,6 +60,7 @@
> gPlatformModuleTokenSpaceGuid.PcdResetType
> gPlatformModuleTokenSpaceGuid.PcdBoardVbtFileGuid
> gPlatformModuleTokenSpaceGuid.PcdSueCreek
> + gPlatformModuleTokenSpaceGuid.PcdBtDevice
>
> [Guids]
> gEfiPlatformInfoGuid
> diff --git
> a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiPlatformDxe/AcpiPlatfo
> rm.c
> b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiPlatformDxe/AcpiPlatfo
> rm.c
> index f0a77d1..d0c668e 100644
> ---
> a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiPlatformDxe/AcpiPlatfo
> rm.c
> +++
> b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiPlatformDxe/AcpiPlatfo
> rm.c
> @@ -1456,7 +1456,7 @@ AcpiPlatformEntryPoint (
> mGlobalNvsArea.Area->Rtd3Support =
> mSystemConfiguration.Rtd3Support;
> mGlobalNvsArea.Area->RTD3Config0 =
> mSystemConfiguration.RTD3ZPODD;
> mGlobalNvsArea.Area->EnableModernStandby =
> mSystemConfiguration.ConsolidatedPR;
> - mGlobalNvsArea.Area->SelectBtDevice =
> mSystemConfiguration.SelectBtDevice;
> + mGlobalNvsArea.Area->SelectBtDevice = (UINT8) PcdGet8
> (PcdBtDevice);
> mGlobalNvsArea.Area->ScHdAudioIoBufferOwnership =
> mSystemConfiguration.ScHdAudioIoBufferOwnership;
> mGlobalNvsArea.Area->XdciEnable =
> mSystemConfiguration.ScUsbOtg;
> mGlobalNvsArea.Area->PciDelayOptimizationEcr =
> mSystemConfiguration.PciDelayOptimizationEcr;
> diff --git
> a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiPlatformDxe/AcpiPlatfo
> rmDxe.inf
> b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiPlatformDxe/AcpiPlatfo
> rmDxe.inf
> index be047c1..9d451f5 100644
> ---
> a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiPlatformDxe/AcpiPlatfo
> rmDxe.inf
> +++
> b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiPlatformDxe/AcpiPlatfo
> rmDxe.inf
> @@ -87,6 +87,7 @@
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> gPlatformModuleTokenSpaceGuid.PcdResetType
> gPlatformModuleTokenSpaceGuid.PcdSueCreek
> + gPlatformModuleTokenSpaceGuid.PcdBtDevice
>
> [Depex]
> gEfiAcpiSupportProtocolGuid AND
> diff --git
> a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupD
> xe/SouthClusterConfig.vfi
> b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetup
> Dxe/SouthClusterConfig.vfi
> index 1b0e93d..448105c 100644
> ---
> a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupD
> xe/SouthClusterConfig.vfi
> +++
> b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetup
> Dxe/SouthClusterConfig.vfi
> @@ -186,6 +186,7 @@ form formid = MISC_OPTIONS_FORM_ID,
> subtitle text = STRING_TOKEN(STR_NULL_STRING);
> subtitle text = STRING_TOKEN(STR_LPSS_DEVICE_SETTING_SUBTITLE);
>
> +suppressif TRUE;
> oneof varid = SETUP_DATA.SelectBtDevice,
> prompt = STRING_TOKEN(STR_PCH_SERIAL_IO_BLUETOOTH_DEVICE),
> help = STRING_TOKEN(STR_PCH_SERIAL_IO_BLUETOOTH_HELP),
> @@ -193,6 +194,7 @@ form formid = MISC_OPTIONS_FORM_ID,
> option text = STRING_TOKEN(STR_BT_BCM2E40), value = 1, flags =
> RESET_REQUIRED;
> // option text = STRING_TOKEN(STR_BT_BCM2EA1), value = 2, flags =
> RESET_REQUIRED;
> endoneof;
> +endif;
>
> oneof varid = Setup.I2s343A,
> prompt = STRING_TOKEN(STR_I2C_DEVICE_CODEC_INT343A_PROMPT),
> diff --git a/Platform/BroxtonPlatformPkg/PlatformPkg.dec
> b/Platform/BroxtonPlatformPkg/PlatformPkg.dec
> index f37ceaf..3945b66 100644
> --- a/Platform/BroxtonPlatformPkg/PlatformPkg.dec
> +++ b/Platform/BroxtonPlatformPkg/PlatformPkg.dec
> @@ -184,6 +184,8 @@
> gPlatformModuleTokenSpaceGuid.PcdBoardVbtFileGuid|{ 0x00, 0x00, 0x00,
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> 0x00 }|VOID*|0x80000014
> ## This PCD used to enable or disable SueCreek
>
> gPlatformModuleTokenSpaceGuid.PcdSueCreek|FALSE|BOOLEAN|0x800000
> 15
> + ## This PCD used to select bluetooth device
> + gPlatformModuleTokenSpaceGuid.PcdBtDevice|0x00|UINT8|0x80000016
>
> ## MemoryCheck value for checking memory before boot OS.
> ## To save the boot performance, the default MemoryCheck is set to 0.
> --
> 2.7.0.windows.1
>
next prev parent reply other threads:[~2017-10-13 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 5:37 [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Blue tooth device lushifex
2017-10-13 5:39 ` Wei, David [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-13 8:27 lushifex
2017-10-14 3:52 lushifex
2017-10-14 3:53 lushifex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89954A0B46707A448411A627AD4EEE3468FA43AA@SHSMSX151.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox