public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add I2C table.
@ 2017-10-30  9:05 lushifex
  2017-10-30  9:10 ` Wei, David
  0 siblings, 1 reply; 2+ messages in thread
From: lushifex @ 2017-10-30  9:05 UTC (permalink / raw)
  To: edk2-devel; +Cc: david.wei

Add I2C table for on-board WM8731 I2S audio.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: lushifex <shifeix.a.lu@intel.com>
---
 .../PlatformSsdt/Audio/AudioCodec_INT343A.asl           | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSsdt/Audio/AudioCodec_INT343A.asl b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSsdt/Audio/AudioCodec_INT343A.asl
index a1756ec..b11793b 100644
--- a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSsdt/Audio/AudioCodec_INT343A.asl
+++ b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSsdt/Audio/AudioCodec_INT343A.asl
@@ -1,5 +1,5 @@
 /** @file
-  Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2012 - 2017, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -14,13 +14,10 @@
 External(\IOBF, IntObj) // ScHdAudioIoBufferOwnership
 External(\IS3A, IntObj)
 
-Scope(\_SB.PCI0.I2C0) {
+  Scope(\_SB.PCI0.I2C7) {
   //-----------------------------------
   //  HD Audio I2S Codec device
-  //  ALC 298
-  //  I2C1
-  //  GPIO_192:SOC_CODEC_PD_N    North West Community number 5
-  //  GPIO_116:SOC_CODEC_IRQ     North West Community, direct IRQ, IRQ number 0x5B.
+  //  I2C7
   //-----------------------------------
   Device (HDAC)
   {
@@ -35,14 +32,10 @@ Scope(\_SB.PCI0.I2C0) {
 
     Method (_CRS, 0, Serialized) {
       Name (SBFB, ResourceTemplate () {
-        I2cSerialBus (0x1C, ControllerInitiated, 400000, AddressingMode7Bit, "\\_SB.PCI0.I2C0",,,)
+        I2cSerialBus (0x1A, ControllerInitiated, 400000, AddressingMode7Bit, "\\_SB.PCI0.I2C7",0x00, ResourceConsumer,,)
       })
 
-      Name (SBFI, ResourceTemplate () {
-        Interrupt (ResourceConsumer, Level, ActiveLow, ExclusiveAndWake,,,) {0x5B}
-      })
-
-      Return (ConcatenateResTemplate(SBFB, SBFI))
+      Return (SBFB)
     }
 
     Method (_STA, 0, NotSerialized)
-- 
2.7.0.windows.1




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add I2C table.
  2017-10-30  9:05 [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add I2C table lushifex
@ 2017-10-30  9:10 ` Wei, David
  0 siblings, 0 replies; 2+ messages in thread
From: Wei, David @ 2017-10-30  9:10 UTC (permalink / raw)
  To: Lu, ShifeiX A, edk2-devel@lists.01.org

Reviewed-by: zwei4 <david.wei@intel.com>

Thanks,
David  Wei

Intel SSG/STO/UEFI BIOS                                 

> -----Original Message-----
> From: Lu, ShifeiX A
> Sent: Monday, October 30, 2017 5:06 PM
> To: edk2-devel@lists.01.org
> Cc: Wei, David <david.wei@intel.com>
> Subject: [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add I2C
> table.
> 
> Add I2C table for on-board WM8731 I2S audio.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: lushifex <shifeix.a.lu@intel.com>
> ---
>  .../PlatformSsdt/Audio/AudioCodec_INT343A.asl           | 17 +++++------------
>  1 file changed, 5 insertions(+), 12 deletions(-)
> 
> diff --git
> a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSs
> dt/Audio/AudioCodec_INT343A.asl
> b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSs
> dt/Audio/AudioCodec_INT343A.asl
> index a1756ec..b11793b 100644
> ---
> a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSs
> dt/Audio/AudioCodec_INT343A.asl
> +++
> b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSs
> dt/Audio/AudioCodec_INT343A.asl
> @@ -1,5 +1,5 @@
>  /** @file
> -  Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2012 - 2017, Intel Corporation. All rights reserved.<BR>
> 
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
> @@ -14,13 +14,10 @@
>  External(\IOBF, IntObj) // ScHdAudioIoBufferOwnership
>  External(\IS3A, IntObj)
> 
> -Scope(\_SB.PCI0.I2C0) {
> +  Scope(\_SB.PCI0.I2C7) {
>    //-----------------------------------
>    //  HD Audio I2S Codec device
> -  //  ALC 298
> -  //  I2C1
> -  //  GPIO_192:SOC_CODEC_PD_N    North West Community number 5
> -  //  GPIO_116:SOC_CODEC_IRQ     North West Community, direct IRQ, IRQ
> number 0x5B.
> +  //  I2C7
>    //-----------------------------------
>    Device (HDAC)
>    {
> @@ -35,14 +32,10 @@ Scope(\_SB.PCI0.I2C0) {
> 
>      Method (_CRS, 0, Serialized) {
>        Name (SBFB, ResourceTemplate () {
> -        I2cSerialBus (0x1C, ControllerInitiated, 400000, AddressingMode7Bit,
> "\\_SB.PCI0.I2C0",,,)
> +        I2cSerialBus (0x1A, ControllerInitiated, 400000, AddressingMode7Bit,
> "\\_SB.PCI0.I2C7",0x00, ResourceConsumer,,)
>        })
> 
> -      Name (SBFI, ResourceTemplate () {
> -        Interrupt (ResourceConsumer, Level, ActiveLow, ExclusiveAndWake,,,)
> {0x5B}
> -      })
> -
> -      Return (ConcatenateResTemplate(SBFB, SBFI))
> +      Return (SBFB)
>      }
> 
>      Method (_STA, 0, NotSerialized)
> --
> 2.7.0.windows.1
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-30  9:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-30  9:05 [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Add I2C table lushifex
2017-10-30  9:10 ` Wei, David

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox