public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wei, David" <david.wei@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 1/2] Vlv2TbltDevicePkg: Use DpDynamicCommand to replace PerformancePkg/dp
Date: Wed, 29 Nov 2017 08:38:48 +0000	[thread overview]
Message-ID: <89954A0B46707A448411A627AD4EEE3468FC4CBC@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20171129081439.278964-2-ruiyu.ni@intel.com>

Reviewed-by: zwei4  <david.wei@intel.com> 

Thanks,
David  Wei

Intel SSG/STO/UEFI BIOS                                 

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, November 29, 2017 4:15 PM
> To: edk2-devel@lists.01.org
> Cc: Wei, David <david.wei@intel.com>
> Subject: [PATCH 1/2] Vlv2TbltDevicePkg: Use DpDynamicCommand to
> replace PerformancePkg/dp
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: David David <david.wei@intel.com>
> ---
>  Vlv2TbltDevicePkg/PlatformPkg.fdf       |  9 +++++++--
>  Vlv2TbltDevicePkg/PlatformPkgGcc.fdf    |  9 +++++++--
>  Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 18 +++++++++++-------
>  Vlv2TbltDevicePkg/PlatformPkgIA32.dsc   | 18 +++++++++++-------
>  Vlv2TbltDevicePkg/PlatformPkgX64.dsc    | 18 +++++++++++-------
>  5 files changed, 47 insertions(+), 25 deletions(-)
> 
> diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf
> b/Vlv2TbltDevicePkg/PlatformPkg.fdf
> index cb5b6b7cc3..5ed85f4dee 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkg.fdf
> +++ b/Vlv2TbltDevicePkg/PlatformPkg.fdf
> @@ -1,7 +1,7 @@
>  #/** @file
>  # FDF file of Platform.
>  #
> -# Copyright (c) 2008 - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2008 - 2017, Intel Corporation. All rights reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made
> available under
>  # the terms and conditions of the BSD License that accompanies this
> distribution.
> @@ -716,7 +716,12 @@ [FV.FVMAIN]
>      SECTION PE32 =
> ShellBinPkg/UefiShell/$(EDK_DXE_ARCHITECTURE)/Shell.efi
>    }
> 
> -
> +#
> +# dp command
> +#
> +!if $(PERFORMANCE_ENABLE) == TRUE
> +INF
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> +!endif
> 
>  !if $(GOP_DRIVER_ENABLE) == TRUE
>  FILE FREEFORM = 878AC2CC-5343-46F2-B563-51F89DAF56BA {
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
> b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
> index 4243b0797b..a02a4f6286 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
> +++ b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
> @@ -1,7 +1,7 @@
>  #/** @file
>  # FDF file of Platform.
>  #
> -# Copyright (c) 2008 - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2008 - 2017, Intel Corporation. All rights reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made
> available under
>  # the terms and conditions of the BSD License that accompanies this
> distribution.
> @@ -673,7 +673,12 @@ [FV.FVMAIN]
>     SECTION PE32 =
> EdkShellBinPkg/MinimumShell/$(EDK_DXE_ARCHITECTURE)/Shell.efi
>    }
> 
> -
> +#
> +# dp command
> +#
> +!if $(PERFORMANCE_ENABLE) == TRUE
> +INF
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> +!endif
> 
>  !if $(GOP_DRIVER_ENABLE) == TRUE
>  FILE FREEFORM = 878AC2CC-5343-46F2-B563-51F89DAF56BA {
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> index d773cbd726..f98263d8a5 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> @@ -1,7 +1,7 @@
>  #/** @file
>  # Platform description.
>  #
> -# Copyright (c) 2012  - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2012  - 2017, Intel Corporation. All rights reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made
> available under
>  # the terms and conditions of the BSD License that accompanies this
> distribution.
> @@ -1279,13 +1279,17 @@ [Components.X64]
> 
> 
> IntelFrameworkModulePkg/Universal/LegacyRegionDxe/LegacyRegionDxe.i
> nf
> 
> -  PerformancePkg/Dp_App/Dp.inf {
> -  <LibraryClasses>
> -  !if $(PERFORMANCE_ENABLE) == TRUE
> -
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> -
> TimerLib|$(PLATFORM_PACKAGE)/Library/IntelPchAcpiTimerLib/IntelPchAc
> piTimerLib.inf
> -  !endif
> +  #
> +  # Performance Application; Set PERFORMANCE_ENABLE=TRUE for normal
> boot performance and smm performance data
> +  #
> +!if $(PERFORMANCE_ENABLE) == TRUE
> +
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> {
> +    <PcdsFixedAtBuild>
> +      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> +    <LibraryClasses>
> +
> PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmm
> PerformanceLib.inf
>    }
> +!endif
> 
>    Vlv2TbltDevicePkg/VlvPlatformInitDxe/VlvPlatformInitDxe.inf{
>      <LibraryClasses>
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index ac52340079..c755df2fe2 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -1,7 +1,7 @@
>  #/** @file
>  # Platform description.
>  #
> -# Copyright (c) 2012  - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2012  - 2017, Intel Corporation. All rights reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made
> available under
>  # the terms and conditions of the BSD License that accompanies this
> distribution.
> @@ -1267,13 +1267,17 @@ [Components.IA32]
> 
> 
> IntelFrameworkModulePkg/Universal/LegacyRegionDxe/LegacyRegionDxe.i
> nf
> 
> -  PerformancePkg/Dp_App/Dp.inf {
> -  <LibraryClasses>
> -  !if $(PERFORMANCE_ENABLE) == TRUE
> -
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> -
> TimerLib|$(PLATFORM_PACKAGE)/Library/IntelPchAcpiTimerLib/IntelPchAc
> piTimerLib.inf
> -  !endif
> +  #
> +  # Performance Application; Set PERFORMANCE_ENABLE=TRUE for normal
> boot performance and smm performance data
> +  #
> +!if $(PERFORMANCE_ENABLE) == TRUE
> +
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> {
> +    <PcdsFixedAtBuild>
> +      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> +    <LibraryClasses>
> +
> PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmm
> PerformanceLib.inf
>    }
> +!endif
> 
>    Vlv2TbltDevicePkg/VlvPlatformInitDxe/VlvPlatformInitDxe.inf{
>      <LibraryClasses>
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 0f0eaaba6c..dda8216e6a 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -1,7 +1,7 @@
>  #/** @file
>  # Platform description.
>  #
> -# Copyright (c) 2012  - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2012  - 2017, Intel Corporation. All rights reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made
> available under
>  # the terms and conditions of the BSD License that accompanies this
> distribution.
> @@ -1279,13 +1279,17 @@ [Components.X64]
> 
> 
> IntelFrameworkModulePkg/Universal/LegacyRegionDxe/LegacyRegionDxe.i
> nf
> 
> -  PerformancePkg/Dp_App/Dp.inf {
> -  <LibraryClasses>
> -  !if $(PERFORMANCE_ENABLE) == TRUE
> -
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> -
> TimerLib|$(PLATFORM_PACKAGE)/Library/IntelPchAcpiTimerLib/IntelPchAc
> piTimerLib.inf
> -  !endif
> +  #
> +  # Performance Application; Set PERFORMANCE_ENABLE=TRUE for normal
> boot performance and smm performance data
> +  #
> +!if $(PERFORMANCE_ENABLE) == TRUE
> +
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> {
> +    <PcdsFixedAtBuild>
> +      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> +    <LibraryClasses>
> +
> PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmm
> PerformanceLib.inf
>    }
> +!endif
> 
>    Vlv2TbltDevicePkg/VlvPlatformInitDxe/VlvPlatformInitDxe.inf{
>      <LibraryClasses>
> --
> 2.15.0.gvfs.1.preview.4



  reply	other threads:[~2017-11-29  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  8:14 [PATCH 0/2] Use DpDynamicCommand to replace PerformancePkg/dp Ruiyu Ni
2017-11-29  8:14 ` [PATCH 1/2] Vlv2TbltDevicePkg: " Ruiyu Ni
2017-11-29  8:38   ` Wei, David [this message]
2017-11-29  8:14 ` [PATCH 2/2] QuarkPlatformPkg: " Ruiyu Ni
2017-12-01 17:18   ` Steele, Kelly
2017-12-02  8:44     ` Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89954A0B46707A448411A627AD4EEE3468FC4CBC@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox