From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=david.wei@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 40F7421CF1CE6 for ; Mon, 12 Feb 2018 19:19:57 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2018 19:25:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,505,1511856000"; d="scan'208";a="29547392" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 12 Feb 2018 19:25:47 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Feb 2018 19:25:47 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Feb 2018 19:25:47 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.253]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Tue, 13 Feb 2018 11:25:44 +0800 From: "Wei, David" To: "Rytkonen, Teemu S" , "edk2-devel@lists.01.org" CC: "Loeppert, Anthony" Thread-Topic: [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 1/2] Add support for SueCreek LED Drivers Thread-Index: AQHTpEoWdHlKQT1oMEqI72rrQTWdt6Ohq/ig Date: Tue, 13 Feb 2018 03:25:43 +0000 Message-ID: <89954A0B46707A448411A627AD4EEE3469007B15@SHSMSX101.ccr.corp.intel.com> References: <20180212213142.14112-1-teemu.s.rytkonen@intel.com> In-Reply-To: <20180212213142.14112-1-teemu.s.rytkonen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDE0YmM4YjgtN2EzYS00NzkwLThmOWItOWVlMWJkMTI3ZTM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJtTjBxbWZYbGdwZVhEZ3FlZ0ZUSFwvaU9Fc3pDeHdyak9UazYxMXNKc3lZRUloS1wvTHFHWmFCN0RzS2dGRmVVTTkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 1/2] Add support for SueCreek LED Drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 03:19:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS =20 -----Original Message----- From: Rytkonen, Teemu S=20 Sent: Tuesday, February 13, 2018 5:32 AM To: edk2-devel@lists.01.org Cc: Wei, David ; Loeppert, Anthony ; Rytkonen, Teemu S Subject: [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017 1/2] Add support= for SueCreek LED Drivers Adds support for two ACPI entries for PCA9956 LED drivers for SueCreek DMIC board. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Teemu Rytkonen --- .../AcpiTablesPCAT/PlatformSsdt/PlatformSsdt.asl | 3 + .../PlatformSsdt/SueCreek/SueCreek.asl | 10 ++-- .../PlatformSsdt/SueCreek/SueCreekLeds.asl | 70 ++++++++++++++++++= ++++ 3 files changed, 77 insertions(+), 6 deletions(-) create mode 100644 Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/= PlatformSsdt/SueCreek/SueCreekLeds.asl diff --git a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/Platfor= mSsdt/PlatformSsdt.asl b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTables= PCAT/PlatformSsdt/PlatformSsdt.asl index b86baf357..93e2592ba 100644 --- a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSsdt/P= latformSsdt.asl +++ b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSsdt/P= latformSsdt.asl @@ -36,12 +36,14 @@ DefinitionBlock ( External(\_SB.GPO0.CWLE, IntObj) External(\_SB.GPO0.AVBL, IntObj) External(\_SB.PCI0.SDIO.PSTS, IntObj) + External(\SUCE, IntObj) External(HIDG, MethodObj) External(OSYS, IntObj) External(SBTD, IntObj) External(WCAS, IntObj) External(UCAS, IntObj) External(CROT, IntObj) + External(TP7G) External(IPUD) =20 @@ -72,6 +74,7 @@ DefinitionBlock ( =20 include ("Fingerprint/Fingerprint_FPC.asl") include ("SueCreek/SueCreek.asl") + include ("SueCreek/SueCreekLeds.asl") include ("Sensors/GenericSpi3.asl") } =20 diff --git a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/Platfor= mSsdt/SueCreek/SueCreek.asl b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiT= ablesPCAT/PlatformSsdt/SueCreek/SueCreek.asl index 3baa88cc4..b9a3fa9ca 100644 --- a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSsdt/S= ueCreek/SueCreek.asl +++ b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSsdt/S= ueCreek/SueCreek.asl @@ -14,7 +14,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. =20 Scope (\_SB.PCI0.SPI1) { Device (TP0) { - Name (_HID, "SUE1000") + Name (_HID, "SUE1000") Name (_DDN, "SueCreek - SPI0, CS0") Name (_CRS, ResourceTemplate () { SpiSerialBus ( @@ -23,15 +23,13 @@ Scope (\_SB.PCI0.SPI1) { FourWireMode, // Full duplex 8, // Bits per word is 8 (byte) ControllerInitiated, // Don't care - 9600000, // 9.6 MHz - ClockPolarityHigh, // SPI mode 3 - ClockPhaseSecond, // SPI mode 3 + 9600000, // 9.6 MHz + ClockPolarityHigh, // SPI mode 3 + ClockPhaseSecond, // SPI mode 3 "\\_SB.PCI0.SPI1", // SPI host controller 0 // Must be 0 ) }) - - External(\SUCE, IntObj) Method (_STA, 0x0, NotSerialized) { If (LEqual (SUCE, 0)) { Return (0x0) diff --git a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/Platfor= mSsdt/SueCreek/SueCreekLeds.asl b/Platform/BroxtonPlatformPkg/Common/Acpi/A= cpiTablesPCAT/PlatformSsdt/SueCreek/SueCreekLeds.asl new file mode 100644 index 000000000..2fcc45742 --- /dev/null +++ b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/PlatformSsdt/S= ueCreek/SueCreekLeds.asl @@ -0,0 +1,70 @@ +/** @file + +Copyright (c) 2017 Intel Corporation. + +This program and the accompanying materials +are licensed and made available under the terms and conditions of the BSD = License +which accompanies this distribution. The full text of the license may be = found at +http://opensource.org/licenses/bsd-license.php + +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLI= ED. + +**/ + +Scope(\_SB.PCI0.I2C5) { + Device (LED0) { + Name (_HID, "PCA9956") + Name (_DDN, "SueCreekLed, CS0") + Name (SBUF, ResourceTemplate () { + I2cSerialBus ( + 0x0065, + ControllerInitiated, + 400000, + AddressingMode7Bit, + "\\_SB.PCI0.I2C5", + 0x00, + ResourceConsumer, + , + ) + }) + Method (_CRS, 0, NotSerialized) + { + Return (SBUF) + } + Method (_STA, 0x0, NotSerialized) { + If (LEqual (SUCE, 0)) { + Return (0x0) + } else { + Return (0xF) + } + } + } + Device (LED1) { + Name (_HID, "PCA9956") + Name (_DDN, "SueCreekLed, CS0") + Name (SBUF, ResourceTemplate () { + I2cSerialBus ( + 0x0069, + ControllerInitiated, + 400000, + AddressingMode7Bit, + "\\_SB.PCI0.I2C5", + 0x00, + ResourceConsumer, + , + ) + }) + Method (_CRS, 0, NotSerialized) + { + Return (SBUF) + } + Method (_STA, 0x0, NotSerialized) { + If (LEqual (SUCE, 0)) { + Return (0x0) + } else { + Return (0xF) + } + } + } +} --=20 2.15.1.windows.2