From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=david.wei@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1EC1121F85E76 for ; Tue, 27 Mar 2018 23:05:11 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 23:11:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,369,1517904000"; d="scan'208";a="37472575" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 27 Mar 2018 23:11:48 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 23:11:48 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 23:11:48 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.166]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.226]) with mapi id 14.03.0319.002; Wed, 28 Mar 2018 14:11:46 +0800 From: "Wei, David" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Guo, Mang" , "Yao, Jiewen" Thread-Topic: [Patch 2/5] Vlv2TbltDevicePkg: Fix VS2015 build breaks Thread-Index: AQHTxlZUt7GLdECJZE2PAzHQnWGUcaPlKpTA Date: Wed, 28 Mar 2018 06:11:46 +0000 Message-ID: <89954A0B46707A448411A627AD4EEE3469025368@SHSMSX101.ccr.corp.intel.com> References: <20180328053330.13272-1-michael.d.kinney@intel.com> <20180328053330.13272-3-michael.d.kinney@intel.com> In-Reply-To: <20180328053330.13272-3-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQwMjM5MzQtZWEzNi00OTlhLTkyZTktNjNjMTUzMDVmY2EwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIxbFVDNFpTV0FQOXdzQkRqVHRpK3VaTzE0b0FDTTVxUzhsSFZZOWNHK2xHS0RuemsyN3p1VVdqcTJHamhEaDhQIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 2/5] Vlv2TbltDevicePkg: Fix VS2015 build breaks X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 06:05:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS =20 -----Original Message----- From: Kinney, Michael D=20 Sent: Wednesday, March 28, 2018 1:33 PM To: edk2-devel@lists.01.org Cc: Wei, David ; Guo, Mang ; Yao, = Jiewen ; Kinney, Michael D Subject: [Patch 2/5] Vlv2TbltDevicePkg: Fix VS2015 build breaks https://bugzilla.tianocore.org/show_bug.cgi?id=3D911 Fix minor code issues that break VS2015 builds. Cc: David Wei Cc: Mang Guo Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c | 1 - Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscProcessorCacheFunction.c | 6 ------ Vlv2TbltDevicePkg/VlvPlatformInitDxe/VlvPlatformInit.c | 2 +- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c b/Vlv2Tb= ltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c index b0e29f02d0..f608651cd4 100644 --- a/Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c +++ b/Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c @@ -1185,7 +1185,6 @@ UpdatePlatformInformation ( EFI_STATUS Status; UINT8 CpuFlavor=3D0; EFI_PEI_HOB_POINTERS GuidHob; - EFI_PLATFORM_INFO_HOB *mPlatformInfo=3DNULL; UINTN NumHandles; EFI_HANDLE *HandleBuffer; UINTN Index; diff --git a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscProcessorCacheFunction.c b= /Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscProcessorCacheFunction.c index b18a6aaa3b..4a83aedc97 100644 --- a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscProcessorCacheFunction.c +++ b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscProcessorCacheFunction.c @@ -28,12 +28,6 @@ Abstract: #include #include =20 - -extern SMBIOS_TABLE_TYPE7 *SmbiosRecordL1; -extern SMBIOS_TABLE_TYPE7 *SmbiosRecordL2; -extern SMBIOS_TABLE_TYPE7 *SmbiosRecordL3; - - UINT32 ConvertBase2ToRaw ( IN EFI_EXP_BASE2_DATA *Data) diff --git a/Vlv2TbltDevicePkg/VlvPlatformInitDxe/VlvPlatformInit.c b/Vlv2T= bltDevicePkg/VlvPlatformInitDxe/VlvPlatformInit.c index 5e8d95ae9f..f8274e9df0 100644 --- a/Vlv2TbltDevicePkg/VlvPlatformInitDxe/VlvPlatformInit.c +++ b/Vlv2TbltDevicePkg/VlvPlatformInitDxe/VlvPlatformInit.c @@ -147,7 +147,7 @@ PostPmInitCallBack ( EFI_STATUS IgdPmHook ( IN EFI_HANDLE ImageHandle, - IN DXE_VLV_PLATFORM_POLICY_PROTOCOL *DxePlatformSaPolicy + IN DXE_VLV_PLATFORM_POLICY_PROTOCOL *DxePlatformSaPolicyParam ) { =20 --=20 2.14.2.windows.3