* [PATCH 1/1] Vlv2TbltDevicePkg/SmBiosMiscDxe: fix the comparison of characters
@ 2018-10-30 7:56 Gary Lin
2018-11-04 6:13 ` Wei, David
0 siblings, 1 reply; 2+ messages in thread
From: Gary Lin @ 2018-10-30 7:56 UTC (permalink / raw)
To: edk2-devel; +Cc: David Wei, Mang Guo, Michael D Kinney
Dereference MatchLang before comparing it with a character.
Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin <glin@suse.com>
---
.../SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
index 7cf3453a62f4..612e1261fdaa 100644
--- a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
+++ b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
@@ -73,7 +73,7 @@ CurrentLanguageMatch (
// Find the best matching RFC 4646 language, compute the offset.
//
CompareLength = AsciiStrLen (BestLanguage);
- for (MatchLang = Languages, (*Offset) = 0; MatchLang != '\0'; (*Offset)++) {
+ for (MatchLang = Languages, (*Offset) = 0; *MatchLang != '\0'; (*Offset)++) {
//
// Seek to the end of current match language.
//
--
2.19.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] Vlv2TbltDevicePkg/SmBiosMiscDxe: fix the comparison of characters
2018-10-30 7:56 [PATCH 1/1] Vlv2TbltDevicePkg/SmBiosMiscDxe: fix the comparison of characters Gary Lin
@ 2018-11-04 6:13 ` Wei, David
0 siblings, 0 replies; 2+ messages in thread
From: Wei, David @ 2018-11-04 6:13 UTC (permalink / raw)
To: Gary Lin, edk2-devel@lists.01.org; +Cc: Guo, Mang, Kinney, Michael D
Reviewed-by: David Wei <david.wei@intel.com>
Thanks,
David Wei
Intel SSG/STO/UEFI BIOS
-----Original Message-----
From: Gary Lin [mailto:glin@suse.com]
Sent: Tuesday, October 30, 2018 3:57 PM
To: edk2-devel@lists.01.org
Cc: Wei, David <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [PATCH 1/1] Vlv2TbltDevicePkg/SmBiosMiscDxe: fix the comparison of characters
Dereference MatchLang before comparing it with a character.
Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin <glin@suse.com>
---
.../SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
index 7cf3453a62f4..612e1261fdaa 100644
--- a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
+++ b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
@@ -73,7 +73,7 @@ CurrentLanguageMatch (
// Find the best matching RFC 4646 language, compute the offset.
//
CompareLength = AsciiStrLen (BestLanguage);
- for (MatchLang = Languages, (*Offset) = 0; MatchLang != '\0'; (*Offset)++) {
+ for (MatchLang = Languages, (*Offset) = 0; *MatchLang != '\0'; (*Offset)++) {
//
// Seek to the end of current match language.
//
--
2.19.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-04 6:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-30 7:56 [PATCH 1/1] Vlv2TbltDevicePkg/SmBiosMiscDxe: fix the comparison of characters Gary Lin
2018-11-04 6:13 ` Wei, David
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox