From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=david.wei@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B05FB21159819 for ; Sun, 4 Nov 2018 19:34:57 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2018 19:34:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,466,1534834800"; d="scan'208";a="105917449" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 04 Nov 2018 19:34:56 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 4 Nov 2018 19:34:56 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 4 Nov 2018 19:34:56 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.102]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.161]) with mapi id 14.03.0415.000; Mon, 5 Nov 2018 11:34:54 +0800 From: "Wei, David" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Sun, Zailiang" Thread-Topic: [PATCH v3 2/5] Vlv2TbltDevicePkg: Remove EdkShellBinPkg with ShellPkg Thread-Index: AQHUdLTQdBOa2gUVwUGsEFfwun+mnqVAh4ZA Date: Mon, 5 Nov 2018 03:34:54 +0000 Message-ID: <89954A0B46707A448411A627AD4EEE3473BCD574@SHSMSX101.ccr.corp.intel.com> References: <20181105030807.27420-1-shenglei.zhang@intel.com> <20181105030807.27420-3-shenglei.zhang@intel.com> In-Reply-To: <20181105030807.27420-3-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDEyZjI4OTAtY2FmZS00OTU4LWJiY2UtY2I1MWU1M2IyOWNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN2ZnbmJrODdoZVwvZ2MzNmJ4Z1NXQlgxZVR4c0lkRXBidnlCZmFcL3NUNnFOM2h6aWRtUzM5M2ZRZytGXC9cLzlIRnMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 2/5] Vlv2TbltDevicePkg: Remove EdkShellBinPkg with ShellPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 03:34:57 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS =20 -----Original Message----- From: Zhang, Shenglei=20 Sent: Monday, November 5, 2018 11:08 AM To: edk2-devel@lists.01.org Cc: Zhang, Shenglei ; Wei, David ; Sun, Zailiang Subject: [PATCH v3 2/5] Vlv2TbltDevicePkg: Remove EdkShellBinPkg with Shell= Pkg From: shenglei Replace EdkShellBinPkg with ShellPkg in PlatformPkg.fdf, PlatformPkgGcc.fdf, PlatformPkgGccX64.dsc, PlatformPkgIA32.dsc and PlatformPkgX64.dsc. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1108 Cc: David Wei Cc: zailiang sun Change-Id: I4db7068a3a1f68a1f6303079b73dc548c9feb2e3 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: David Wei --- Vlv2TbltDevicePkg/PlatformPkg.fdf | 5 +---- Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 5 +---- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + 5 files changed, 5 insertions(+), 8 deletions(-) diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf b/Vlv2TbltDevicePkg/Platform= Pkg.fdf index b7a0e584de..89c488372d 100644 --- a/Vlv2TbltDevicePkg/PlatformPkg.fdf +++ b/Vlv2TbltDevicePkg/PlatformPkg.fdf @@ -709,10 +709,7 @@ INF FatPkg/EnhancedFatDxe/Fat.inf # # UEFI Shell # -FILE APPLICATION =3D PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShel= lFile) { -# SECTION PE32 =3D EdkShellBinPkg/FullShell/$(EDK_DXE_ARCHITECTURE)/She= ll_Full.efi - SECTION PE32 =3D ShellBinPkg/UefiShell/$(EDK_DXE_ARCHITECTURE)/Shell.e= fi - } +INF ShellPkg/Application/Shell/Shell.inf =20 # # dp command diff --git a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf b/Vlv2TbltDevicePkg/Platf= ormPkgGcc.fdf index eca273e33f..e7bbda1a56 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf +++ b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf @@ -665,10 +665,7 @@ INF FatPkg/EnhancedFatDxe/Fat.inf # # UEFI Shell # -FILE APPLICATION =3D PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShel= lFile) { -# SECTION PE32 =3D EdkShellBinPkg/FullShell/$(EDK_DXE_ARCHITECTURE)/She= ll_Full.efi - SECTION PE32 =3D ShellBinPkg/UefiShell/$(EDK_DXE_ARCHITECTURE)/Shell.e= fi - } +INF ShellPkg/Application/Shell/Shell.inf =20 # # dp command diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/Pl= atformPkgGccX64.dsc index 3e3522aee9..af2e701372 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc @@ -1462,6 +1462,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGE= T)/IA32/fTPMInitPeim.inf MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf FatPkg/EnhancedFatDxe/Fat.inf + ShellPkg/Application/Shell/Shell.inf !if $(SATA_ENABLE) =3D=3D TRUE $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITECTU= RE)/SataController.inf !endif diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/Plat= formPkgIA32.dsc index 55c873d565..38403f8f20 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc @@ -1450,6 +1450,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGE= T)/IA32/fTPMInitPeim.inf MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf FatPkg/EnhancedFatDxe/Fat.inf + ShellPkg/Application/Shell/Shell.inf !if $(SATA_ENABLE) =3D=3D TRUE $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITECTU= RE)/SataController.inf !endif diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/Platf= ormPkgX64.dsc index fa6aa63491..13499b7c9e 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc @@ -1462,6 +1462,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGE= T)/IA32/fTPMInitPeim.inf MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf FatPkg/EnhancedFatDxe/Fat.inf + ShellPkg/Application/Shell/Shell.inf !if $(SATA_ENABLE) =3D=3D TRUE $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITECTU= RE)/SataController.inf !endif --=20 2.18.0.windows.1