Re: [edk2-devel] [Wiki Patch 1/2] Remove Contributed-under tags

["Laszlo Ersek" <lersek@redhat.com>]

On 04/13/19 00:50, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1656
> 
> With the change to BSD+Patent License, the TianoCore Contributor's
> Agreement has been removed and as a result, a Contributed under
> tag is no longer appropriate in commit messages.  Remove this tag
> from all commit message examples in the tianocore wiki.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Commit-Message-Format.md                                       | 3 ---
>  Commit-Signature-Format.md                                     | 1 -
>  ...-unkempt-git-guide-for-edk2-contributors-and-maintainers.md | 3 +--
>  3 files changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/Commit-Message-Format.md b/Commit-Message-Format.md
> index ef60f75..97ea351 100644
> --- a/Commit-Message-Format.md
> +++ b/Commit-Message-Format.md
> @@ -11,7 +11,6 @@ Pkg-Module: Brief-single-line-summary
>  
>  Full-commit-message
>  
> -Contributed-under: TianoCore Contribution Agreement 1.1
>  Signed-off-by: Contributor Name &lt;contributor@email.server&gt;
>  </pre>
>  
> @@ -39,7 +38,6 @@ Several lines of
>  description for the
>  change.
>  
> -Contributed-under: TianoCore Contribution Agreement 1.1
>  Signed-off-by: Contributor Name &lt;contributor@email.server&gt;
>  Reviewed-by: Reviewer Name &lt;reviewer@reviewer-email.server&gt;
>  </Pre>
> @@ -54,7 +52,6 @@ Several lines of
>  description for the
>  change.
>  
> -Contributed-under: TianoCore Contribution Agreement 1.1
>  Signed-off-by: Contributor Name &lt;contributor@email.server&gt;
>  Reviewed-by: Reviewer Name &lt;reviewer@reviewer-email.server&gt;
>  </Pre>
> diff --git a/Commit-Signature-Format.md b/Commit-Signature-Format.md
> index 792c8cc..dab3464 100644
> --- a/Commit-Signature-Format.md
> +++ b/Commit-Signature-Format.md
> @@ -44,7 +44,6 @@ Several lines of
>  description for the
>  change.
>  
> -Contributed-under: TianoCore Contribution Agreement 1.1
>  Signed-off-by: Contributor Name <contributor@email.server>
>  Reviewed-by: Reviewer Name <reviewer@reviewer-email.server>
>  </pre>
> diff --git a/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers.md b/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers.md
> index 7101e11..445461b 100644
> --- a/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers.md
> +++ b/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers.md
> @@ -100,7 +100,6 @@ Contributor workflow
>       ```
>       [empty line]
>       [empty line]
> -     Contributed-under: TianoCore Contribution Agreement 1.1
>       Signed-off-by: Your Name <Your Email Address>
>       ```
>  
> @@ -286,7 +285,7 @@ Contributor workflow
>  
>       - an empty line
>  
> -     - One or more tags directly above the `Contributed-under` line
> +     - One or more tags directly above the `Signed-off-by` line
>         (which comes from the template) that CC the package maintainers
>         that are relevant for this specific patch. Consult the
>         `Maintainers.txt` file. For example, if you wrote a patch for
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo