From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 12 Apr 2019 16:20:06 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 43D9B307D840; Fri, 12 Apr 2019 23:20:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-65.rdu2.redhat.com [10.10.120.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2871160BFB; Fri, 12 Apr 2019 23:20:03 +0000 (UTC) Subject: Re: [edk2-devel] [Wiki Patch 1/2] Remove Contributed-under tags To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Andrew Fish , Leif Lindholm References: <20190412225040.17628-1-michael.d.kinney@intel.com> <20190412225040.17628-2-michael.d.kinney@intel.com> From: "Laszlo Ersek" Message-ID: <8996af42-44c8-3520-d12c-d8af6e4429a6@redhat.com> Date: Sat, 13 Apr 2019 01:20:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190412225040.17628-2-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 12 Apr 2019 23:20:05 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/13/19 00:50, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1656 > > With the change to BSD+Patent License, the TianoCore Contributor's > Agreement has been removed and as a result, a Contributed under > tag is no longer appropriate in commit messages. Remove this tag > from all commit message examples in the tianocore wiki. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > --- > Commit-Message-Format.md | 3 --- > Commit-Signature-Format.md | 1 - > ...-unkempt-git-guide-for-edk2-contributors-and-maintainers.md | 3 +-- > 3 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/Commit-Message-Format.md b/Commit-Message-Format.md > index ef60f75..97ea351 100644 > --- a/Commit-Message-Format.md > +++ b/Commit-Message-Format.md > @@ -11,7 +11,6 @@ Pkg-Module: Brief-single-line-summary > > Full-commit-message > > -Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Contributor Name <contributor@email.server> > > > @@ -39,7 +38,6 @@ Several lines of > description for the > change. > > -Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Contributor Name <contributor@email.server> > Reviewed-by: Reviewer Name <reviewer@reviewer-email.server> > > @@ -54,7 +52,6 @@ Several lines of > description for the > change. > > -Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Contributor Name <contributor@email.server> > Reviewed-by: Reviewer Name <reviewer@reviewer-email.server> > > diff --git a/Commit-Signature-Format.md b/Commit-Signature-Format.md > index 792c8cc..dab3464 100644 > --- a/Commit-Signature-Format.md > +++ b/Commit-Signature-Format.md > @@ -44,7 +44,6 @@ Several lines of > description for the > change. > > -Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Contributor Name > Reviewed-by: Reviewer Name > > diff --git a/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers.md b/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers.md > index 7101e11..445461b 100644 > --- a/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers.md > +++ b/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers.md > @@ -100,7 +100,6 @@ Contributor workflow > ``` > [empty line] > [empty line] > - Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Your Name > ``` > > @@ -286,7 +285,7 @@ Contributor workflow > > - an empty line > > - - One or more tags directly above the `Contributed-under` line > + - One or more tags directly above the `Signed-off-by` line > (which comes from the template) that CC the package maintainers > that are relevant for this specific patch. Consult the > `Maintainers.txt` file. For example, if you wrote a patch for > Reviewed-by: Laszlo Ersek Thanks Laszlo