Re: [edk2-devel] [PATCH v1 1/4] ShellPkg: Rename Address Size to Access size

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Joey,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 15/04/2021, 13:29, "devel@edk2.groups.io on behalf of Sami Mujawar via groups.io" <devel@edk2.groups.io on behalf of sami.mujawar=arm.com@groups.io> wrote:

    Adding Zhichao.

    Regards,

    Sami Mujawar

    On 15/04/2021, 13:19, "Joey Gouly" <joey.gouly@arm.com> wrote:

        This matches the ACPI spec 6.3, table 5.1: Generic Address Structure.

        Signed-off-by: Joey Gouly <joey.gouly@arm.com>
        ---
         ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 4 ++--
         1 file changed, 2 insertions(+), 2 deletions(-)

        diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
        index 01ac9a9bafeb2ca12c1ba19f406d626b108f5fe2..74056e72c359c732758563a9fe14ff2582f39f21 100644
        --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
        +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
        @@ -1,7 +1,7 @@
         /** @file
           ACPI parser

        -  Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.
        +  Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
           SPDX-License-Identifier: BSD-2-Clause-Patent
         **/

        @@ -628,7 +628,7 @@ STATIC CONST ACPI_PARSER GasParser[] = {
           {L"Address Space ID", 1, 0, L"0x%x", NULL, NULL, NULL, NULL},
           {L"Register Bit Width", 1, 1, L"0x%x", NULL, NULL, NULL, NULL},
           {L"Register Bit Offset", 1, 2, L"0x%x", NULL, NULL, NULL, NULL},
        -  {L"Address Size", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
        +  {L"Access Size", 1, 3, L"0x%x", NULL, NULL, NULL, NULL},
           {L"Address", 8, 4, L"0x%lx", NULL, NULL, NULL, NULL}
         };

        -- 
        Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")