From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mx.groups.io with SMTP id smtpd.web12.8284.1634213162505508376 for ; Thu, 14 Oct 2021 05:06:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=VSFpaEgt; spf=pass (domain: nuviainc.com, ip: 209.85.214.173, mailfrom: rebecca@nuviainc.com) Received: by mail-pl1-f173.google.com with SMTP id 21so4006403plo.13 for ; Thu, 14 Oct 2021 05:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1XNEnbPTcCLgX2OvSzTRRpG8O3E77shdbkzHkEuasBk=; b=VSFpaEgtdP7oNoqa6+HnS+zw3GxJhEP0hygRG26FhxyDJfwmnNHWwKQ2OD1N3tZo5f +WJcE5vWnonGocc60W/pnOZXYC32+/juX02kzktlrJ6fKvPu6iIzUcjon9HET3izivQR iX8Iq0p/HE5YVZnzrjp+T3qgCAu3WOQl8+bnkb+/Xp5H1xpIV0ws/zaOLwwEqR+bLSPC ttmezxq8hYDyIPw45FvQbMUbVUO6mw6zZpJfUxDXmeETCdovsvVUPqVBkmoP1qEJLgI1 GO9wTjdak1LLEr1Ufj4KMxBicIQVXKHM26D4ktWdOwcqhHen5mZtfiqObVAqT5Sev/Bj w02Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1XNEnbPTcCLgX2OvSzTRRpG8O3E77shdbkzHkEuasBk=; b=SBJbRxSEhCa28YxndmEyGr+M+lwEuP0A1rdtqsTc5KY3GI9jeVI9TdoVGrdy7KtjH+ G1+OgBH8UXo5foOviA8C6xToC5fIdVq3MGitPZ+5hfahkLqRTvWwYOkPL6AsFg2pe4Qy xlrYsnheaoxUV+gNw9mrTri5eLYOlPZ77sFJxcG6vcWcEwf6cNH+mfYhqLnJBryyK1S6 GoezKXHrsI35L4dsZ/dyfMAGjmE7588xpC8Db8G0FyKnyZFWDrG01so9lSnloILaqKUK GT7iLNaaMPFJcG188XD8AtXNQktSC0Id3W8IBR9Mj9SV48CMkRMAhj9ZSAj5CfAVNRaJ kpkg== X-Gm-Message-State: AOAM531gdUBftRfhK6U2YEPQHVG6zpnWEqQjmu68SdQPGZ3KErF60p8X vtCmql9arjj0QXNdjAo0oY32QQ== X-Google-Smtp-Source: ABdhPJxq/a3bXcEQchGAZrKElpr1x9bih/JJ5xiTc13UMa1fLVVpGFrdZ5zff5bWx4u7siPJqG20Tg== X-Received: by 2002:a17:902:da83:b0:13f:704:d731 with SMTP id j3-20020a170902da8300b0013f0704d731mr4503899plx.77.1634213162055; Thu, 14 Oct 2021 05:06:02 -0700 (PDT) Return-Path: Received: from linbox.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id k129sm2449558pgc.20.2021.10.14.05.06.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 05:06:01 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue To: devel@edk2.groups.io, huangming@linux.alibaba.com, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: ming.huang-@outlook.com References: <20211014072314.54891-1-huangming@linux.alibaba.com> From: "Rebecca Cran" Message-ID: <89a4aecb-12d5-ddc1-e5a5-0055e8e04aee@nuviainc.com> Date: Thu, 14 Oct 2021 06:05:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211014072314.54891-1-huangming@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Reviewed-by: Rebecca Cran On 10/14/21 1:23 AM, Ming Huang wrote: > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 > for 64K granularity. > > Signed-off-by: Ming Huang > --- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > index fb484086a4..4b409ff745 100644 > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > @@ -219,7 +219,7 @@ ConfigureCacheArchitectureInformation ( > CacheSize32 = CacheSize16; > } else if ((CacheSize64 / 64) < MAX_INT16) { > CacheSize16 = (1 << 15) | (CacheSize64 / 64); > - CacheSize32 = CacheSize16; > + CacheSize32 = (1 << 31) | (CacheSize64 / 64); > } else { > if ((CacheSize64 / 1024) <= 2047) { > CacheSize32 = CacheSize64;