From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web08.40560.1605556820328001722 for ; Mon, 16 Nov 2020 12:00:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=KXY//NYE; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AGJuL2U016493; Mon, 16 Nov 2020 15:00:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=F5S3WqqVQ+jwzcL1Ovilfom89MmDCNKvQVZLMR93a+I=; b=KXY//NYE1DIMOyXi/pSCzifLAvNPP88KqjUmq+qhNd0e9eK/6S4Be4uvoZxr2/grk5hC q37HXkTP+CmEW2N13QzfLDwGdedX70D6BOAaPtJ7MO2SX2YBYU9DELZkUN0cOjJi0PlI NCJzBmrB5AYlJk+rdGNuevD6TQ5yP79kRxmmtQcwNKstgwbW8yiX6ZvGq9lg8UDCO/z9 H2LuGKvFQse8GFYNIXCIqQeyMjVzLk3u4Xibt7yO1MTl2A4qmUgoVLrem4GHYkmYJyLy tYaB1UZDfceyOfvk/w5NQJFqiCbTzzwUBOiAZkPcUOVIwgl9eklwDCcMOmmtNbGnvLvK JA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 34v012024y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Nov 2020 15:00:18 -0500 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0AGJvKV2018553; Mon, 16 Nov 2020 15:00:17 -0500 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 34v0120247-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Nov 2020 15:00:17 -0500 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0AGJqJjs022622; Mon, 16 Nov 2020 20:00:16 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma04dal.us.ibm.com with ESMTP id 34t6v8wm1g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Nov 2020 20:00:16 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0AGK0D4t58524050 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Nov 2020 20:00:13 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 03F107807D; Mon, 16 Nov 2020 20:00:12 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D35687805C; Mon, 16 Nov 2020 20:00:09 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.85.179.241]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 16 Nov 2020 20:00:09 +0000 (GMT) Message-ID: <89b59ae13263e2888c4ac1206888d836efab44d2.camel@linux.ibm.com> Subject: Re: [edk2-devel] [PATCH 1/4] OvmfPkg/Amdsev: Base commit to build encrypted boot specific OVMF From: James Bottomley Reply-To: jejb@linux.ibm.com To: devel@edk2.groups.io, lersek@redhat.com Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" Date: Mon, 16 Nov 2020 12:00:08 -0800 In-Reply-To: References: <20201112001316.11341-1-jejb@linux.ibm.com> <20201112001316.11341-2-jejb@linux.ibm.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-16_09:2020-11-13,2020-11-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011160113 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2020-11-16 at 20:11 +0100, Laszlo Ersek wrote: > On 11/12/20 01:13, James Bottomley wrote: > > This commit represents the file copied from OvmfPkgX64 with minor > > changes to change the build name. > > > > This package will form the basis for adding Sev specific features. > > Since everything must go into a single rom file for attestation, > > the separated build of code and variables is eliminated. > > > > Signed-off-by: James Bottomley > > --- > > OvmfPkg/AmdSev/AmdSevX64.dsc | 1024 > > ++++++++++++++++++++++++++++++++++ > > OvmfPkg/AmdSev/AmdSevX64.fdf | 506 +++++++++++++++++ > > 2 files changed, 1530 insertions(+) > > create mode 100644 OvmfPkg/AmdSev/AmdSevX64.dsc > > create mode 100644 OvmfPkg/AmdSev/AmdSevX64.fdf > > > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc > > b/OvmfPkg/AmdSev/AmdSevX64.dsc > > new file mode 100644 > > index 0000000000..d1dfb8742f > > --- /dev/null > > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > > @@ -0,0 +1,1024 @@ > > +## @file > > +# EFI/Framework Open Virtual Machine Firmware (OVMF) platform for > > SEV > > (1) I suggest / request that we put "remote attestation" somewhere in > the above file-top comment. OK, will add > > +# > > +# Copyright (c) 2006 - 2020, Intel Corporation. All rights > > reserved.
> > +# (C) Copyright 2016 Hewlett Packard Enterprise Development > > LP
> > +# > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > +# > > +## > > (2) In every new file created in this series, please prepend an IBM > Copyright Notice, to the original (C) notices (if any). OK, I can add one. > > + > > +################################################################## > > ############## > > +# > > +# Defines Section - statements that will be processed to create a > > Makefile. > > +# > > +################################################################## > > ############## > > +[Defines] > > + PLATFORM_NAME = Ovmf > > + PLATFORM_GUID = 5a9e7754-d81b-49ea-85ad- > > 69eaa7b1539b > > (3) Please generate a new PLATFORM_GUID for this new platform with > "uuidgen". Sure ... I did do that the last time, I just forgot this time around. > > + PLATFORM_VERSION = 0.1 > > + DSC_SPECIFICATION = 0x00010005 > > + OUTPUT_DIRECTORY = Build/AmdSev > > + SUPPORTED_ARCHITECTURES = X64 > > + BUILD_TARGETS = NOOPT|DEBUG|RELEASE > > + SKUID_IDENTIFIER = DEFAULT > > + FLASH_DEFINITION = OvmfPkg/AmdSev/AmdSevX64.fdf > > + > > + # > > + # Defines for default states. These can be changed on the > > command line. > > + # -D FLAG=VALUE > > + # > > + DEFINE SECURE_BOOT_ENABLE = FALSE > > + DEFINE SMM_REQUIRE = FALSE > > (4) SEV-ES doesn't support (to my knowledge) SMM, so we should strip > everything dependent on SMM_REQUIRE being TRUE (DSC and FDF files > both). > > (5) Given that SMM cannot protect Secure Boot, SECURE_BOOT_ENABLE too > should be assumed FALSE, and stuff dependent on SECURE_BOOT_ENABLE > being > TRUE should be stripped. Yes, I believe neither of these is required. > > + DEFINE SOURCE_DEBUG_ENABLE = FALSE > > + DEFINE TPM_ENABLE = FALSE > > + DEFINE TPM_CONFIG_ENABLE = FALSE > > + > > + # > > + # Network definition > > + # > > + DEFINE NETWORK_TLS_ENABLE = FALSE > > + DEFINE NETWORK_IP6_ENABLE = FALSE > > + DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE > > + DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE > > (6) My understanding is that netboot with this platform is never > desired. If that's the case, then please remove: > - all the NETWORK_* flags, > - the dependent DSC/FDF snippets, > - the gEfiNetworkPkgTokenSpaceGuid.* PCD defaults, > - and (in particular) all !include directives that refer to > NetworkPkg/* I don't think we'll ever have a network dependency, no. > My goal with the above trimming is two-fold: > > - avoid an implication for platform builders that they can > meaningfully > tweak the -D flags for this platform, > > - cut down on the size of the new DSC/FDF files (given that the above > fruits seem to hang low). Will do. Regards, James