From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.70]) by mx.groups.io with SMTP id smtpd.web09.6033.1667395053242502418 for ; Wed, 02 Nov 2022 06:17:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Gy5ms/O/; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.70, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XydQb5jMOijNQ0joc5mlcR7ty1JQ8vOWfo4Nz/NYQix3ZbY+hYg1k/6mOisxARpSYm5tXNIbjr68GkkasvUfem1IJV9iyiqh6qvrMRxGWyUeJqGrkZzHq0qSo2BXyMu3tKHv6yhEZIsy/51RfojAbq5fx3npv3geS0z94D/JweEwXYtxCo2m4LVMbzKyz4FfVTlEF0iGdwLgxg73MMmUdVqLkz6oalz8U2v6FP5NmoeWgaqHD8TbZ0FnHfAGUoCEGzh2vkFC8hNqIEhXwOu6GWBYNPsutPMs1Zgicu4oQaOgruJd6sffYj7qsK4+HcfeSsUgnJFJB8JhkSshwrU4Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jKlA2HuGZIe7aIQE151z5j8djuRUmpbhlhkFKVwvTUA=; b=B0cOluEVl2UqDRl6Xx1iy5AQivlECkFbG9wRSSCtY4yiD1oFkfaMNJ1b6at4T33cnJopQO0CDcyQPw8sxpaijux1OHoc9qQomYrVDj3RIi0yCB0gZnUFWqVAvbXtmC8xv+XOHI9slqw76p8mlV0qfhodsFgRB/KPLLaO02v5ocT7DP7pXa3OWdXPLc6I3A80msxCvb7cRSzsEg/2/JpG/ujWU+y7vkTqdb1gBDlR96yfqvN9qzc0gh6Hs+zNl9TNBvVYaA1PnqTqytiCi6nHZ+zQSSqrRpgJzHJfsmu/wTajLjGbM6IaMXOu953iFhVJsAtfSxNdFpXtucln4lUoWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jKlA2HuGZIe7aIQE151z5j8djuRUmpbhlhkFKVwvTUA=; b=Gy5ms/O/Yj88g/5+QUu9Yh+nqdlCK01dZcoQ+zi1EBiODvYJekg2wl/1SU2uYwAdRhp7Z4dIDOur05paAhyIqN0MiUOq+20atRnZF+glxJHrHWYP0JrpqXWGcRL+jO1J5VQ9G4abXrlvrW5YA9bk1BFh7geEWR5V0vE/ht9AQ08= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by IA1PR12MB7760.namprd12.prod.outlook.com (2603:10b6:208:422::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Wed, 2 Nov 2022 13:17:30 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::4da8:e3eb:20eb:f00]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::4da8:e3eb:20eb:f00%2]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 13:17:30 +0000 Message-ID: <89c29922-7741-0191-bb9f-a9a1ba934531@amd.com> Date: Wed, 2 Nov 2022 08:17:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 3/8] UefiCpuPkg: Use CcExitLib instead of VmgExitLib To: Min Xu , devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Brijesh Singh , Erdem Aktas , Gerd Hoffmann , James Bottomley , Jiewen Yao References: <20221102051050.852-1-min.m.xu@intel.com> <20221102051050.852-4-min.m.xu@intel.com> From: "Lendacky, Thomas" In-Reply-To: <20221102051050.852-4-min.m.xu@intel.com> X-ClientProxiedBy: CH2PR12CA0015.namprd12.prod.outlook.com (2603:10b6:610:57::25) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|IA1PR12MB7760:EE_ X-MS-Office365-Filtering-Correlation-Id: 96f481c0-92a8-4003-b8a3-08dabcd49893 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AsYNUdaSq4lBn6g434avoatFIUnVd5aCv66W+j/Lx9GvA5RAWGlEEmBsTbwuZ2ss+ZL8YF46vCxaowvwwE4hqF9ntTZ9Hn+z+idx3+/wHNx05tvMbKM+2QguYZpHufsls7k32mycCBM7Th0MSo6wOp27ZKOcf4H7jD2uyqdWagMSP6ZlnrH0YX6dhjAgbuxVes3d6jINw8liD6cJjsGJuc5av/pKQUqVyZVdUhIfM8VPuKM/VDfhqNffQvle5vCIo6r9dlvwJOWaqWCbyFhbRh6YV7560nsM4mjrJjdzH5vJPMIlbyEFXF+I3C4nj7f7BSmvvE5tbuxRuoAOqNhASsRp6ztb4NKsazSfttXtxlQ6ri4w42l4FOhvFsI1a1hLDiyPlcuLtpJReAQr5vlexgdwGA9vtsPmRewWEKhZ17/2BGZSSJyUC9ataJkCc/3dtKjV8btXWWDYuwmWJ/jUX7cGN2p3oXOZM8PtWni5AqmW2MbK1UeRf/fE9fMM73/JNsdyH6Tu2E/dgsARr01F2wxwJxuFKTtplCOKFWv0umOgK8QnNkh7KDOifhYMjPGt/5VOJn7Om2fzPePF353ciFLAuR7hVwIP0QkKlmIxkljuKD9gv0M8rC4X5gLGykL/eyvQl8ZVh4GmJ3oYZFwZEP38HB6vaQXRMZLzT0oqb/viN2DOnkZ67Srb2CLjvYKMpABwXJRClZLU2m6qa2GVQd6MJrzz2iYZrG+x4bp6tPPtbksrTEv867HFAwl71Rv7ck4d0T9JVbA5bDs9PMJv5VNFQpnR+CHh4mxpHgZqte9pzajvvtufj7RtM3EVtSnhDH7NPXe+S6nCSaGORQnFug== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(451199015)(66946007)(41300700001)(66556008)(4326008)(6486002)(26005)(54906003)(966005)(19627235002)(6506007)(6512007)(8676002)(5660300002)(2906002)(316002)(66476007)(31696002)(2616005)(53546011)(186003)(478600001)(83380400001)(86362001)(31686004)(8936002)(38100700002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmJPeTh2bUdEQ2RISW5CTGs2ZURUMFFDYkNZKzJyWEsrQUJmaFk3eUw0V1pJ?= =?utf-8?B?Zzh2aVNRcGtYcEFNOS8rSnRHczhST04zNisxM202bmhFcGhRRVZhK3V2WEZ0?= =?utf-8?B?ekhUUi9NOXhDWC9oMkZFMFUrZWFIalZ4NTRWYWpta1dGaDA3ZHVXaVZndVJm?= =?utf-8?B?aWhFT3crUkdXc2EzOFVuMGRrQkExV1lJWlRPR1A3MWg0Qm5uYnFsTkdqTWhZ?= =?utf-8?B?c0FTTWJXeVkzQnlzY3o3dUQ4a0EyT0grWjNjdGlFa0phVU50Qmd6S0tBcDNn?= =?utf-8?B?NnlzK2VwNEpNRGI2Qjc4Yy9VYVU2OFRwWlJyVUV3UWRtN1QwNGJsdVdVVjhI?= =?utf-8?B?S2F2bGQvQ2NRc1JDdTB5cS9BQ0NPcGNvb2JBYnBRMHovRkFMRisvTkFYdWlk?= =?utf-8?B?OW1ScDVPNElyRG5LU1M4NHpIempSMWk1Tk9YRG5lT1AvbkZPMHl6NkEwc0JF?= =?utf-8?B?bDhqYzNWZTBXemtyQ1dwdk8ra29VOWszME96bjdVVnpvdk5iSm1mRUhKVUN5?= =?utf-8?B?UzMycFVrK1YyVVhJNmliK0kxTnR1Vk1manV4VjRPcFBNbytvV0R0VjhWVUFF?= =?utf-8?B?a2pmUWxDNU0xSE1ETjEwTzNzM3o4dmtndDkxOGdaNWNkcHlaNzlVY2FWZGc4?= =?utf-8?B?aUs3RmlwOXJlM2xlMXl0L2cwb2Nvb3ZNNCtXMUJjU3J5ODZycDZiM0VGYjMx?= =?utf-8?B?T1h2b2VUYm5zNmM1RmpxdUYzRVRadDZxaTg4dm1FODhXZCs5UXZqNnJjN25h?= =?utf-8?B?THdrNFJUc1dxWm9jekZ1Vm5GNHRqWTFsTUFRZEhBMHdoa2VQWUVVdm9sZGpz?= =?utf-8?B?bWs1Q1VYRE5ueFRtblVtNWRLZnFmQkE0NVZ2MWZ2aWZuS3JUazkvUVFMSkhk?= =?utf-8?B?MklHNTBZaVhHeGQxTHpFYXlCdzFoUTNPRzZmNlZFR3R5OStNd1VrYnVJdW9q?= =?utf-8?B?ejNSWmhxZ3gzRGdiVVhiU3NCTnUwRE1pRUVuMDdBUXRST0Z0THByZFVRNndI?= =?utf-8?B?U2ZzQ0tFOEY5K1J4Q3BMdjdtUTVkajJ4T3N6TDlRMXFGRmFYL2haZ0JoSThp?= =?utf-8?B?YzZzZ2kxZlFCMzd4dXRLQVRwY0x4REpTNW83d0o4MVd4Q1RKM3NLdXV3SUor?= =?utf-8?B?QzlyTEowc1RQOTJnS09iSVhPVVU0ZnhoWjZHYTQyTGV3Z3Q1VXhUZk5PaDJ1?= =?utf-8?B?cHVKTEZRbkdOODVKMHBMUm5KalluTWZnV2dZK0YrbXRBcWdOZlNVd3VWRXh2?= =?utf-8?B?VGFWTHB4Ri85VUZ4alg5UFZMTVVlRXRqSkVXTDAxY01JeHRKNWh4cERHVlFu?= =?utf-8?B?eU83QWpFTzVuTm1CVWwvc2hqWk9ITVdpTlhmUklQT3g0R1V1c0E5cEM4SnRi?= =?utf-8?B?Y2pGVDFWQmFEK3NaNyttOFd5b1JDZi95NlJkUmxwaGEyd1JxTDRqc1dPcHA3?= =?utf-8?B?a0x1SUZKQXorc1ZWYm9DVjMvak1DY3g0MHNXM0dTeTlncGpRcTFSVkFRWnM0?= =?utf-8?B?K2NHSVhaZExIZUJXekQ0Rjl0K3pJRjY0RGM0UTU3V25JU01ZeUJLbldEYzhP?= =?utf-8?B?RUNrQ2VBT2JLQTBxajBWWUYrM25zT0RXblRjVGJpNEdTZEVqN2ZjeHlSVUlj?= =?utf-8?B?WHdpYS9tS2xycGQ5LytEdVc3WlR0Sk5LWjc3bzF3djRSUWxQSnllcmxmbnNv?= =?utf-8?B?TENsL2FldHQ3WXprVjFORDdqQzgyVzduUWpUbEI0YnpUM0JwMkxEeS8wc1hG?= =?utf-8?B?NFlNbkY2ZTRMekV2MzBtdDZqNWNBVTUyQXFsWm5SUWxFWmQxNnN1U0cySVZv?= =?utf-8?B?Q0VUTVM3K25vc1RtcngxRWkwbzQzZGRNUkNROFcxZnB4V09zUlUxcXJoRVFK?= =?utf-8?B?THEyWXJ6MWNsbjN3TXZJRWlMWWJXYkM1QzVUck52T3Q3VFl4aEczQ1pLSW5S?= =?utf-8?B?elRnS2hlSWRldlNqbDl5WGducDlTcXlPd1ZWTFhhaDhSdmpEbWZxd1lhdmJW?= =?utf-8?B?OVZ1djhJL0x1bFFmTkJaVXl2V0dNQ01kZUZhb3Q4c3U1c1JEYVZOOUVyeXN1?= =?utf-8?B?M05Wd01tK2RxZHZleDVEai91WlBXcDBjWFVCQkh3SjVUQTY2VHM0cEtrQnRY?= =?utf-8?Q?QHFrFTigvBkNfynPjBPYlZP+p?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96f481c0-92a8-4003-b8a3-08dabcd49893 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 13:17:30.6659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9aYTQ4wFhfYf6HzhQBpEuMRLMlcf6rDHZ7HfvKKzTg/n0XZSFH/1uOpqDDgtSsALS3oKQcC5MoacEAbKDcw0bA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7760 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/2/22 00:10, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 > > VmgExitLib once was designed to provide interfaces to support #VC handler > and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is > introduced, this library is updated to support #VE as well. Now the name > of VmgExitLib cannot reflect what the lib does. So VmgExitLib is replaced > by CcExitLib. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Signed-off-by: Min Xu > --- > .../DxeCpuExceptionHandlerLib.inf | 2 +- > .../PeiCpuExceptionHandlerLib.inf | 2 +- > .../CpuExceptionHandlerLib/PeiDxeSmmCpuException.c | 6 +++--- > .../CpuExceptionHandlerLib/SecPeiCpuException.c | 6 +++--- > .../SecPeiCpuExceptionHandlerLib.inf | 2 +- > .../SmmCpuExceptionHandlerLib.inf | 2 +- > .../Xcode5SecPeiCpuExceptionHandlerLib.inf | 2 +- > UefiCpuPkg/Library/MpInitLib/AmdSev.c | 10 +++++----- > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 2 +- > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 8 ++++---- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 2 +- > UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c | 10 +++++----- > UefiCpuPkg/UefiCpuPkg.dsc | 2 ++ > 14 files changed, 30 insertions(+), 28 deletions(-) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index 0e1a99ddc09f..57c74ba844d2 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dsc > +++ b/UefiCpuPkg/UefiCpuPkg.dsc > @@ -60,6 +60,7 @@ > PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf Should you be deleting the VmgExitLibNull reference now? Or is this to handle issues with the edk2-platforms tree? If so, when will this be removed and VmgExitLibNull deleted? Thanks, Tom > + CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf > MicrocodeLib|UefiCpuPkg/Library/MicrocodeLib/MicrocodeLib.inf > SmmCpuRendezvousLib|UefiCpuPkg/Library/SmmCpuRendezvousLib/SmmCpuRendezvousLib.inf > CpuPageTableLib|UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableLib.inf > @@ -164,6 +165,7 @@ > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf > UefiCpuPkg/Library/SmmCpuFeaturesLib/StandaloneMmCpuFeaturesLib.inf > UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf > + UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf > UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.inf > UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.inf > UefiCpuPkg/SecCore/SecCore.inf