From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on060a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe48::60a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E36621A16EE1 for ; Tue, 16 May 2017 05:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JxTHIKKcF5OspHj+XpIrybjjPnjlgelptJu3P6c58rI=; b=PoyRIE3K6uof+AoK+zmN3lVV/PpZz901M1cAfGJ73A8RY28mx371kZvdA2HlmoZsmoAzMfVyqs1cIoVVJDpKbzXRiTlwABL2j5EtsNrlZQ1BYvE1bPrfqlkHShNfmFsRmzefN2ygtxtCvNcXciI6LWI/yCJh8gsBP9mb8JewcXk= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from Brijeshs-MacBook-Pro.local (70.112.153.56) by CY1PR12MB0149.namprd12.prod.outlook.com (10.161.173.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Tue, 16 May 2017 12:05:02 +0000 To: Jordan Justen , Laszlo Ersek , CC: , , Jiewen Yao References: <1494454162-9940-1-git-send-email-brijesh.singh@amd.com> <1494454162-9940-7-git-send-email-brijesh.singh@amd.com> <1ebdde6a-bad7-ed9a-b2af-7334477c8ae3@redhat.com> <149452462682.9607.8151737434916832513@jljusten-skl.jf.intel.com> <149487045771.31444.19976106484440238@jljusten-skl> From: Brijesh Singh Message-ID: <89da82c5-1e23-190b-0725-76f4da595987@amd.com> Date: Tue, 16 May 2017 07:04:58 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <149487045771.31444.19976106484440238@jljusten-skl> X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: DM5PR15CA0007.namprd15.prod.outlook.com (10.173.207.145) To CY1PR12MB0149.namprd12.prod.outlook.com (10.161.173.19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 457a210f-3458-46c2-d1ad-08d49c53c8e1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:CY1PR12MB0149; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0149; 3:wAGHOqQOc+bnrwyOndgALP2X3dvMeTdVLAuiVlY1sJo8/weydKNHXGTphmc5UhmgAdzivbm+z71S/ex2asvvQJyj8CaWKgplYkmHrKn9IabhuJbokrWLGrg2JUmg6Xx21XoFiatL1ZXpvV8dIf2Yz5DysAemx6zE7ZIXQ6PpdKgMvYgCwfOWAtFtUdrXa3gVG5XKnhUAh/jfyQ8EepJi7fcfCqKCXvYfUVFHrYDimpB2twpWI96nu/tYNzbjtMMgPOlk4b66P+6Yj6fzLeOgMveEb1LL8p5p2g7IhO7ZohoWq3saQ1pxr4ul94fgFIYmm2pttdg5iWMq+XGT9WDlB4XySAfB+o5oUfsB2aTrPf8=; 25:LtnCdPrE9BS+1haE95yID1HGpqzrPa5148lEwKx7mlPNHF+syA1dvyqGR0Ebl9Un2ObdxvKZALpScg7OEZQg5WIvm0LRgR0nH+w+C5QZLwR0EycgasPeiXbOAcEmgVLD3ujTCVVKqZuqxiE8t4mp1j2uQkmpWGQOg6OTLgE1Jg6CR3t/d7P8KJ8iWBzPli9ci1ezivCfZBigpwieQs+hqLOZvi9KmIi0MWbztuM5a0ha/JDORSOcy2+7hAxGYNZFSR2aiPa8ATvr9zJFdsB9y5nRpvM35qlzq+QqkRzOJ5qEaWxDc47VSdyEomY8AanV771z3yCwGC1ZEQEDDK5150lDdV8O+rRhNzVKGoMwlTZp3u5us8y1Cnf01qKxdmOGRkVvQ1W+HiUIZ923PossaIuYmwEqM7OqisPsARZIXP6mN1wgERQKpV8tdfQnAiC+NuR8sBAp5BGDWaFo7TqRnui2sy2aT25Z4lOqVEzatn8= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0149; 31:XhvzRFsRZPlZAAmC6vXidPX15iYz9yuGAnmxCddklHVDKGPyLP+FyFuIKZmWCTTXqPvMgkP3yeBtzNNRPV/VRAABDObCwEYnuFJBQWH9HwgIgVGe7DU61fBY0QHcit5JVmzuYsTV4vsQSc14YAUYCPwUPZtMl92XyN9EakVBmOp/UCE4++2fCE1XPuN0MA/Pek4YprRWzmgaL1F3cDHCEk6nEC0bc0HfAzSvgk6ENSA=; 20:MUABkw3Rav4+zpIUF4NXdwa1nF6NYWQZ6nqyHgoAhDU0O5rtaN64SRGoBnvMASQ049/w1Fu9Dyz0ZRxBIKhrY0kXqIlWdJrv66YhZV+z3v9XynMeImz2udvdFkGb9dBQcl/aUFYd0yKmXjnkbG3SlaF0FUFSlW78pVTftdUA98u05z4EelwoHvKtVjcL4GzvdNJEPGbQjPOT5hDrMEdrAG8VCeJ26gahOLORxX80ZNprfmKD/Fc6uUKgXJrJahdBeblSta9e/rD+CtFjO5U6/pgkQXYANgEqhpNaZ0wq5uXdgN3hAY9i5pE1GVxxuge3cTcXp6IfM5DHN4XFbKrQN6ziCfUiDhhj3O1QemhYV8IbmwQN3DQJFwMvhefHxtkIqJrXBWG5h5n8VuXRqefAmxHTlmjkTYsbIz8uwU9Z0m9L6isU00MhI7P/DpB4bVcj22RVrbZwjxIG1P03GiJdM1vATPgRSKDJxawgOrr+PUb2UuMUngIyBd48Owmup9pd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148); SRVR:CY1PR12MB0149; BCL:0; PCL:0; RULEID:; SRVR:CY1PR12MB0149; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0149; 4:H3pKwPTqBnI/MmupDUwsRhDS5TxtpMQDClM7y0cgpebuJ7sVIiMvvI2NCSw2gY+AvzkIc58yqTuTwaBUXWVIuqLyagZq0X70Hs8/sK4u8g7YBvNvBCPo27nZUKygTGNPClUDiNplubwetjMRWIOPmpIUlDZhtcJNvjIQGlTUWC9k/VAUl5sPoK/9kJyKzX2NBSRRHCyE7qV7y65ZDsAKwIIZnVdqHq1N3/vF6d11IYS+0eBeT+JW/yUsiqKiPjpF3jrqGUbZnSdY7ZphK9enkgoej58rUO6FyC5x6cJhVkL+RDjDqVBzNZRDKoeQkb2xGjgv7pWA9YAUEq1HNuMERynb+IE4FrJkwxghYinCy0ZI2t40dQXCasPxrniGe+QhYPcpeSlOHKtE/1FepuLjj5qn6H+1F4qVmaB4l3jvwA+5UgHM1Zz5eGc0YBpMqdTSDqRwaBejL1HXZIN0yNfCKwL+pXonftGx/1hpsEQ0dPhTi7EP6jBPalicX/YWw0oF3fLiQYmZYCQaVXbwg/Csk4s0PHS29ATWN50EL/RDnIXdPJou0qpEY7gCiS8Zxu/fnNAjgyRj6vifW2de4Zx8y8Z7COvBLSqu4L+U35WgHbIYduiiG2RR1h5m/tUsaSDRh7zvzkEfYbNJzZZub+STnIbOPEHF+1rjVurQ4c7nNhRDAdHAFiRFAk+hGAB38igjJsUPswqYugiCbpXp4lC8Gzo2ZrXDediqn1/UCjDQLqdDUCIfHDbwrC/TxDQEPDOv+RAJQNkT7zZVHBLOltW7Ipzno3T/MK67jDrtrQgvxyE= X-Forefront-PRVS: 03094A4065 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39450400003)(39410400002)(39400400002)(39850400002)(39860400002)(24454002)(377424004)(377454003)(47776003)(2906002)(81166006)(6506006)(23676002)(305945005)(66066001)(7736002)(31686004)(42186005)(8676002)(189998001)(83506001)(478600001)(54906002)(6246003)(4001350100001)(38730400002)(6512007)(53936002)(4326008)(93886004)(3846002)(229853002)(2950100002)(6116002)(6666003)(33646002)(31696002)(76176999)(54356999)(5660300001)(36756003)(230700001)(50986999)(25786009)(53546009)(50466002)(6486002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0149; H:Brijeshs-MacBook-Pro.local; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTQ5OzIzOlczNHM2bUQ5TDJ1U1V4SEw5cUh4aHhuSjl2?= =?utf-8?B?d3hJQzZ3UkQzUEZoaWxWQWFOTlBkM0cvaHNFQlhLTVc2VTI1Q0dUODVBbmJW?= =?utf-8?B?UW5xOURBb0pzdDErU1lBSVFnMklnL1IxOEpuVHNaRlYwa2kyZmYxMGpITDMy?= =?utf-8?B?M1dvU2UvWDFVMkdXNEdKbGt4NnlPNUF6Nm5Lb0tyaE13Zy92WDMyN2NnNHVx?= =?utf-8?B?Q0ZQRGdZMW1GMC9mRi9zSEk1Rmtva1VQdng0cFJNSjc3NXR6UEltNllQU1Vk?= =?utf-8?B?aDNXRGNRcVoxVitBckpFbnNxYWNzaElBWDU4ejNnbVF4TDN5RFlEd2R6ekQx?= =?utf-8?B?RkpiY25waUt5RjFvaXlMOUc0QU1WYjhPYVhtSTJieFZTb0tyMFIxbCtBeE12?= =?utf-8?B?NSttSVB0QkhwaDB1ZGpzK1RQMStrc2g5aHJ5VGZZam1tYlZyUXdxbzZtbW1P?= =?utf-8?B?OWQzZ2FaMXoyMVJpcWc2MzV5bzZpc0xvWUYwRHNCS2ViT1VISWcrRjd2QUpi?= =?utf-8?B?QlRwczdmVnBxaFUvUlczdDVGYkZIUUZFUEdjRXlQeEpIdjcxdXhrV2N0OEdu?= =?utf-8?B?aW9SNnJrWG9rbW5nMUI3ZEJ5WXpMN2xidDdsWnpsWXkwa2Jnb3Iwcm1FZ3Ay?= =?utf-8?B?WDBBVVhLbnNnZ254dW40VExSVkp6L0Y2YmRnaEZCSEtFelpBdk1nbllSZk1O?= =?utf-8?B?MUZZZjVIYkxlMTkvVTBnWVdPLzlSRWJ3SHZsd2tGT2V5Q0NWYTVMR0ZYUE5F?= =?utf-8?B?UjNiVlRKMnJCQ2U4Y2lMbkx6SWdGdll6M2lnV1cwZ0xiZHNSc0xnai84WWVF?= =?utf-8?B?Y2gvcGh4a01VaXZEREt6eHBxaG1hWFlLcDdtUUJvdWlLcXduKy9kZUE2SmNX?= =?utf-8?B?NHQ1RXBrUFMwNS9Bamx5eFhFSnlqTkJ5czZoaUNoaXVGT2pvaHVGak4rbmZq?= =?utf-8?B?OHY2WTAweG5OUFArUUNyVXprQStZMUxBTisyYWRRWGEyMTVQdGpuQXd5QjBM?= =?utf-8?B?VG5neklTYW5JSzQ4b2lXOWY1WGdZcHExUkFzWUR4WGcxYVEwV2hRQlgwL3RT?= =?utf-8?B?TkxLYjBjRVpBOGRqOG9rcFJTWUZyamEwKzlrNVJuNDR4U0p2NUJ4RTQrYm9Y?= =?utf-8?B?MGdsazI4bkMrUSs4TG4xalh4eGZFU2JBQTNZaldzOCtENE5hc2JtRHYzbUly?= =?utf-8?B?YTdQUGcwT3R1V3pXb0t6am8vejA1ZlBkZlZFUURYZzAzeTA3dHBBMCtPeHNo?= =?utf-8?B?WGVOQ2lZdWZONHJ1MEMzM0pqVi9GaGphWEtkL3R4YmVDNlVTWkl5cXE3VFZB?= =?utf-8?B?YWIxdFpmeHlMSlNVM1J0dDB3eVNFZjREclU3SW9zTGhpR1huY3lHTE5zL29Y?= =?utf-8?B?YXgyUCtDRWxQaDkxWS9jNDRqaVM5bzk1anF4MFdUc0R3MlVJOUR4SHJJQjha?= =?utf-8?B?V05XOUNyK2V2UG5pTHZKd2k2Z09jbzRQRUhtU0hWK0ZlWlpZZ0tZRDkyNElS?= =?utf-8?B?ZDAwYWFNc3Z0YUR1cjRuVzYxSEFMZThYUU5Bc3pNZmE2RGtuMnphbU1lMHpz?= =?utf-8?B?TWcvWDNaYTZtQzVlY1pKUzV5dm5KajJnUTM5MHA2eHVsRmdtNlQ1QXhFOHM3?= =?utf-8?B?RGZLU0U4ek5NZTRxRVJYRjlmWmNsQzJvSEFPT09zRTNYbmNtWldJRXRERkRv?= =?utf-8?Q?Lx9XDrAgJLEUIyM6kg=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0149; 6:9uI95TYlkcR7O6wqoppUTRNhFckYaOAwpC0trgo6gnXSsfMvBEv9q1xQE8EbwsaAlkQd4CBkiJ6zaTckpanELKbMgo61GWqQ3z4xbd6+pbVCBb4KWLS88OUNyBpJbFQMadVty1PX6kWO4+8YQlhG8b6ULpHNeFdk8JI8iWKidgnBw+Od8nHG1vDLJRlWo38W696u62aFlf96rzrHE5A8W/0hOX2oTDkeq2mBubJee6g5vsCE2ICb4hOkl2cDXuD/qx0ylRYcu9SKrzwJLZ5e9P45Td5SyOnRxIL52lWABZYXLJuvRNlg1GCDqgP+fkiIe05y2wLK6CVN2pxeFpcN3O8FEjUsGjL8HyTos+NsBGIa9/8pyDmQVuuMZXElBDbUwVDH9NupOl8+tU5rqNilBkD1f5wqs+FI1u1N1EGJjOw1WCZ4cFJTo98qmwYdS7XM3nYJwqXheFfhvEOl4I9jFaRi10A5CK/cGw5oY7yVPaNxvolA6jj2n2ZDnu/z+AHZs7LaPtmdC765WEHDLkeB7wkqDOGPavDUSxOG48Jj5Ec=; 5:AJfCbiVWNEiWkgoddR57gEKGd5Leo18wHQLO+EjF3IuI3KLKVzQaOydp+OnYcK9lNgm2IHwKfja7lSj75ZttGT9QjRdEXgOsI6SE8tvujT3lb32OM6qMVQHOR2LzyOShEKRjtKzfdzWuqYlFrG0Jmg==; 24:Ahhv6G8wzHxtfjYBu20CCwKdJ15RzOfi+Bv1OEcAAcfDlSClkCkORpB6fIi+2vLt20ofEFuGW/Qnqi+1dKd2zE9kFd6DJ1QDOoaeAkL734M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0149; 7:maHgl2IB7EBZWKlPgOGBtOog0Y2uFhhswawJQvvospEOUQ14q+M7VGV5fpR2qtFDT0uiHLUZIh7R2b85tF4gR/EDnksaxOsswJgYA7Hh1TjlnAoLZNve2GkKO6jI3S/aj6QGxKXCIsXvUEaCRTwmbG+0kj6NeklNA1iR7ZduQybY9lOtlq9z2PqeJwQwMr7VLRfXujxKqbEKz0dESC7IA3uq5cKS/pbX0rAicfjkiQm0Q9zc/nn+i+Vq14m3CfuJlgl6KWfpKGHviFbGyoogIOzNdyAJ52RvfqhpkvH7p2Mr1pjABcAZWTCXxZWYT1AUMDRMCk4Ya6l7UzJdjSu9IQ==; 20:1gPL19sEdpWYVVvYX4qZL4HezPNIIBokemnPwPbx40DkJ4+66ZYcLS4JdvN/bhtQG85LiNM6+rUEq8BshdUlzIkbjI7dl+GiMYQBPZ+TOKYJRcjSk8M/wNNHzmG4VvWYxbe7jhdCZPt7lh6Xp1OHBttL/7wogE/WTBxRS6uYNMZsyrY4E+KM/OMMd9VU3r/bGbW4jmM5qwIsAiqe5pAlQxjzrRdHiWtKEFK2WINi/Xat5sW7wkzKrJjLUjA5rtJL X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2017 12:05:02.8030 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0149 Subject: Re: [RFC v4 06/13] OvmfPkg:AmdSevDxe: add AmdSevDxe driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2017 12:05:04 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US Hi Jordan, On 5/15/17 12:47 PM, Jordan Justen wrote: > On 2017-05-11 11:01:57, Brijesh Singh wrote: >> >> We basically need some kind of guarantee that this driver is run before any other >> drivers or libs access MMIO register/buffers. In additional to clearing encryption >> bit from MMIO spaces, the driver also installs IOMMU protocol. So far, IOMMU protocol >> is directly consumed by PciHostBridgeDxe driver and QemuFwCfgDxeLib. > What about adding a NULL protocol named > gOvmfIoMmuDetectionProtocolGuid? (Better name suggestions welcomed. :) > Then we can use this protocol in a depex where needed. It should be doable, If I find better name then I will use that :) > Maybe we should consider naming the driver IoMmuDxe instead? > > I think the generic PciRoot bridge driver shouldn't need this in the > depex because it will not start until the BDS phase, and the IoMmuDxe > driver would have been dispatched by then. Are you suggesting that we introduce a new IoMmuDxe driver and install IOMMU protocol unconditionally ? I was hoping that we install IOMMU protocol only when SEV is enabled. A non-SEV guest will still use the old approach. I was minimizing changes into non-SEV code flow. Please note that since AmdSevDxe driver does *two* things; a) clear C-bit from MMIO b) installs IOMMU protocol hence I will not able to remove AmdSevDxe completely. But I can remove IOMMU protocol installation part from AmdSevDxe and move it into new IoMmuDxe driver. Please let me know if this is what you are asking. thanks -Brijesh