Re: [patch 4/5] MdePkg: Add PciRoot/PcieRoot text for ACPI Expanded Device Path

["Ni, Ruiyu" <ruiyu.ni@Intel.com>]

On 10/8/2018 11:31 AM, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1228
> 
> According to UEFI spec,for ACPI Expanded Device Path
> when HID=PNP0A03 or CID=PNP0A03 and HID != PNP0A08,
> the device path node can be displayed as: PciRoot(UID|UIDSTR)
> When HID=PNP0A08 or CID=PNP0A08, the device path node can be
> displayed as: PcieRoot(UID|UIDSTR). But current code miss the
> code logic.
> 
> This commit is to do the enhancement.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>   .../UefiDevicePathLib/DevicePathToText.c      | 21 +++++++++++++++++++
>   1 file changed, 21 insertions(+)
> 
> diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> index 8e5efba1e8..7ad9eadf6c 100644
> --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> @@ -431,10 +431,31 @@ DevPathToTextAcpiEx (
>     AcpiEx = DevPath;
>     HIDStr = (CHAR8 *) (((UINT8 *) AcpiEx) + sizeof (ACPI_EXTENDED_HID_DEVICE_PATH));
>     UIDStr = HIDStr + AsciiStrLen (HIDStr) + 1;
>     CIDStr = UIDStr + AsciiStrLen (UIDStr) + 1;
>   
> +  if (DisplayOnly) {
> +    if ((EISA_ID_TO_NUM (AcpiEx->HID) == 0x0A03) ||
> +        (EISA_ID_TO_NUM (AcpiEx->CID) == 0x0A03 && EISA_ID_TO_NUM (AcpiEx->HID) != 0x0A08)) {
> +      if (AcpiEx->UID == 0) {
> +        UefiDevicePathLibCatPrint (Str, L"PciRoot(%a)", UIDStr);
> +      } else {
> +        UefiDevicePathLibCatPrint (Str, L"PciRoot(0x%x)", AcpiEx->UID);
> +      }
> +      return;
> +    }
> +
> +    if (EISA_ID_TO_NUM (AcpiEx->HID) == 0x0A08 || EISA_ID_TO_NUM (AcpiEx->CID) == 0x0A08) {
> +      if (AcpiEx->UID == 0) {
> +        UefiDevicePathLibCatPrint (Str, L"PcieRoot(%a)", UIDStr);
> +      } else {
> +        UefiDevicePathLibCatPrint (Str, L"PcieRoot(0x%x)", AcpiEx->UID);
> +      }
> +      return;
> +    }
> +  }
> +
>     //
>     // Converts EISA identification to string.
>     //
>     UnicodeSPrint (
>       HIDText,
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray