From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io, ardb+tianocore@kernel.org,
quic_llindhol@quicinc.com, neil.jones@blaize.com,
pedro.falcato@gmail.com, pierre.gondois@arm.com,
Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com,
Ben.Adderson@arm.com, Sibel.Allinson@arm.com, nd@arm.com
Subject: Re: [PATCH v1 04/12] ArmPkg: Fix Non-Boolean comparison in ArmGicEnableDistributor
Date: Tue, 23 May 2023 16:16:27 +0100 [thread overview]
Message-ID: <89e0b6eb-539b-0c0d-8e85-2b203851d07b@arm.com> (raw)
In-Reply-To: <CAMj1kXHw6pB3pG7WzqJCWVC33kdprGYJ9b70yiusOqRGaw-ADg@mail.gmail.com>
Hi Ard,
Thank you for the feedback.
I will fix this in the v2 series.
Regards,
Sami Mujawar
On 23/05/2023 02:32 pm, Ard Biesheuvel wrote:
> On Tue, 23 May 2023 at 15:04, Sami Mujawar <sami.mujawar@arm.com> wrote:
>> According to edk2 coding standard specification, Non-Boolean
>> comparisons must use a compare operator (==, !=, >, < >=, <=).
>> See Section 5.7.2.1 at https://edk2-docs.gitbook.io/
>> edk-ii-c-coding-standards-specification/5_source_files/
>> 57_c_programming
>>
>> Therefore, fix the comparison in ArmGicEnableDistributor()
>>
>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>> ---
>> ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c b/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c
>> index c17cbe041e8a9ceb8c8c3a6b953ff88b75f6f206..1ca66a40940434d6d89e243650f3e81aa3f588b5 100644
>> --- a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c
>> +++ b/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c
>> @@ -26,7 +26,10 @@ ArmGicEnableDistributor (
>> if (Revision == ARM_GIC_ARCH_REVISION_2) {
>> MmioWrite32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1);
>> } else {
>> - if (MmioRead32 (GicDistributorBase + ARM_GIC_ICDDCR) & ARM_GIC_ICDDCR_ARE) {
>> + if ((MmioRead32 (
>> + GicDistributorBase + ARM_GIC_ICDDCR
>> + ) & ARM_GIC_ICDDCR_ARE) != 0)
>> + {
> This coding style is terrible. Mind using a temporary variable for the
> result of the MmioRead32() instead?
>
>> MmioOr32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x2);
>> } else {
>> MmioOr32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1);
>> --
>> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>>
next prev parent reply other threads:[~2023-05-23 15:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 13:04 [PATCH v1 00/12] ArmPkg: Arm GIC Library and Driver improvements Sami Mujawar
2023-05-23 13:04 ` [PATCH v1 01/12] ArmPkg: Fix data type used for GicDistributorBase Sami Mujawar
2023-05-23 13:29 ` Ard Biesheuvel
2023-05-23 13:04 ` [PATCH v1 02/12] ArmPkg: Fix data type used for GicInterruptInterfaceBase Sami Mujawar
2023-05-23 13:35 ` Pedro Falcato
2023-05-23 15:16 ` Sami Mujawar
2023-05-23 13:36 ` Ard Biesheuvel
2023-05-23 13:04 ` [PATCH v1 03/12] ArmPkg: Fix ArmGicSendSgiTo() parameters Sami Mujawar
2023-05-23 13:04 ` [PATCH v1 04/12] ArmPkg: Fix Non-Boolean comparison in ArmGicEnableDistributor Sami Mujawar
2023-05-23 13:32 ` Ard Biesheuvel
2023-05-23 15:16 ` Sami Mujawar [this message]
2023-05-23 13:04 ` [PATCH v1 05/12] ArmPkg: Fix return type for ArmGicGetInterfaceIdentification Sami Mujawar
2023-05-23 13:04 ` [PATCH v1 06/12] ArmPkg: Make variables used for GicInterrupt UINTN Sami Mujawar
2023-05-23 13:04 ` [PATCH v1 07/12] ArmPkg: Fix return value for ArmGicV2AcknowledgeInterrupt Sami Mujawar
2023-05-23 13:32 ` Pedro Falcato
2023-05-23 15:17 ` Sami Mujawar
2023-05-23 13:04 ` [PATCH v1 08/12] ArmPkg: Typecast IntID to UINT32 in ArmGicV2EndOfInterrupt Sami Mujawar
2023-05-23 13:26 ` [edk2-devel] " Ard Biesheuvel
2023-05-23 15:16 ` Sami Mujawar
2023-05-23 13:04 ` [PATCH v1 09/12] ArmPkg: Remove unused function declarations Sami Mujawar
2023-05-23 13:04 ` [PATCH v1 10/12] ArmPkg: Prevent SgiId from setting RES0 bits of GICD_SGIR Sami Mujawar
2023-05-23 13:37 ` Ard Biesheuvel
2023-05-23 13:04 ` [PATCH v1 11/12] ArmPkg: Adjust variable type and cast for RegShift & RegOffset Sami Mujawar
2023-05-23 13:04 ` [PATCH v1 12/12] ArmPkg: Fix ArmGicAcknowledgeInterrupt () for GICv3 Sami Mujawar
2023-05-23 13:38 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89e0b6eb-539b-0c0d-8e85-2b203851d07b@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox