From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.58]) by mx.groups.io with SMTP id smtpd.web11.848.1684855001617776995 for ; Tue, 23 May 2023 08:16:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Hh20FVzP; spf=pass (domain: arm.com, ip: 40.107.6.58, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1zmsT0k4ZzOdx7HIOUJa0o/hDG0U5uZY9hltKMYPXQ4=; b=Hh20FVzPDVIiqXObe1+A4sZfHZL5qxQlQhx/kvRCX6mBrz4d+k0Ce9dSfqbhRprSyJVfCHIVHvRi5YjrDYfJA56KQFI5/s18f7hmA6fXKRY0KLoMGDPZ0p+qACXmStN+JZ2aAqOIIwarNny8yOS6DonRxlRfdeze18ANxXBJw3w= Received: from AM6P192CA0071.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::48) by DB9PR08MB7771.eurprd08.prod.outlook.com (2603:10a6:10:397::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 15:16:38 +0000 Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::80) by AM6P192CA0071.outlook.office365.com (2603:10a6:209:82::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 15:16:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.14 via Frontend Transport; Tue, 23 May 2023 15:16:38 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Tue, 23 May 2023 15:16:37 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6248eb5be2df62f5 X-CR-MTA-TID: 64aa7808 Received: from 0b35d51d7377.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A284092B-93CA-4C72-9459-99C03D6746AD.1; Tue, 23 May 2023 15:16:30 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0b35d51d7377.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 23 May 2023 15:16:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=frIIR4J/drBhXzSPPvabOCzgQoofjzrpgtwRFLvpZnpw+ZfwT9ElmWK9vTXMR6S3pwnYKbEsBMpgC2rL7UA3MEe00Md7hB2bzebYMuQgzwiR7I0j5PC8b4moyD+CUW++c0Qr1HiLSrSD9ri5TcgU3jYq2f/br2i2pIifm7v6V54Mcqm1vp5In08FfV5RHCK/Ab8hlgs8A4jKyj/sWq7Pn1OUMlSW/uJJ92yp39yZYMV29aKl5PWg+TwgDFuOwCuPJF1SOSb2cmGaikp4e7SFlGL99zjteSU9hg4JUmRtKstGJBVs/36qDAiKXj8jZrXZLJlc4jV24hSDD4xC0ErdlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1zmsT0k4ZzOdx7HIOUJa0o/hDG0U5uZY9hltKMYPXQ4=; b=J+pGbT035YAX9MbhSh5XisWvOq/gG5z92vH0KJ69gF8n48ORg6KrKMIGbq+qNXWV5wXQy9hSlxrjZAZ+fb7HjJ0jWspmri7b3t4zOtGqVKI9IiKOjjcEK08OuzSy30CIIuBvRPwfSBvuMFoTWGUCax0gQwusCdDybLoa8VkNy/7bBFV7Hyyp6uwCjJWSPzIgcAjpxGDbMaKKQNmJQ0Jnx0pqwjhoKNkqb8oJ7JVcqQrq7u09i3x0XzLdFxjCyLyuqaM7VEo0/vKGhUvvtp1e8+4VfcokmATkntJQkBJqFV8qKjP8mnH+v0AWmes0tXlfvcrelDe0sEJFaDtY3Z7IQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1zmsT0k4ZzOdx7HIOUJa0o/hDG0U5uZY9hltKMYPXQ4=; b=Hh20FVzPDVIiqXObe1+A4sZfHZL5qxQlQhx/kvRCX6mBrz4d+k0Ce9dSfqbhRprSyJVfCHIVHvRi5YjrDYfJA56KQFI5/s18f7hmA6fXKRY0KLoMGDPZ0p+qACXmStN+JZ2aAqOIIwarNny8yOS6DonRxlRfdeze18ANxXBJw3w= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB3PR08MB8985.eurprd08.prod.outlook.com (2603:10a6:10:43f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 15:16:28 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c%6]) with mapi id 15.20.6411.029; Tue, 23 May 2023 15:16:28 +0000 Message-ID: <89e0b6eb-539b-0c0d-8e85-2b203851d07b@arm.com> Date: Tue, 23 May 2023 16:16:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 04/12] ArmPkg: Fix Non-Boolean comparison in ArmGicEnableDistributor To: Ard Biesheuvel Cc: devel@edk2.groups.io, ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, neil.jones@blaize.com, pedro.falcato@gmail.com, pierre.gondois@arm.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, Sibel.Allinson@arm.com, nd@arm.com References: <20230523130421.10804-1-sami.mujawar@arm.com> <20230523130421.10804-5-sami.mujawar@arm.com> From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO4P265CA0125.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::11) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DB3PR08MB8985:EE_|AM7EUR03FT059:EE_|DB9PR08MB7771:EE_ X-MS-Office365-Filtering-Correlation-Id: 70ce4a1c-ad01-40ea-2074-08db5ba0b455 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4ttZIl8hoqRX1DY7mIaWbskSezz1Qr6EoAMvdojXEuSKECcnpZhzG4RBU2H8vtx5UAxxUtQpu+EIaIc/RSWKpsOCyvBdf54lh4x1N4w3+Cn1VeuSgCzlupdVk6sTqh8jxoJk5XuXbxl53z4d3ZWciXK2iarrJiJG/nqIHwQ3uEdOR9wBu6rO5grbnRVEfu6TSQOQSrOnDBEfwB2NTatNA2/Vc4jFfPmqKZYCB7V2OewWx0IhUfgg3x5Pu708xzcl2JRva1U5R5VfZ5vUAFrbiUcr6F9HyYROQ2hboqfJ0gGkXdkRPPXYS9UahyLRMzHWliQE8pijAeEUQsQwOzVISPsRTGGm6FsbHbJsAD3XBr60GXnu9neliWQLyaFrvJ4oeY85ZwutdFExoMIM7PX2ozGN0GEjCmOX7HZPmjcNIeW6rP93XZGP5oy2t8nfN8RxCXGvfTuhKZjyGFsRu5O5q4lERBxX3DPIYhavI5ygRDEFiuSpKP3xbe4J2eK6Tn9luyEOxspQGxJjmbThg9JsTeLuXtoZUGPj15M3FEvvPo/HuiSjBckT/ae6mYH7VcxZ5tbCn4DxVpnYN0Zwpj3K4CNP4IkC4G6xTEaJzn3J1ZYmb7skGZq1YCLom/197CH7hm4dtHqaH7o5uGBhbzfGvA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39850400004)(136003)(366004)(346002)(376002)(451199021)(41300700001)(6486002)(31686004)(478600001)(31696002)(966005)(316002)(4326008)(6916009)(66946007)(66556008)(66476007)(86362001)(5660300002)(8936002)(8676002)(38100700002)(44832011)(2906002)(26005)(6512007)(6506007)(186003)(53546011)(83380400001)(2616005)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8985 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 85cea272-3a0c-474d-b9ab-08db5ba0ae8b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3m6gpg/vsqrhol9y8rnUC3sQes8keQ8axaZDCRxkRlgRGUGU3I0mMFSqPztNALCRaYYNV+hVLGaO+YRRjKHUwjt/bo3q/wZIYPfqSd255DZCTXKD+E77qDGXLYwmRXkzIjGO6umJ2YiqSsrOT4klZ92mv973acRUpn6NEjDc0nZLfq7xmgbkuQFGfbL9LMyqbZhQu4pVutyz2hLYI8ERc/p5Uzgylq9JbT1m7Gox5UoJqB5TWM04cN/+TqsGqOIT+OMH0VAwyO+f+S2zMSiQ2XYfn7289jNtl8OSD7XB1j5MCLpEiqJZ7KCr6au8z7uMzoX80OMNgWKu2iKRyJ423b3UEcnG1Qi0IJkhBAgT66zFH+FtPhODgQgn1ywSUbO7QMIVMUlxnj6Mk+ehgMFXACBK4ybyxmb1MnQPhhtuxYN39OUrr3L1CuxQx+y3dtzuApU76P/LEgpOiMv2QAbtPDhFlzoVbjWeEcq0kKgB3IWUcwgwuSFwApe60Ckt+Amp+R5Q0RHAl7XP/43btqP284VfqMHMDkTKa1EJ1CwrC0M0d0if3Ui1OMjHdG2pBN6C1YCEVPhzuiNskx5VnIqPt6tmjFucxAGXh+bQcsezhyp/aosC6QrzJIo4+fq9YuKLh8+Jmdcks7/ungwTKwBKxdbzjjHqEVBNDHmhRt8cjdgE/DGpkYENKEx6fRKtW8cWxU+lfGK9stZRsATZlUe8s2gHSZnfs4kmbtXTeeATnn3NsOB5gJubsACXj8tfduU9 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199021)(46966006)(36840700001)(40470700004)(5660300002)(40460700003)(8936002)(6862004)(8676002)(47076005)(36860700001)(83380400001)(186003)(336012)(2906002)(36756003)(2616005)(356005)(81166007)(82740400003)(31696002)(86362001)(82310400005)(40480700001)(44832011)(6506007)(26005)(6512007)(53546011)(966005)(316002)(4326008)(70206006)(70586007)(478600001)(41300700001)(31686004)(6486002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 15:16:38.0961 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 70ce4a1c-ad01-40ea-2074-08db5ba0b455 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7771 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ard, Thank you for the feedback. I will fix this in the v2 series. Regards, Sami Mujawar On 23/05/2023 02:32 pm, Ard Biesheuvel wrote: > On Tue, 23 May 2023 at 15:04, Sami Mujawar wrote: >> According to edk2 coding standard specification, Non-Boolean >> comparisons must use a compare operator (==, !=, >, < >=, <=). >> See Section 5.7.2.1 at https://edk2-docs.gitbook.io/ >> edk-ii-c-coding-standards-specification/5_source_files/ >> 57_c_programming >> >> Therefore, fix the comparison in ArmGicEnableDistributor() >> >> Signed-off-by: Sami Mujawar >> --- >> ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c b/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c >> index c17cbe041e8a9ceb8c8c3a6b953ff88b75f6f206..1ca66a40940434d6d89e243650f3e81aa3f588b5 100644 >> --- a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c >> +++ b/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c >> @@ -26,7 +26,10 @@ ArmGicEnableDistributor ( >> if (Revision == ARM_GIC_ARCH_REVISION_2) { >> MmioWrite32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1); >> } else { >> - if (MmioRead32 (GicDistributorBase + ARM_GIC_ICDDCR) & ARM_GIC_ICDDCR_ARE) { >> + if ((MmioRead32 ( >> + GicDistributorBase + ARM_GIC_ICDDCR >> + ) & ARM_GIC_ICDDCR_ARE) != 0) >> + { > This coding style is terrible. Mind using a temporary variable for the > result of the MmioRead32() instead? > >> MmioOr32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x2); >> } else { >> MmioOr32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1); >> -- >> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >>