From: "Rebecca Cran" <rebecca@bsdio.com>
To: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [PATCH 1/1] Platform/SbsaQemu: read platform version
Date: Wed, 10 May 2023 09:26:11 -0600 [thread overview]
Message-ID: <89ef45e7-4d21-e63b-46a9-72f20da572ec@bsdio.com> (raw)
In-Reply-To: <20230510150832.193178-1-marcin.juszkiewicz@linaro.org>
On 5/10/23 09:08, Marcin Juszkiewicz wrote:
> + Result = ArmCallSmc0(SIP_FUNCTION_ID(1), &Major, &Minor, NULL);
There should be space before the opening parenthesis.
Also, it would be nice to avoid a magic number - i.e. define what
SIP_FUNCTION_ID(1) is.
--
Rebecca Cran
next prev parent reply other threads:[~2023-05-10 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 15:08 [PATCH 1/1] Platform/SbsaQemu: read platform version Marcin Juszkiewicz
2023-05-10 15:21 ` [edk2-devel] " Ard Biesheuvel
2023-05-10 15:26 ` Rebecca Cran [this message]
2023-05-10 15:40 ` [PATCH v2 " Marcin Juszkiewicz
2023-05-10 15:49 ` Rebecca Cran
2023-05-10 16:06 ` [PATCH v3 " Marcin Juszkiewicz
2023-05-10 16:14 ` Rebecca Cran
2023-05-10 17:30 ` [PATCH v4 " Marcin Juszkiewicz
2023-05-10 17:32 ` [PATCH v3 " Marcin Juszkiewicz
[not found] ` <175DD274B9968CD4.32438@groups.io>
2023-05-10 15:42 ` [edk2-devel] [PATCH v2 " Marcin Juszkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89ef45e7-4d21-e63b-46a9-72f20da572ec@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox