From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mx.groups.io with SMTP id smtpd.web10.20566.1683732375121521082 for ; Wed, 10 May 2023 08:26:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=tuyv71FR; spf=pass (domain: bsdio.com, ip: 64.147.123.24, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 340AA3200942; Wed, 10 May 2023 11:26:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 10 May 2023 11:26:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683732373; x=1683818773; bh=6MFWkI81UkiM0t57G6LhXzdJOSUZRFmBpHt H1d18Ek0=; b=tuyv71FRFILNF0gIBMhuHVoX1TfpoUwDHCYjNJlA0zQkUcbawW4 4js/bh3JBRCFQtpK7EcdxGJEfnJxX82+7mRFFLHthcHL+jovDAQ6Pq8MAXtI2Uq0 GAXNdVHKrZ8LDHi2A7WyQHvA42BFIIQKno7TACcHSQPN9+i4CrLDcmkwua6vJFzJ SkRQOlwShsB4q0pYydH9JpSB/K8kLhnl2uyrJifxPPVB27GTN0WqzzXBkgjl+QM8 hKvjNCGYMZnEMT+KiXVztV9ooRC0yOUQMpStZpbNJNr3NPd8bzhM7xaS9NpXcY+J deTL5HKAnNfF0ruUGOKdcTsR+QcV+W4VEQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683732373; x=1683818773; bh=6MFWkI81UkiM0t57G6LhXzdJOSUZRFmBpHt H1d18Ek0=; b=hIUGCiAcp2H4GiJlynzx9DUEumakIVy4UObvIpSruS+epm2Y0Dv wawfV2Ssy8g5E49JdTWv5A/V9ofTVt1SUTZVsv4PkKDR/Hwy+kPsI10SGhIdF0ql VQVLondT1giXXA3qVEJEAqafB0r2jKXggfyPYf7l2sc0fy4OzMOx+buVWoQO4TKc nbEcMKYedUBaPjqe1ur+u2RxdeNMa4txdR02t10IT4fjW79zDrVwvIYRi4q6rMZG uuX6Is1mf5Dwm9kt1w0TacBHXNDbtHpk+CCtGBQVSGx8pvuB2Us7uaqwSQG+vTkR yHy3sbG22+lXXK8vAgrqYCplGEZOjwZCz7g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeegiedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 May 2023 11:26:12 -0400 (EDT) Message-ID: <89ef45e7-4d21-e63b-46a9-72f20da572ec@bsdio.com> Date: Wed, 10 May 2023 09:26:11 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/1] Platform/SbsaQemu: read platform version To: Marcin Juszkiewicz , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar References: <20230510150832.193178-1-marcin.juszkiewicz@linaro.org> From: "Rebecca Cran" In-Reply-To: <20230510150832.193178-1-marcin.juszkiewicz@linaro.org> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/10/23 09:08, Marcin Juszkiewicz wrote: > + Result = ArmCallSmc0(SIP_FUNCTION_ID(1), &Major, &Minor, NULL); There should be space before the opening parenthesis. Also, it would be nice to avoid a magic number - i.e. define what SIP_FUNCTION_ID(1) is. -- Rebecca Cran