[edk2-devel] [staging/dynamictables-reorg PATCH v1 0/2] DynamicTablesPkg: Arch Common Namespace

[edk2-devel] [staging/dynamictables-reorg PATCH v1 0/2] DynamicTablesPkg: Arch Common Namespace

[Sami Mujawar]

This series is an initial proposal for introducing an Arch Common
namespace. Based on the mailing list discussions, further patch
series to move the configuration manager objects to the Arch
Common namespace and the corresponding platform support patches
shall be submitted for review.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/3007_dynamictables_reorg_arch_namespace_v1

Sami Mujawar (2):
  DynamicTablesPkg: Introduce an Arch Common Namespace
  DynamicTablesPkg: Identify common Arm namespace objects

 DynamicTablesPkg/Include/ConfigurationManagerObject.h | 26 ++++--
 DynamicTablesPkg/Readme.md                            | 98 ++++++++++++++++++++
 2 files changed, 117 insertions(+), 7 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116330): https://edk2.groups.io/g/devel/message/116330
Mute This Topic: https://groups.io/mt/104726066/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [staging/dynamictables-reorg PATCH v1 1/2] DynamicTablesPkg: Introduce an Arch Common Namespace

[Sami Mujawar]

Introduce an Arch Common Namespace so that the common
architectural objects can be defined under this namespace
in the Configuration manager. Also rearrange the namespace
IDs so that the Arch Common Namespace has a value of 0x1,
the Arm Namespace ID has a value of 0x2, and the Custom/OEM
namespace ID has a value of 0xF. Also introduce a helper
macro to create configuration manager objects in the Arch
Common Namespace.

The Arch Common Namespace shall contain objects like
Serial Port, PCI Bus information etc. It must not contain
Architecture specific components e.g. GICC which is Arm
architecture specific component and therefore must be
defined in the Arm Namespace.

Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 DynamicTablesPkg/Include/ConfigurationManagerObject.h | 26 ++++--
 DynamicTablesPkg/Readme.md                            | 98 ++++++++++++++++++++
 2 files changed, 117 insertions(+), 7 deletions(-)

diff --git a/DynamicTablesPkg/Include/ConfigurationManagerObject.h b/DynamicTablesPkg/Include/ConfigurationManagerObject.h
index 74ad25d5d94a34da39e6c8dd909f9863e223d086..4255c82b42aefb52148a14a44c91328ec82f1550 100644
--- a/DynamicTablesPkg/Include/ConfigurationManagerObject.h
+++ b/DynamicTablesPkg/Include/ConfigurationManagerObject.h
@@ -1,6 +1,6 @@
 /** @file
 
-  Copyright (c) 2017 - 2022, ARM Limited. All rights reserved.
+  Copyright (c) 2017 - 2024, Arm Limited. All rights reserved.
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -29,8 +29,9 @@ _______________________________________________________________________________
 
 Bits: [31:28] - Name Space ID
                 0000 - Standard
-                0001 - ARM
-                1000 - Custom/OEM
+                0001 - Arch Common
+                0010 - ARM
+                1111 - Custom/OEM
                 All other values are reserved.
 
 Bits: [27:16] - Reserved.
@@ -105,10 +106,11 @@ typedef UINT32 CM_OBJECT_ID;
     for the Configuration Manager Objects.
 */
 typedef enum ObjectNameSpaceID {
-  EObjNameSpaceStandard,      ///< Standard Objects Namespace
-  EObjNameSpaceArm,           ///< ARM Objects Namespace
-  EObjNameSpaceOem = 0x8,     ///< OEM Objects Namespace
-  EObjNameSpaceMax
+  EObjNameSpaceStandard,          ///< Standard Objects Namespace
+  EObjNameSpaceArchCommon,        ///< Arch Common Objects Namespace
+  EObjNameSpaceArm,               ///< ARM Objects Namespace
+  EObjNameSpaceOem = 0xF,         ///< OEM Objects Namespace
+  EObjNameSpaceMax,
 } EOBJECT_NAMESPACE_ID;
 
 /** A descriptor for Configuration Manager Objects.
@@ -182,6 +184,16 @@ typedef struct CmObjDescriptor {
 #define CREATE_CM_ARM_OBJECT_ID(ObjectId) \
           (CREATE_CM_OBJECT_ID (EObjNameSpaceArm, ObjectId))
 
+/** This macro returns a Configuration Manager Object ID
+    in the Arch Common Object Namespace.
+
+  @param [in] ObjectId    The Object ID.
+
+  @retval Returns an Arch Common Configuration Manager Object ID.
+**/
+#define CREATE_CM_ARCH_COMMON_OBJECT_ID(ObjectId) \
+          (CREATE_CM_OBJECT_ID (EObjNameSpaceArchCommon, ObjectId))
+
 /** This macro returns a Configuration Manager Object ID
     in the OEM Object Namespace.
 
diff --git a/DynamicTablesPkg/Readme.md b/DynamicTablesPkg/Readme.md
index c1cdc5e17326709e811a2f3fe530316e95dec7ee..ba4ae7155f13a77298ece74cc567bb3e9dfc303d 100644
--- a/DynamicTablesPkg/Readme.md
+++ b/DynamicTablesPkg/Readme.md
@@ -402,3 +402,101 @@ Refer to the following presentation from *UEFI Plugfest Seattle 2018*:
 
 [Dynamic Tables Framework: A Step Towards Automatic Generation of Advanced Configuration and Power Interface (ACPI) & System Management BIOS (SMBIOS) Tables](http://www.uefi.org/sites/default/files/resources/Arm_Dynamic%20Tables%20Framework%20A%20Step%20Towards%20Automatic%20Generation%20of%20Advanced%20Configuration%20and%20Power%20Interface%20%28ACPI%29%20%26%20System%20Management%20BIOS%20%28SMBIOS%29%20Tables%20_0.pdf)
 
+## Configuration Manager Objects
+
+The CM_OBJECT_ID type is used to identify the Configuration Manager
+    objects.
+
+## Description of Configuration Manager Object ID
+
+| 31 30 29 28 | 27 | 26 | 25 | 24 | 23 | 22 | 21 | 20 | 19 | 18 | 17 | 16 | 15 | 14 | 13 | 12 | 11 | 10 | 9 | 8 | 7 6 5 4 3 2 1 0 |
+| ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: |
+| `Name Space ID` | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | `Object ID` |
+---------------------------------------------------------------------------------
+
+### Name Space ID: Bits [31:28]
+
+|  ID   |  Description                      | Comments |
+| ---:  | :--------------------------       | :---     |
+| 0000b | Standard                          | |
+| 0001b | Arch Common                       | |
+| 0010b | ARM                               | |
+| 1111b | Custom/OEM                        | |
+| `*`   | All other values are reserved.    | |
+
+### Bits: [27:8] - Reserved, must be zero.
+
+### Bits: [7:0] - Object ID
+
+#### Object ID's in the Standard Namespace:
+
+|  ID   |  Description                      | Comments |
+| ---:  | :--------------------------       | :---     |
+|   0   | Configuration Manager Revision    | |
+|   1   | ACPI Table List                   | |
+|   2   | SMBIOS Table List                 | |
+
+#### Object ID's in the ARM Namespace:
+
+|  ID   |  Description                              | Comments |
+| ---:  | :--------------------------               | :---     |
+|   0   | Reserved                                  | |
+|   1   | Boot Architecture Info                    | |
+|   2   | CPU Info                                  | |
+|   3   | Power Management Profile Info             | |
+|   4   | GICC Info                                 | |
+|   5   | GICD Info                                 | |
+|   6   | GIC MSI Frame Info                        | |
+|   7   | GIC Redistributor Info                    | |
+|   8   | GIC ITS Info                              | |
+|   9   | Serial Console Port Info                  | |
+|  10   | Serial Debug Port Info                    | |
+|  11   | Generic Timer Info                        | |
+|  12   | Platform GT Block Info                    | |
+|  13   | Generic Timer Block Frame Info            | |
+|  14   | Platform Generic Watchdog                 | |
+|  15   | PCI Configuration Space Info              | |
+|  16   | Hypervisor Vendor Id                      | |
+|  17   | Fixed feature flags for FADT              | |
+|  18   | ITS Group                                 | |
+|  19   | Named Component                           | |
+|  20   | Root Complex                              | |
+|  21   | SMMUv1 or SMMUv2                          | |
+|  22   | SMMUv3                                    | |
+|  23   | PMCG                                      | |
+|  24   | GIC ITS Identifier Array                  | |
+|  25   | ID Mapping Array                          | |
+|  26   | SMMU Interrupt Array                      | |
+|  27   | Processor Hierarchy Info                  | |
+|  28   | Cache Info                                | |
+|  29   | Reserved29                                | |
+|  30   | CM Object Reference                       | |
+|  31   | Memory Affinity Info                      | |
+|  32   | Device Handle Acpi                        | |
+|  33   | Device Handle PCI                         | |
+|  34   | Generic Initiator Affinity Info           | |
+|  35   | Serial Port Info                          | |
+|  36   | CMN 600 Info                              | |
+|  37   | Low Power Idle State Info                 | |
+|  38   | PCI Address Map Info                      | |
+|  39   | PCI Interrupt Map Info                    | |
+|  40   | Reserved Memory Range Node                | |
+|  41   | Memory Range Descriptor                   | |
+|  42   | Continuous Performance Control Info       | |
+|  43   | Pcc Subspace Type 0 Info                  | |
+|  44   | Pcc Subspace Type 1 Info                  | |
+|  45   | Pcc Subspace Type 2 Info                  | |
+|  46   | Pcc Subspace Type 3 Info                  | |
+|  47   | Pcc Subspace Type 4 Info                  | |
+|  48   | Pcc Subspace Type 5 Info                  | |
+|  49   | Embedded Trace Extension/Module Info      | |
+|  50   | P-State Dependency (PSD) Info             | |
+|  `*`  | All other values are reserved.            | |
+
+
+#### Object ID's in the Arch Common Namespace:
+
+|  ID   |  Description                      | Comments |
+| ---:  | :--------------------------       | :---     |
+|   0   |  Reserved                         | |
+
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116329): https://edk2.groups.io/g/devel/message/116329
Mute This Topic: https://groups.io/mt/104726065/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [staging/dynamictables-reorg PATCH v1 2/2] DynamicTablesPkg: Identify common Arm namespace objects

[Sami Mujawar]

Identify the Arm namespace objects that can be moved to
the Arch Common namespace. Also, identify the objects
that can be dropped.

Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
Cc: Jeshua Smith <jeshuas@nvidia.com>
Cc: Jeff Brasen <jbrasen@nvidia.com>
Cc: Girish Mahadevan <gmahadevan@nvidia.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 DynamicTablesPkg/Readme.md | 54 ++++++++++----------
 1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/DynamicTablesPkg/Readme.md b/DynamicTablesPkg/Readme.md
index ba4ae7155f13a77298ece74cc567bb3e9dfc303d..544cc9378cd179a347416c2f193c9842c67c70ea 100644
--- a/DynamicTablesPkg/Readme.md
+++ b/DynamicTablesPkg/Readme.md
@@ -442,22 +442,22 @@ The CM_OBJECT_ID type is used to identify the Configuration Manager
 | ---:  | :--------------------------               | :---     |
 |   0   | Reserved                                  | |
 |   1   | Boot Architecture Info                    | |
-|   2   | CPU Info                                  | |
-|   3   | Power Management Profile Info             | |
+|   2   | CPU Info                                  | Unused can be dropped|
+|   3   | Power Management Profile Info             | Move to Arch Common NS |
 |   4   | GICC Info                                 | |
 |   5   | GICD Info                                 | |
 |   6   | GIC MSI Frame Info                        | |
 |   7   | GIC Redistributor Info                    | |
 |   8   | GIC ITS Info                              | |
-|   9   | Serial Console Port Info                  | |
-|  10   | Serial Debug Port Info                    | |
+|   9   | Serial Console Port Info                  | Move to Arch Common NS |
+|  10   | Serial Debug Port Info                    | Move to Arch Common NS |
 |  11   | Generic Timer Info                        | |
 |  12   | Platform GT Block Info                    | |
 |  13   | Generic Timer Block Frame Info            | |
 |  14   | Platform Generic Watchdog                 | |
-|  15   | PCI Configuration Space Info              | |
-|  16   | Hypervisor Vendor Id                      | |
-|  17   | Fixed feature flags for FADT              | |
+|  15   | PCI Configuration Space Info              | Move to Arch Common NS |
+|  16   | Hypervisor Vendor Id                      | Move to Arch Common NS |
+|  17   | Fixed feature flags for FADT              | Move to Arch Common NS |
 |  18   | ITS Group                                 | |
 |  19   | Named Component                           | |
 |  20   | Root Complex                              | |
@@ -467,30 +467,30 @@ The CM_OBJECT_ID type is used to identify the Configuration Manager
 |  24   | GIC ITS Identifier Array                  | |
 |  25   | ID Mapping Array                          | |
 |  26   | SMMU Interrupt Array                      | |
-|  27   | Processor Hierarchy Info                  | |
-|  28   | Cache Info                                | |
-|  29   | Reserved29                                | |
-|  30   | CM Object Reference                       | |
-|  31   | Memory Affinity Info                      | |
-|  32   | Device Handle Acpi                        | |
-|  33   | Device Handle PCI                         | |
-|  34   | Generic Initiator Affinity Info           | |
-|  35   | Serial Port Info                          | |
+|  27   | Processor Hierarchy Info                  | Move to Arch Common NS |
+|  28   | Cache Info                                | Move to Arch Common NS |
+|  29   | Reserved29                                | Unused to be dropped.|
+|  30   | CM Object Reference                       | Move to Arch Common NS |
+|  31   | Memory Affinity Info                      | Move to Arch Common NS |
+|  32   | Device Handle Acpi                        | Move to Arch Common NS |
+|  33   | Device Handle PCI                         | Move to Arch Common NS |
+|  34   | Generic Initiator Affinity Info           | Move to Arch Common NS |
+|  35   | Serial Port Info                          | Move to Arch Common NS |
 |  36   | CMN 600 Info                              | |
-|  37   | Low Power Idle State Info                 | |
-|  38   | PCI Address Map Info                      | |
-|  39   | PCI Interrupt Map Info                    | |
+|  37   | Low Power Idle State Info                 | Move to Arch Common NS |
+|  38   | PCI Address Map Info                      | Move to Arch Common NS |
+|  39   | PCI Interrupt Map Info                    | Move to Arch Common NS |
 |  40   | Reserved Memory Range Node                | |
 |  41   | Memory Range Descriptor                   | |
-|  42   | Continuous Performance Control Info       | |
-|  43   | Pcc Subspace Type 0 Info                  | |
-|  44   | Pcc Subspace Type 1 Info                  | |
-|  45   | Pcc Subspace Type 2 Info                  | |
-|  46   | Pcc Subspace Type 3 Info                  | |
-|  47   | Pcc Subspace Type 4 Info                  | |
-|  48   | Pcc Subspace Type 5 Info                  | |
+|  42   | Continuous Performance Control Info       | Move to Arch Common NS |
+|  43   | Pcc Subspace Type 0 Info                  | Move to Arch Common NS |
+|  44   | Pcc Subspace Type 1 Info                  | Move to Arch Common NS |
+|  45   | Pcc Subspace Type 2 Info                  | Move to Arch Common NS |
+|  46   | Pcc Subspace Type 3 Info                  | Move to Arch Common NS |
+|  47   | Pcc Subspace Type 4 Info                  | Move to Arch Common NS |
+|  48   | Pcc Subspace Type 5 Info                  | Move to Arch Common NS |
 |  49   | Embedded Trace Extension/Module Info      | |
-|  50   | P-State Dependency (PSD) Info             | |
+|  50   | P-State Dependency (PSD) Info             | Move to Arch Common NS |
 |  `*`  | All other values are reserved.            | |
 
 
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116331): https://edk2.groups.io/g/devel/message/116331
Mute This Topic: https://groups.io/mt/104726067/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [staging/dynamictables-reorg PATCH v1 0/2] DynamicTablesPkg: Arch Common Namespace

[PierreGondois]

Hello Sami,
The patches look good to me:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

Shall we proceed to create the staging branch ?

Regards,
Pierre

On 3/4/24 17:46, Sami Mujawar wrote:
> This series is an initial proposal for introducing an Arch Common
> namespace. Based on the mailing list discussions, further patch
> series to move the configuration manager objects to the Arch
> Common namespace and the corresponding platform support patches
> shall be submitted for review.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/3007_dynamictables_reorg_arch_namespace_v1
> 
> Sami Mujawar (2):
>    DynamicTablesPkg: Introduce an Arch Common Namespace
>    DynamicTablesPkg: Identify common Arm namespace objects
> 
>   DynamicTablesPkg/Include/ConfigurationManagerObject.h | 26 ++++--
>   DynamicTablesPkg/Readme.md                            | 98 ++++++++++++++++++++
>   2 files changed, 117 insertions(+), 7 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116355): https://edk2.groups.io/g/devel/message/116355
Mute This Topic: https://groups.io/mt/104726066/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [staging/dynamictables-reorg PATCH v1 0/2] DynamicTablesPkg: Arch Common Namespace

[Sami Mujawar]

Hi Pierre,

The staging branches have been created at:
https://github.com/tianocore/edk2-staging/tree/dynamictables-reorg
https://github.com/tianocore/edk2-platforms/tree/devel-dynamictables-reorg

It would be good to have feedback from other stakeholders for this patch series.

Regards,

Sami Mujawar

On 05/03/2024, 08:45, "Pierre Gondois" <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>> wrote:


Hello Sami,
The patches look good to me:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>


Shall we proceed to create the staging branch ?


Regards,
Pierre


On 3/4/24 17:46, Sami Mujawar wrote:
> This series is an initial proposal for introducing an Arch Common
> namespace. Based on the mailing list discussions, further patch
> series to move the configuration manager objects to the Arch
> Common namespace and the corresponding platform support patches
> shall be submitted for review.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/3007_dynamictables_reorg_arch_namespace_v1 <https://github.com/samimujawar/edk2/tree/3007_dynamictables_reorg_arch_namespace_v1>
> 
> Sami Mujawar (2):
> DynamicTablesPkg: Introduce an Arch Common Namespace
> DynamicTablesPkg: Identify common Arm namespace objects
> 
> DynamicTablesPkg/Include/ConfigurationManagerObject.h | 26 ++++--
> DynamicTablesPkg/Readme.md | 98 ++++++++++++++++++++
> 2 files changed, 117 insertions(+), 7 deletions(-)
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116358): https://edk2.groups.io/g/devel/message/116358
Mute This Topic: https://groups.io/mt/104726066/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [staging/dynamictables-reorg PATCH v1 1/2] DynamicTablesPkg: Introduce an Arch Common Namespace

[Sunil V L]

On Mon, Mar 04, 2024 at 04:46:16PM +0000, Sami Mujawar wrote:
> Introduce an Arch Common Namespace so that the common
> architectural objects can be defined under this namespace
> in the Configuration manager. Also rearrange the namespace
> IDs so that the Arch Common Namespace has a value of 0x1,
> the Arm Namespace ID has a value of 0x2, and the Custom/OEM
> namespace ID has a value of 0xF. Also introduce a helper
> macro to create configuration manager objects in the Arch
> Common Namespace.
> 
> The Arch Common Namespace shall contain objects like
> Serial Port, PCI Bus information etc. It must not contain
> Architecture specific components e.g. GICC which is Arm
> architecture specific component and therefore must be
> defined in the Arm Namespace.
> 
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>
> Cc: Yeo Reum Yun <YeoReum.Yun@arm.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: AbdulLateef Attar <AbdulLateef.Attar@amd.com>
> Cc: Jeshua Smith <jeshuas@nvidia.com>
> Cc: Jeff Brasen <jbrasen@nvidia.com>
> Cc: Girish Mahadevan <gmahadevan@nvidia.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>  DynamicTablesPkg/Include/ConfigurationManagerObject.h | 26 ++++--
>  DynamicTablesPkg/Readme.md                            | 98 ++++++++++++++++++++
>  2 files changed, 117 insertions(+), 7 deletions(-)
> 
> diff --git a/DynamicTablesPkg/Include/ConfigurationManagerObject.h b/DynamicTablesPkg/Include/ConfigurationManagerObject.h
> index 74ad25d5d94a34da39e6c8dd909f9863e223d086..4255c82b42aefb52148a14a44c91328ec82f1550 100644
> --- a/DynamicTablesPkg/Include/ConfigurationManagerObject.h
> +++ b/DynamicTablesPkg/Include/ConfigurationManagerObject.h
> @@ -1,6 +1,6 @@
>  /** @file
>  
> -  Copyright (c) 2017 - 2022, ARM Limited. All rights reserved.
> +  Copyright (c) 2017 - 2024, Arm Limited. All rights reserved.
>  
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>  
> @@ -29,8 +29,9 @@ _______________________________________________________________________________
>  
>  Bits: [31:28] - Name Space ID
>                  0000 - Standard
> -                0001 - ARM
> -                1000 - Custom/OEM
> +                0001 - Arch Common
> +                0010 - ARM
> +                1111 - Custom/OEM
>                  All other values are reserved.
>  
>  Bits: [27:16] - Reserved.
> @@ -105,10 +106,11 @@ typedef UINT32 CM_OBJECT_ID;
>      for the Configuration Manager Objects.
>  */
>  typedef enum ObjectNameSpaceID {
> -  EObjNameSpaceStandard,      ///< Standard Objects Namespace
> -  EObjNameSpaceArm,           ///< ARM Objects Namespace
> -  EObjNameSpaceOem = 0x8,     ///< OEM Objects Namespace
> -  EObjNameSpaceMax
> +  EObjNameSpaceStandard,          ///< Standard Objects Namespace
> +  EObjNameSpaceArchCommon,        ///< Arch Common Objects Namespace
> +  EObjNameSpaceArm,               ///< ARM Objects Namespace
> +  EObjNameSpaceOem = 0xF,         ///< OEM Objects Namespace
> +  EObjNameSpaceMax,
>  } EOBJECT_NAMESPACE_ID;
>  
>  /** A descriptor for Configuration Manager Objects.
> @@ -182,6 +184,16 @@ typedef struct CmObjDescriptor {
>  #define CREATE_CM_ARM_OBJECT_ID(ObjectId) \
>            (CREATE_CM_OBJECT_ID (EObjNameSpaceArm, ObjectId))
>  
> +/** This macro returns a Configuration Manager Object ID
> +    in the Arch Common Object Namespace.
> +
> +  @param [in] ObjectId    The Object ID.
> +
> +  @retval Returns an Arch Common Configuration Manager Object ID.
> +**/
> +#define CREATE_CM_ARCH_COMMON_OBJECT_ID(ObjectId) \
> +          (CREATE_CM_OBJECT_ID (EObjNameSpaceArchCommon, ObjectId))
> +
>  /** This macro returns a Configuration Manager Object ID
>      in the OEM Object Namespace.
>  
> diff --git a/DynamicTablesPkg/Readme.md b/DynamicTablesPkg/Readme.md
> index c1cdc5e17326709e811a2f3fe530316e95dec7ee..ba4ae7155f13a77298ece74cc567bb3e9dfc303d 100644
> --- a/DynamicTablesPkg/Readme.md
> +++ b/DynamicTablesPkg/Readme.md
> @@ -402,3 +402,101 @@ Refer to the following presentation from *UEFI Plugfest Seattle 2018*:
>  
>  [Dynamic Tables Framework: A Step Towards Automatic Generation of Advanced Configuration and Power Interface (ACPI) & System Management BIOS (SMBIOS) Tables](http://www.uefi.org/sites/default/files/resources/Arm_Dynamic%20Tables%20Framework%20A%20Step%20Towards%20Automatic%20Generation%20of%20Advanced%20Configuration%20and%20Power%20Interface%20%28ACPI%29%20%26%20System%20Management%20BIOS%20%28SMBIOS%29%20Tables%20_0.pdf)
>  
> +## Configuration Manager Objects
> +
> +The CM_OBJECT_ID type is used to identify the Configuration Manager
> +    objects.
> +
> +## Description of Configuration Manager Object ID
> +
> +| 31 30 29 28 | 27 | 26 | 25 | 24 | 23 | 22 | 21 | 20 | 19 | 18 | 17 | 16 | 15 | 14 | 13 | 12 | 11 | 10 | 9 | 8 | 7 6 5 4 3 2 1 0 |
> +| ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: |
> +| `Name Space ID` | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | `Object ID` |
> +---------------------------------------------------------------------------------
> +
NIT: Can we minimize the width by using range instead of each bits? 31-28,
27-8 and 7-0 would be better even when it is rendered in the browser
IMO.

Otherwise LGTM.

Thanks!

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116359): https://edk2.groups.io/g/devel/message/116359
Mute This Topic: https://groups.io/mt/104726065/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [staging/dynamictables-reorg PATCH v1 0/2] DynamicTablesPkg: Arch Common Namespace

[Sunil V L]

Hi Sami,

On Mon, Mar 04, 2024 at 04:46:15PM +0000, Sami Mujawar wrote:
> This series is an initial proposal for introducing an Arch Common
> namespace. Based on the mailing list discussions, further patch
> series to move the configuration manager objects to the Arch
> Common namespace and the corresponding platform support patches
> shall be submitted for review.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/3007_dynamictables_reorg_arch_namespace_v1
> 
Looks good to me.

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

How do we plan creating further patches? I am fine with any approach you
suggest but don't want to duplicate effort. I think it would be helpful
to know whether someone is already working on it.

Thanks!
Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116360): https://edk2.groups.io/g/devel/message/116360
Mute This Topic: https://groups.io/mt/104726066/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [staging/dynamictables-reorg PATCH v1 1/2] DynamicTablesPkg: Introduce an Arch Common Namespace

[Sami Mujawar]

Hi Sunil,

Thank you for the feedback.
> +
> +The CM_OBJECT_ID type is used to identify the Configuration Manager
> + objects.
> +
> +## Description of Configuration Manager Object ID
> +
> +| 31 30 29 28 | 27 | 26 | 25 | 24 | 23 | 22 | 21 | 20 | 19 | 18 | 17 | 16 | 15 | 14 | 13 | 12 | 11 | 10 | 9 | 8 | 7 6 5 4 3 2 1 0 |
> +| ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: | ---: |
> +| `Name Space ID` | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | `Object ID` |
> +---------------------------------------------------------------------------------
> +
NIT: Can we minimize the width by using range instead of each bits? 31-28,
27-8 and 7-0 would be better even when it is rendered in the browser
IMO.
[SAMI] Ack.

Regards,

Sami Mujawar

Otherwise LGTM.


Thanks!


Reviewed-by: Sunil V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>














-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116361): https://edk2.groups.io/g/devel/message/116361
Mute This Topic: https://groups.io/mt/104726065/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [staging/dynamictables-reorg PATCH v1 0/2] DynamicTablesPkg: Arch Common Namespace

[Abdul Lateef Attar via groups.io]

Hi Sami, Sunil,

     Yesterday I submitted few patches on main branch; I'll port those 
changes to this staging branch.

Currently from AMD X64 perspective I'm working on ACPI tables, once that 
is done, then will move to smbios tables.

Thanks

AbduL


On 05-03-2024 16:22, Sunil V L wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Hi Sami,
>
> On Mon, Mar 04, 2024 at 04:46:15PM +0000, Sami Mujawar wrote:
>> This series is an initial proposal for introducing an Arch Common
>> namespace. Based on the mailing list discussions, further patch
>> series to move the configuration manager objects to the Arch
>> Common namespace and the corresponding platform support patches
>> shall be submitted for review.
>>
>> The changes can be seen at:
>> https://github.com/samimujawar/edk2/tree/3007_dynamictables_reorg_arch_namespace_v1
>>
> Looks good to me.
>
> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
>
> How do we plan creating further patches? I am fine with any approach you
> suggest but don't want to duplicate effort. I think it would be helpful
> to know whether someone is already working on it.
>
> Thanks!
> Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116362): https://edk2.groups.io/g/devel/message/116362
Mute This Topic: https://groups.io/mt/104726066/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [staging/dynamictables-reorg PATCH v1 0/2] DynamicTablesPkg: Arch Common Namespace

[PierreGondois]

Hello Adblu,
Thanks for the patches.

As the staging branch will see a lot of code changes,
it would be not integrate new objects in the next weeks.
Would it be possible to delay a bit the integration of your patches ?

Regards,
Pierre

On 3/5/24 12:09, Attar, AbdulLateef (Abdul Lateef) wrote:
> Hi Sami, Sunil,
> 
>       Yesterday I submitted few patches on main branch; I'll port those
> changes to this staging branch.
> 
> Currently from AMD X64 perspective I'm working on ACPI tables, once that
> is done, then will move to smbios tables.
> 
> Thanks
> 
> AbduL
> 
> 
> On 05-03-2024 16:22, Sunil V L wrote:
>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>
>>
>> Hi Sami,
>>
>> On Mon, Mar 04, 2024 at 04:46:15PM +0000, Sami Mujawar wrote:
>>> This series is an initial proposal for introducing an Arch Common
>>> namespace. Based on the mailing list discussions, further patch
>>> series to move the configuration manager objects to the Arch
>>> Common namespace and the corresponding platform support patches
>>> shall be submitted for review.
>>>
>>> The changes can be seen at:
>>> https://github.com/samimujawar/edk2/tree/3007_dynamictables_reorg_arch_namespace_v1
>>>
>> Looks good to me.
>>
>> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
>>
>> How do we plan creating further patches? I am fine with any approach you
>> suggest but don't want to duplicate effort. I think it would be helpful
>> to know whether someone is already working on it.
>>
>> Thanks!
>> Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116391): https://edk2.groups.io/g/devel/message/116391
Mute This Topic: https://groups.io/mt/104726066/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [staging/dynamictables-reorg PATCH v1 0/2] DynamicTablesPkg: Arch Common Namespace

[Abdul Lateef Attar via groups.io]

Hi Pierre,

     Thanks for reaching out, my patches are non-disruptive (wont impact 
existing ARM code base).

I think lets review and integrate to main branch.

Thanks

AbduL


On 05-03-2024 19:33, Pierre Gondois wrote:
> Caution: This message originated from an External Source. Use proper 
> caution when opening attachments, clicking links, or responding.
>
>
> Hello Adblu,
> Thanks for the patches.
>
> As the staging branch will see a lot of code changes,
> it would be not integrate new objects in the next weeks.
> Would it be possible to delay a bit the integration of your patches ?
>
> Regards,
> Pierre
>
> On 3/5/24 12:09, Attar, AbdulLateef (Abdul Lateef) wrote:
>> Hi Sami, Sunil,
>>
>>       Yesterday I submitted few patches on main branch; I'll port those
>> changes to this staging branch.
>>
>> Currently from AMD X64 perspective I'm working on ACPI tables, once that
>> is done, then will move to smbios tables.
>>
>> Thanks
>>
>> AbduL
>>
>>
>> On 05-03-2024 16:22, Sunil V L wrote:
>>> Caution: This message originated from an External Source. Use proper 
>>> caution when opening attachments, clicking links, or responding.
>>>
>>>
>>> Hi Sami,
>>>
>>> On Mon, Mar 04, 2024 at 04:46:15PM +0000, Sami Mujawar wrote:
>>>> This series is an initial proposal for introducing an Arch Common
>>>> namespace. Based on the mailing list discussions, further patch
>>>> series to move the configuration manager objects to the Arch
>>>> Common namespace and the corresponding platform support patches
>>>> shall be submitted for review.
>>>>
>>>> The changes can be seen at:
>>>> https://github.com/samimujawar/edk2/tree/3007_dynamictables_reorg_arch_namespace_v1 
>>>>
>>>>
>>> Looks good to me.
>>>
>>> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
>>>
>>> How do we plan creating further patches? I am fine with any approach 
>>> you
>>> suggest but don't want to duplicate effort. I think it would be helpful
>>> to know whether someone is already working on it.
>>>
>>> Thanks!
>>> Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116394): https://edk2.groups.io/g/devel/message/116394
Mute This Topic: https://groups.io/mt/104726066/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [staging/dynamictables-reorg PATCH v1 0/2] DynamicTablesPkg: Arch Common Namespace

[Sami Mujawar]

Hi Sunil,

> How do we plan creating further patches? I am fine with any approach you
> suggest but don't want to duplicate effort. I think it would be helpful
> to know whether someone is already working on it.
[SAMI] I am working on a patch series that moves the common objects from Arm Namespace to Arch Common Namespace.
Pierre is going to create a patch series for the corresponding edk2-platforms updates for FVP & Juno.
I think once we have reviewed and merged those, we can start looking at reorganising the files and directory structure.
Once this is completed, I think the arch specific patches can start being reviewed and merged.
[/SAMI]

Regards,

Sami Mujawar

> Thanks!
> Sunil





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116645): https://edk2.groups.io/g/devel/message/116645
Mute This Topic: https://groups.io/mt/104726066/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [staging/dynamictables-reorg PATCH v1 0/2] DynamicTablesPkg: Arch Common Namespace

[Sunil V L]

On Mon, Mar 11, 2024 at 07:35:28AM -0700, Sami Mujawar wrote:
> Hi Sunil,
> 
> > How do we plan creating further patches? I am fine with any approach you
> > suggest but don't want to duplicate effort. I think it would be helpful
> > to know whether someone is already working on it.
> [SAMI] I am working on a patch series that moves the common objects from Arm Namespace to Arch Common Namespace.
> Pierre is going to create a patch series for the corresponding edk2-platforms updates for FVP & Juno.
> I think once we have reviewed and merged those, we can start looking at reorganising the files and directory structure.
> Once this is completed, I think the arch specific patches can start being reviewed and merged.
>
Hi Sami,
Great!. Thanks!

-Sunil


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116667): https://edk2.groups.io/g/devel/message/116667
Mute This Topic: https://groups.io/mt/104726066/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-