From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=chen.a.chen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CA82921AE30DB for ; Mon, 24 Sep 2018 17:43:39 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 17:43:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,299,1534834800"; d="scan'208";a="265388497" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 24 Sep 2018 17:43:39 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 24 Sep 2018 17:43:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 24 Sep 2018 17:43:38 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.140]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.27]) with mapi id 14.03.0319.002; Tue, 25 Sep 2018 08:43:36 +0800 From: "Chen, Chen A" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Kinney, Michael D" Thread-Topic: [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file. Thread-Index: AQHUUUaRFEu5njQXEkWlvaF7Y6HGuqT5k0GAgAabpSA= Date: Tue, 25 Sep 2018 00:43:36 +0000 Message-ID: <8CCE94730AD68946B3D28B43192D9D2D0287412A@shsmsx102.ccr.corp.intel.com> References: <20180921010025.7088-1-chen.a.chen@intel.com> <20180921010025.7088-2-chen.a.chen@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BBD2562@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BBD2562@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 00:43:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good suggest for me. -----Original Message----- From: Zeng, Star=20 Sent: Friday, September 21, 2018 11:48 AM To: Chen, Chen A ; edk2-devel@lists.01.org Cc: Dong, Eric ; Kinney, Michael D ; Zeng, Star Subject: RE: [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC fil= e. As I remember, I raised comment about removing the PalLib in MdeModulePkg.d= sc at https://lists.01.org/pipermail/edk2-devel/2018-June/026079.html. I'd like suggest updating the title and commit message a little. For title: How about "MdeModulePkg: Remove PalLib in dsc which was missed a= t de00522" ? For commit message: How about like below? The PalLib is IPF specific and will be removed from MdePkg. So this patch removes PalLib in MdeModulePkg.dsc which was missed at de0052= 23b77c473d45c9c8a11147f6968325f73e. With them accepted, Reviewed-by: Star Zeng . Thanks, Star -----Original Message----- From: Chen, Chen A Sent: Friday, September 21, 2018 9:00 AM To: edk2-devel@lists.01.org Cc: Chen, Chen A ; Zeng, Star ;= Dong, Eric ; Kinney, Michael D Subject: [PATCH 2/3] MdeModulePkg: Remove the missing PalLib in DSC file. The PalLib will remove in MdePkg, so remove this lib from DSC file. Cc: Star Zeng Cc: Eric Dong Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen --- MdeModulePkg/MdeModulePkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc = index 8a81ea141f..3ff3b1213c 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -79,7 +79,6 @@ SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull= .inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf - PalLib|MdePkg/Library/BasePalLibNull/BasePalLibNull.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customize= dDisplayLib.inf FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltL= ib.inf # -- 2.16.2.windows.1