From: "Chen, Chen A" <chen.a.chen@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file.
Date: Tue, 25 Sep 2018 01:16:35 +0000 [thread overview]
Message-ID: <8CCE94730AD68946B3D28B43192D9D2D028771DE@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E31781E@SHSMSX104.ccr.corp.intel.com>
Ok
-----Original Message-----
From: Gao, Liming
Sent: Tuesday, September 25, 2018 9:16 AM
To: Chen, Chen A <chen.a.chen@intel.com>; edk2-devel@lists.01.org
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file.
Chen:
Please update patch title and commit message to follow Star comments.
Reviewed-by: Liming Gao <liming.gao@intel.com>
Thanks
Liming
>-----Original Message-----
>From: Chen, Chen A
>Sent: Friday, September 21, 2018 9:00 AM
>To: edk2-devel@lists.01.org
>Cc: Chen, Chen A <chen.a.chen@intel.com>; Gao, Liming
><liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib
>in DSC file.
>
>The PalLib will remove in MdePkg, so remove this lib from DSC file.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
>---
> IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
>b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
>index 84e1d890b5..894c5340a0 100644
>--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
>+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
>@@ -75,7 +75,6 @@
>
>DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTable
>Lib.inf
> UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
>- PalLib|MdePkg/Library/BasePalLibNull/BasePalLibNull.inf
>
> [LibraryClasses.common.PEIM]
> HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
>--
>2.16.2.windows.1
prev parent reply other threads:[~2018-09-25 1:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 1:00 [PATCH 1/3] IntelFrameworkModulePkg: Remove the missing PalLib in DSC file Chen A Chen
2018-09-21 1:00 ` [PATCH 2/3] MdeModulePkg: " Chen A Chen
2018-09-21 3:48 ` Zeng, Star
2018-09-25 0:43 ` Chen, Chen A
2018-09-21 1:00 ` [PATCH 3/3] SignedCapsulePkg: " Chen A Chen
2018-09-21 1:02 ` Yao, Jiewen
2018-09-25 1:16 ` [PATCH 1/3] IntelFrameworkModulePkg: " Gao, Liming
2018-09-25 1:16 ` Chen, Chen A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CCE94730AD68946B3D28B43192D9D2D028771DE@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox