From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=chen.a.chen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CF6FD203BBB80 for ; Thu, 24 Jan 2019 23:16:12 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2019 23:16:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,520,1539673200"; d="scan'208";a="313394202" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 24 Jan 2019 23:16:11 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 24 Jan 2019 23:16:11 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 24 Jan 2019 23:16:11 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.207]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.190]) with mapi id 14.03.0415.000; Fri, 25 Jan 2019 15:16:09 +0800 From: "Chen, Chen A" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Zhang, Chao B" , "Gao, Liming" Thread-Topic: [edk2] [PATCH 2/2] MdePkg/UefiGpt.h: Add new definition for enable GPT support Thread-Index: AQHUrgjQc7Nmg3VfOE68IO1kJfj376W/WFJwgABDxCA= Date: Fri, 25 Jan 2019 07:16:08 +0000 Message-ID: <8CCE94730AD68946B3D28B43192D9D2D06E6CF42@shsmsx102.ccr.corp.intel.com> References: <20190117020252.7560-1-chen.a.chen@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/2] MdePkg/UefiGpt.h: Add new definition for enable GPT support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 07:16:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable -----Original Message----- From: Wu, Hao A=20 Sent: Friday, January 25, 2019 11:04 AM To: Chen, Chen A ; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Zhang, Chao B ; Gao, Liming Subject: RE: [edk2] [PATCH 2/2] MdePkg/UefiGpt.h: Add new definition for en= able GPT support > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Chen A Chen > Sent: Thursday, January 17, 2019 10:03 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D; Zhang, Chao B; Gao, Liming > Subject: [edk2] [PATCH 2/2] MdePkg/UefiGpt.h: Add new definition for=20 > enable GPT support >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1470 > This two new definitions are defined for GPT in FatPei diver. >=20 > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Zhang Chao B > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chen A Chen > --- > MdePkg/Include/Uefi/UefiGpt.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) >=20 > diff --git a/MdePkg/Include/Uefi/UefiGpt.h=20 > b/MdePkg/Include/Uefi/UefiGpt.h index f635b05390..8665c8cbc9 100644 > --- a/MdePkg/Include/Uefi/UefiGpt.h > +++ b/MdePkg/Include/Uefi/UefiGpt.h > @@ -24,9 +24,25 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND,=20 > EITHER EXPRESS OR IMPLIED. > /// EFI Partition Table Signature: "EFI PART". > /// > #define EFI_PTAB_HEADER_ID SIGNATURE_64 ('E','F','I',' ','P','A','R= ','T') > +/// > +/// Minimum bytes reserve for EFI entry array buffer. > +/// > +#define GPT_PART_ENTRY_MIN_SIZE 16384 May I know where this definition comes from? Does it come from the UEFI spec? Chen: The MACRO is not explicitly defined in UEFI Spec, But UEFI Spec speci= fies a minimum value for GPT entry araray. >=20 > #pragma pack(1) >=20 > +/// > +/// MBR Partition Entry > +/// > +typedef struct { > + UINT8 BootIndicator; > + UINT8 StartingCHS[3]; > + UINT8 OSType; > + UINT8 EndingCHS[3]; > + UINT32 StartingLBA; > + UINT32 SizeInLBA; > +} MBR_PARTITION_ENTRY; > + What about using the 'MBR_PARTITION_RECORD' definition within edk2/MdePkg/I= nclude/IndustryStandard/Mbr.h and thus get rid of adding this one? Chen: This structure defined as the following format in Mbr.h typedef struct { .. UINT8 StartingLBA[4]; UINT8 SizeInLBA[4]; } MBR_PARTITION_RECORD; For StartingLBA, this field is represented the LBA, so I think it should be= UINT32 type not an array type. The same meaning is also for SizeInLba. Best Regards, Hao Wu > /// > /// GPT Partition Table Header. > /// > -- > 2.16.2.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel