From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=chen.a.chen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F3D0A211BA46B for ; Wed, 30 Jan 2019 19:38:16 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 19:38:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,543,1539673200"; d="scan'208";a="114095461" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 30 Jan 2019 19:38:15 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 30 Jan 2019 19:38:15 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 30 Jan 2019 19:38:15 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.207]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.194]) with mapi id 14.03.0415.000; Thu, 31 Jan 2019 11:38:13 +0800 From: "Chen, Chen A" To: "Wang, Jian J" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v4 0/4] Introduce CapsuleApp patch v4 Thread-Index: AQHUuQ1+FgQ3NFVqVk+MQ1pvsIDvLaXIJmYAgACSJ2A= Date: Thu, 31 Jan 2019 03:38:12 +0000 Message-ID: <8CCE94730AD68946B3D28B43192D9D2D06E70B27@shsmsx102.ccr.corp.intel.com> References: <20190131023418.11816-1-chen.a.chen@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v4 0/4] Introduce CapsuleApp patch v4 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 03:38:17 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jian. The interface CharToUpper() is used to convert just one character, But the = UpperCaseString is used to convert a string. I think it's no need to call CharToUpper repeatedly in UpperCaseString func= tion to convert a string. Regards, Chen -----Original Message----- From: Wang, Jian J=20 Sent: Thursday, January 31, 2019 10:48 AM To: Chen, Chen A ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v4 0/4] Introduce CapsuleApp patch v4 Chen, I just noticed that there's another patch series in which a new interface C= harToUpper() is introduced in BaseLib which can be used to replace your loc= al equivalent one UpperCaseString(). I would suggest to hold your patch for= a while and use the new interface instead once that patch series is pushed= . Sorry for the late remind. Regards, Jian > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Chen A Chen > Sent: Thursday, January 31, 2019 10:34 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v4 0/4] Introduce CapsuleApp patch v4 >=20 > No functionality change. > Fix ECC and code style issue. > Already pass CR process. > https://git-amr-7.devtools.intel.com/gerrit/#/c/39023/ >=20 > Chen A Chen (4): > MdePkg/UefiSpec.h: Add definition to support Capsule-on-Disk feature > MdeModulePkg/CapsuleApp: Add a function used to get next DevicePath > MdeModulePkg/CapsuleApp: Add functions to support Capsule-on-Disk > MdeModulePkg/CapsuleApp: Enhance CapsuleApp to support=20 > Capsule-on-Disk >=20 > MdeModulePkg/Application/CapsuleApp/CapsuleApp.c | 160 +++- > MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf | 8 + > MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 538 > +++++++++++++- > .../Application/CapsuleApp/CapsuleOnDisk.c | 808 > +++++++++++++++++++++ > MdeModulePkg/Include/Library/UefiBootManagerLib.h | 21 +- > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 24 +- > MdeModulePkg/MdeModulePkg.dsc | 1 + > MdePkg/Include/Uefi/UefiSpec.h | 5 + > 8 files changed, 1546 insertions(+), 19 deletions(-) create mode=20 > 100644 MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c >=20 > -- > 2.16.2.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel