From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: christopher.j.zurcher@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 13 Jun 2019 15:25:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 15:25:53 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jun 2019 15:25:53 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 15:25:53 -0700 Received: from crsmsx101.amr.corp.intel.com (172.18.63.136) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 15:25:53 -0700 Received: from crsmsx104.amr.corp.intel.com ([169.254.6.16]) by CRSMSX101.amr.corp.intel.com ([169.254.1.187]) with mapi id 14.03.0439.000; Thu, 13 Jun 2019 16:25:50 -0600 From: "Zurcher, Christopher J" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Yao, Jiewen" , "Wang, Jian J" Subject: Re: [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol Thread-Topic: [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol Thread-Index: AQHVIYxnFiRSwQynEUKScyp7VUlPfKaZiy2ggACSu7A= Date: Thu, 13 Jun 2019 22:25:50 +0000 Message-ID: <8EE4873E19344F4DA986A2AC15D512AE4613B908@CRSMSX104.amr.corp.intel.com> References: <20190613020454.19324-1-christopher.j.zurcher@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4809BF@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4809BF@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODFmOGZlMTYtYzM1NS00ZDBlLTk2NTctMDNmNTEwZTA2ZWE1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQkVCbEtQZzhqTVIwODNlbkdxUm9vTVBcL29hZHR5U2JtZWhMQVBya2g2XC9scWV2TWw1TSttT2MyQjhucWdCbkUyIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [172.18.205.10] MIME-Version: 1.0 Return-Path: christopher.j.zurcher@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable A unit test has been run which provisions RPMB key, writes data, and verifi= es it after reading on the following boot. Further, this code is being exercised for secure storage on multiple platfo= rms as part of standard boot flow. Unit test files emailed separately. Thanks, Christopher Zurcher -----Original Message----- From: Gao, Liming=20 Sent: Thursday, June 13, 2019 05:59 To: Zurcher, Christopher J ; devel@edk2.gr= oups.io Cc: Kinney, Michael D ; Yao, Jiewen ; Wang, Jian J Subject: RE: [PATCH v4 0/2] Add SCSI Support for Storage Security Command P= rotocol Zurcher: Can you share what test has been done for this feature? Thanks Liming > -----Original Message----- > From: Zurcher, Christopher J > Sent: Thursday, June 13, 2019 10:05 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Yao, Jiewen ; Wang, Jian J ; Gao, > Liming > Subject: [PATCH v4 0/2] Add SCSI Support for Storage Security Command Pro= tocol >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1546 >=20 > V4 changes: > Add SSC Protocol in addition to BlockIo instead of in place of BlockIo. > Add error handling for (BlockSize =3D=3D 0) in Read and WriteBlocks comma= nds > to handle partitions that do not support ReadCapacity(). >=20 > V3 changes: > Initialize AlignedBuffer variable in ScsiDiskReceiveData and > ScsiDiskSendData functions. Remove redundant input validation and debug > message in ScsiDiskSendData. >=20 > V2 changes: > Split the patch into separate commits for separate packages. >=20 > To support RPMB access on UFS devices, support must be added to > the ScsiDiskDxe driver for the Storage Security Command Protocol. >=20 > Cc: Michael D Kinney > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Liming Gao >=20 > Christopher J Zurcher (2): > MdePkg: Implement SCSI commands for Security Protocol In/Out > MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol >=20 > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 ++++++- > MdePkg/Include/IndustryStandard/Scsi.h | 48 +- > MdePkg/Include/Library/UefiScsiLib.h | 126 ++++- > MdePkg/Include/Protocol/ScsiIo.h | 9 +- > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 522 ++++++++++++++++= +++- > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 19 +- > MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 205 +++++++- > 9 files changed, 1064 insertions(+), 44 deletions(-) >=20 > -- > 2.16.2.windows.1