Shell version 2.2

Shell version 2.2

[Meenakshi Aggarwal]

Hi,


I can see UEFI shell specification 2.2 (http://www.uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pdf) is available,
But on edk2 master branch current version of Shell is still showing 2.1.

File:ShellPkg/Include/Protocol/EfiShell.h

enum ShellVersion {
  SHELL_MAJOR_VERSION = 2,
  SHELL_MINOR_VERSION = 1
};



Please tell if I am looking at correct file,
actually I want to update my shell to 2.2, but it looks like edk2 master branch doesn't support shell specification 2.2.

Is my understanding correct?



Thanks & Regards,
Meenakshi

Re: Shell version 2.2

[Carsey, Jaben]

I think that that version (2.1) is correct for the version of the protocol.  The protocol API was not changed for the UEFI Shell 2.2. 

That is the current version and should support the 2.2 spec.

-Jaben

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Meenakshi Aggarwal
> Sent: Friday, August 5, 2016 2:20 AM
> To: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
> Subject: [edk2] Shell version 2.2
> Importance: High
> 
> Hi,
> 
> 
> I can see UEFI shell specification 2.2
> (http://www.uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pdf) is
> available, But on edk2 master branch current version of Shell is still showing 2.1.
> 
> File:ShellPkg/Include/Protocol/EfiShell.h
> 
> enum ShellVersion {
>   SHELL_MAJOR_VERSION = 2,
>   SHELL_MINOR_VERSION = 1
> };
> 
> 
> 
> Please tell if I am looking at correct file, actually I want to update my shell to
> 2.2, but it looks like edk2 master branch doesn't support shell specification 2.2.
> 
> Is my understanding correct?
> 
> 
> 
> Thanks & Regards,
> Meenakshi
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: Shell version 2.2

[Tim Lewis]

Jaben --

Are there no shell commands where the standard command-line parameters have changed? 

Tim

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Carsey, Jaben
Sent: Friday, August 05, 2016 10:26 AM
To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
Cc: Carsey, Jaben <jaben.carsey@intel.com>
Subject: Re: [edk2] Shell version 2.2

I think that that version (2.1) is correct for the version of the protocol.  The protocol API was not changed for the UEFI Shell 2.2. 

That is the current version and should support the 2.2 spec.

-Jaben

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Meenakshi Aggarwal
> Sent: Friday, August 5, 2016 2:20 AM
> To: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
> Subject: [edk2] Shell version 2.2
> Importance: High
> 
> Hi,
> 
> 
> I can see UEFI shell specification 2.2
> (http://www.uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pdf) is
> available, But on edk2 master branch current version of Shell is still showing 2.1.
> 
> File:ShellPkg/Include/Protocol/EfiShell.h
> 
> enum ShellVersion {
>   SHELL_MAJOR_VERSION = 2,
>   SHELL_MINOR_VERSION = 1
> };
> 
> 
> 
> Please tell if I am looking at correct file, actually I want to update my shell to
> 2.2, but it looks like edk2 master branch doesn't support shell specification 2.2.
> 
> Is my understanding correct?
> 
> 
> 
> Thanks & Regards,
> Meenakshi
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: Shell version 2.2

[Carsey, Jaben]

Tim,

Yes, ver command would output that the version of the shell is different.

The #define below is specifically the version of the Protocol, not the version of the spec.

It could have been a miss on the part of the committee, but that was hoe I interpreted the non-change to the protocol version.

-Jaben

> -----Original Message-----
> From: Tim Lewis [mailto:tim.lewis@insyde.com]
> Sent: Friday, August 5, 2016 11:36 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; edk2-devel@lists.01.org <edk2-
> devel@ml01.01.org>
> Subject: RE: Shell version 2.2
> Importance: High
> 
> Jaben --
> 
> Are there no shell commands where the standard command-line parameters
> have changed?
> 
> Tim
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Friday, August 05, 2016 10:26 AM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> devel@lists.01.org <edk2-devel@ml01.01.org>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: Re: [edk2] Shell version 2.2
> 
> I think that that version (2.1) is correct for the version of the protocol.  The
> protocol API was not changed for the UEFI Shell 2.2.
> 
> That is the current version and should support the 2.2 spec.
> 
> -Jaben
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Meenakshi Aggarwal
> > Sent: Friday, August 5, 2016 2:20 AM
> > To: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
> > Subject: [edk2] Shell version 2.2
> > Importance: High
> >
> > Hi,
> >
> >
> > I can see UEFI shell specification 2.2
> > (http://www.uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pdf)
> > is available, But on edk2 master branch current version of Shell is still showing
> 2.1.
> >
> > File:ShellPkg/Include/Protocol/EfiShell.h
> >
> > enum ShellVersion {
> >   SHELL_MAJOR_VERSION = 2,
> >   SHELL_MINOR_VERSION = 1
> > };
> >
> >
> >
> > Please tell if I am looking at correct file, actually I want to update
> > my shell to 2.2, but it looks like edk2 master branch doesn't support shell
> specification 2.2.
> >
> > Is my understanding correct?
> >
> >
> >
> > Thanks & Regards,
> > Meenakshi
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: Shell version 2.2

[Tim Lewis]

Yes,  but they are the same numbers. So I think this is probably a 

The specification says (in the Shell protocol section's Related Defintiions):

#define EFI_SHELL_MAJOR_VERSION 2
#define EFI_SHELL_MINOR_VERSION 2

And, from ver.c:

        ShellPrintHiiEx (
          0,
          gST->ConOut->Mode->CursorRow,
          NULL,
          STRING_TOKEN (STR_VER_OUTPUT_SIMPLE),
          gShellLevel3HiiHandle,
          gEfiShellProtocol->MajorVersion,
          gEfiShellProtocol->MinorVersion
         );

And the shell protocol instance comes from ShellProtocol.c (see below):

EFI_SHELL_PROTOCOL         mShellProtocol = {
  EfiShellExecute,
  EfiShellGetEnv,
  EfiShellSetEnv,
  EfiShellGetAlias,
  EfiShellSetAlias,
  EfiShellGetHelpText,
  EfiShellGetDevicePathFromMap,
  EfiShellGetMapFromDevicePath,
  EfiShellGetDevicePathFromFilePath,
  EfiShellGetFilePathFromDevicePath,
  EfiShellSetMap,
  EfiShellGetCurDir,
  EfiShellSetCurDir,
  EfiShellOpenFileList,
  EfiShellFreeFileList,
  EfiShellRemoveDupInFileList,
  EfiShellBatchIsActive,
  EfiShellIsRootShell,
  EfiShellEnablePageBreak,
  EfiShellDisablePageBreak,
  EfiShellGetPageBreak,
  EfiShellGetDeviceName,
  (EFI_SHELL_GET_FILE_INFO)FileHandleGetInfo,         //*
  (EFI_SHELL_SET_FILE_INFO)FileHandleSetInfo,         //*
  EfiShellOpenFileByName,
  EfiShellClose,
  EfiShellCreateFile,
  (EFI_SHELL_READ_FILE)FileHandleRead,                //*
  (EFI_SHELL_WRITE_FILE)FileHandleWrite,              //*
  (EFI_SHELL_DELETE_FILE)FileHandleDelete,            //*
  EfiShellDeleteFileByName,
  (EFI_SHELL_GET_FILE_POSITION)FileHandleGetPosition, //*
  (EFI_SHELL_SET_FILE_POSITION)FileHandleSetPosition, //*
  (EFI_SHELL_FLUSH_FILE)FileHandleFlush,              //*
  EfiShellFindFiles,
  EfiShellFindFilesInDir,
  (EFI_SHELL_GET_FILE_SIZE)FileHandleGetSize,         //*
  EfiShellOpenRoot,
  EfiShellOpenRootByHandle,
  NULL,
  SHELL_MAJOR_VERSION,
  SHELL_MINOR_VERSION,

  // New for UEFI Shell 2.1
  EfiShellRegisterGuidName,
  EfiShellGetGuidName,
  EfiShellGetGuidFromName,
  EfiShellGetEnvEx
};

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Carsey, Jaben
Sent: Friday, August 05, 2016 12:10 PM
To: Tim Lewis <tim.lewis@insyde.com>; Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
Cc: Carsey, Jaben <jaben.carsey@intel.com>
Subject: Re: [edk2] Shell version 2.2

Tim,

Yes, ver command would output that the version of the shell is different.

The #define below is specifically the version of the Protocol, not the version of the spec.

It could have been a miss on the part of the committee, but that was hoe I interpreted the non-change to the protocol version.

-Jaben

> -----Original Message-----
> From: Tim Lewis [mailto:tim.lewis@insyde.com]
> Sent: Friday, August 5, 2016 11:36 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Meenakshi Aggarwal 
> <meenakshi.aggarwal@nxp.com>; edk2-devel@lists.01.org <edk2- 
> devel@ml01.01.org>
> Subject: RE: Shell version 2.2
> Importance: High
> 
> Jaben --
> 
> Are there no shell commands where the standard command-line parameters 
> have changed?
> 
> Tim
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
> Carsey, Jaben
> Sent: Friday, August 05, 2016 10:26 AM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2- 
> devel@lists.01.org <edk2-devel@ml01.01.org>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: Re: [edk2] Shell version 2.2
> 
> I think that that version (2.1) is correct for the version of the 
> protocol.  The protocol API was not changed for the UEFI Shell 2.2.
> 
> That is the current version and should support the 2.2 spec.
> 
> -Jaben
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf 
> > Of Meenakshi Aggarwal
> > Sent: Friday, August 5, 2016 2:20 AM
> > To: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
> > Subject: [edk2] Shell version 2.2
> > Importance: High
> >
> > Hi,
> >
> >
> > I can see UEFI shell specification 2.2
> > (http://www.uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pd
> > f) is available, But on edk2 master branch current version of Shell 
> > is still showing
> 2.1.
> >
> > File:ShellPkg/Include/Protocol/EfiShell.h
> >
> > enum ShellVersion {
> >   SHELL_MAJOR_VERSION = 2,
> >   SHELL_MINOR_VERSION = 1
> > };
> >
> >
> >
> > Please tell if I am looking at correct file, actually I want to 
> > update my shell to 2.2, but it looks like edk2 master branch doesn't 
> > support shell
> specification 2.2.
> >
> > Is my understanding correct?
> >
> >
> >
> > Thanks & Regards,
> > Meenakshi
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: Shell version 2.2

[Bhupesh Sharma]

Unfortunately the 'ver' command on the shell also shows up a 2.1 shell version with the latest edk2/master.

So, we think it is rather a bug.

Regards,
Bhupesh


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tim Lewis
> Sent: Saturday, August 06, 2016 12:47 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; edk2-devel@lists.01.org <edk2-
> devel@ml01.01.org>
> Subject: Re: [edk2] Shell version 2.2
> 
> Yes,  but they are the same numbers. So I think this is probably a
> 
> The specification says (in the Shell protocol section's Related
> Defintiions):
> 
> #define EFI_SHELL_MAJOR_VERSION 2
> #define EFI_SHELL_MINOR_VERSION 2
> 
> And, from ver.c:
> 
>         ShellPrintHiiEx (
>           0,
>           gST->ConOut->Mode->CursorRow,
>           NULL,
>           STRING_TOKEN (STR_VER_OUTPUT_SIMPLE),
>           gShellLevel3HiiHandle,
>           gEfiShellProtocol->MajorVersion,
>           gEfiShellProtocol->MinorVersion
>          );
> 
> And the shell protocol instance comes from ShellProtocol.c (see below):
> 
> EFI_SHELL_PROTOCOL         mShellProtocol = {
>   EfiShellExecute,
>   EfiShellGetEnv,
>   EfiShellSetEnv,
>   EfiShellGetAlias,
>   EfiShellSetAlias,
>   EfiShellGetHelpText,
>   EfiShellGetDevicePathFromMap,
>   EfiShellGetMapFromDevicePath,
>   EfiShellGetDevicePathFromFilePath,
>   EfiShellGetFilePathFromDevicePath,
>   EfiShellSetMap,
>   EfiShellGetCurDir,
>   EfiShellSetCurDir,
>   EfiShellOpenFileList,
>   EfiShellFreeFileList,
>   EfiShellRemoveDupInFileList,
>   EfiShellBatchIsActive,
>   EfiShellIsRootShell,
>   EfiShellEnablePageBreak,
>   EfiShellDisablePageBreak,
>   EfiShellGetPageBreak,
>   EfiShellGetDeviceName,
>   (EFI_SHELL_GET_FILE_INFO)FileHandleGetInfo,         //*
>   (EFI_SHELL_SET_FILE_INFO)FileHandleSetInfo,         //*
>   EfiShellOpenFileByName,
>   EfiShellClose,
>   EfiShellCreateFile,
>   (EFI_SHELL_READ_FILE)FileHandleRead,                //*
>   (EFI_SHELL_WRITE_FILE)FileHandleWrite,              //*
>   (EFI_SHELL_DELETE_FILE)FileHandleDelete,            //*
>   EfiShellDeleteFileByName,
>   (EFI_SHELL_GET_FILE_POSITION)FileHandleGetPosition, //*
>   (EFI_SHELL_SET_FILE_POSITION)FileHandleSetPosition, //*
>   (EFI_SHELL_FLUSH_FILE)FileHandleFlush,              //*
>   EfiShellFindFiles,
>   EfiShellFindFilesInDir,
>   (EFI_SHELL_GET_FILE_SIZE)FileHandleGetSize,         //*
>   EfiShellOpenRoot,
>   EfiShellOpenRootByHandle,
>   NULL,
>   SHELL_MAJOR_VERSION,
>   SHELL_MINOR_VERSION,
> 
>   // New for UEFI Shell 2.1
>   EfiShellRegisterGuidName,
>   EfiShellGetGuidName,
>   EfiShellGetGuidFromName,
>   EfiShellGetEnvEx
> };
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Friday, August 05, 2016 12:10 PM
> To: Tim Lewis <tim.lewis@insyde.com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; edk2-devel@lists.01.org <edk2-
> devel@ml01.01.org>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: Re: [edk2] Shell version 2.2
> 
> Tim,
> 
> Yes, ver command would output that the version of the shell is
> different.
> 
> The #define below is specifically the version of the Protocol, not the
> version of the spec.
> 
> It could have been a miss on the part of the committee, but that was
> hoe I interpreted the non-change to the protocol version.
> 
> -Jaben
> 
> > -----Original Message-----
> > From: Tim Lewis [mailto:tim.lewis@insyde.com]
> > Sent: Friday, August 5, 2016 11:36 AM
> > To: Carsey, Jaben <jaben.carsey@intel.com>; Meenakshi Aggarwal
> > <meenakshi.aggarwal@nxp.com>; edk2-devel@lists.01.org <edk2-
> > devel@ml01.01.org>
> > Subject: RE: Shell version 2.2
> > Importance: High
> >
> > Jaben --
> >
> > Are there no shell commands where the standard command-line
> parameters
> > have changed?
> >
> > Tim
> >
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> Of
> > Carsey, Jaben
> > Sent: Friday, August 05, 2016 10:26 AM
> > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> > devel@lists.01.org <edk2-devel@ml01.01.org>
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>
> > Subject: Re: [edk2] Shell version 2.2
> >
> > I think that that version (2.1) is correct for the version of the
> > protocol.  The protocol API was not changed for the UEFI Shell 2.2.
> >
> > That is the current version and should support the 2.2 spec.
> >
> > -Jaben
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> > > Of Meenakshi Aggarwal
> > > Sent: Friday, August 5, 2016 2:20 AM
> > > To: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
> > > Subject: [edk2] Shell version 2.2
> > > Importance: High
> > >
> > > Hi,
> > >
> > >
> > > I can see UEFI shell specification 2.2
> > >
> (http://www.uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pd
> > > f) is available, But on edk2 master branch current version of Shell
> > > is still showing
> > 2.1.
> > >
> > > File:ShellPkg/Include/Protocol/EfiShell.h
> > >
> > > enum ShellVersion {
> > >   SHELL_MAJOR_VERSION = 2,
> > >   SHELL_MINOR_VERSION = 1
> > > };
> > >
> > >
> > >
> > > Please tell if I am looking at correct file, actually I want to
> > > update my shell to 2.2, but it looks like edk2 master branch
> doesn't
> > > support shell
> > specification 2.2.
> > >
> > > Is my understanding correct?
> > >
> > >
> > >
> > > Thanks & Regards,
> > > Meenakshi
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: Shell version 2.2

[Rothman, Michael A]

I think the ver should reflect the spec version on which the shell was built. I'm not sure why it would be 2.1 if built on 2.2 compliant code.

Thanks,
Michael A. Rothman
---------------------------------------------------------------
Let no excuse be a barrier to your success.

> On Aug 5, 2016, at 12:16 PM, Tim Lewis <tim.lewis@insyde.com> wrote:
> 
> Yes,  but they are the same numbers. So I think this is probably a 
> 
> The specification says (in the Shell protocol section's Related Defintiions):
> 
> #define EFI_SHELL_MAJOR_VERSION 2
> #define EFI_SHELL_MINOR_VERSION 2
> 
> And, from ver.c:
> 
>        ShellPrintHiiEx (
>          0,
>          gST->ConOut->Mode->CursorRow,
>          NULL,
>          STRING_TOKEN (STR_VER_OUTPUT_SIMPLE),
>          gShellLevel3HiiHandle,
>          gEfiShellProtocol->MajorVersion,
>          gEfiShellProtocol->MinorVersion
>         );
> 
> And the shell protocol instance comes from ShellProtocol.c (see below):
> 
> EFI_SHELL_PROTOCOL         mShellProtocol = {
>  EfiShellExecute,
>  EfiShellGetEnv,
>  EfiShellSetEnv,
>  EfiShellGetAlias,
>  EfiShellSetAlias,
>  EfiShellGetHelpText,
>  EfiShellGetDevicePathFromMap,
>  EfiShellGetMapFromDevicePath,
>  EfiShellGetDevicePathFromFilePath,
>  EfiShellGetFilePathFromDevicePath,
>  EfiShellSetMap,
>  EfiShellGetCurDir,
>  EfiShellSetCurDir,
>  EfiShellOpenFileList,
>  EfiShellFreeFileList,
>  EfiShellRemoveDupInFileList,
>  EfiShellBatchIsActive,
>  EfiShellIsRootShell,
>  EfiShellEnablePageBreak,
>  EfiShellDisablePageBreak,
>  EfiShellGetPageBreak,
>  EfiShellGetDeviceName,
>  (EFI_SHELL_GET_FILE_INFO)FileHandleGetInfo,         //*
>  (EFI_SHELL_SET_FILE_INFO)FileHandleSetInfo,         //*
>  EfiShellOpenFileByName,
>  EfiShellClose,
>  EfiShellCreateFile,
>  (EFI_SHELL_READ_FILE)FileHandleRead,                //*
>  (EFI_SHELL_WRITE_FILE)FileHandleWrite,              //*
>  (EFI_SHELL_DELETE_FILE)FileHandleDelete,            //*
>  EfiShellDeleteFileByName,
>  (EFI_SHELL_GET_FILE_POSITION)FileHandleGetPosition, //*
>  (EFI_SHELL_SET_FILE_POSITION)FileHandleSetPosition, //*
>  (EFI_SHELL_FLUSH_FILE)FileHandleFlush,              //*
>  EfiShellFindFiles,
>  EfiShellFindFilesInDir,
>  (EFI_SHELL_GET_FILE_SIZE)FileHandleGetSize,         //*
>  EfiShellOpenRoot,
>  EfiShellOpenRootByHandle,
>  NULL,
>  SHELL_MAJOR_VERSION,
>  SHELL_MINOR_VERSION,
> 
>  // New for UEFI Shell 2.1
>  EfiShellRegisterGuidName,
>  EfiShellGetGuidName,
>  EfiShellGetGuidFromName,
>  EfiShellGetEnvEx
> };
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Carsey, Jaben
> Sent: Friday, August 05, 2016 12:10 PM
> To: Tim Lewis <tim.lewis@insyde.com>; Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: Re: [edk2] Shell version 2.2
> 
> Tim,
> 
> Yes, ver command would output that the version of the shell is different.
> 
> The #define below is specifically the version of the Protocol, not the version of the spec.
> 
> It could have been a miss on the part of the committee, but that was hoe I interpreted the non-change to the protocol version.
> 
> -Jaben
> 
>> -----Original Message-----
>> From: Tim Lewis [mailto:tim.lewis@insyde.com]
>> Sent: Friday, August 5, 2016 11:36 AM
>> To: Carsey, Jaben <jaben.carsey@intel.com>; Meenakshi Aggarwal 
>> <meenakshi.aggarwal@nxp.com>; edk2-devel@lists.01.org <edk2- 
>> devel@ml01.01.org>
>> Subject: RE: Shell version 2.2
>> Importance: High
>> 
>> Jaben --
>> 
>> Are there no shell commands where the standard command-line parameters 
>> have changed?
>> 
>> Tim
>> 
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
>> Carsey, Jaben
>> Sent: Friday, August 05, 2016 10:26 AM
>> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2- 
>> devel@lists.01.org <edk2-devel@ml01.01.org>
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>
>> Subject: Re: [edk2] Shell version 2.2
>> 
>> I think that that version (2.1) is correct for the version of the 
>> protocol.  The protocol API was not changed for the UEFI Shell 2.2.
>> 
>> That is the current version and should support the 2.2 spec.
>> 
>> -Jaben
>> 
>>> -----Original Message-----
>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf 
>>> Of Meenakshi Aggarwal
>>> Sent: Friday, August 5, 2016 2:20 AM
>>> To: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
>>> Subject: [edk2] Shell version 2.2
>>> Importance: High
>>> 
>>> Hi,
>>> 
>>> 
>>> I can see UEFI shell specification 2.2
>>> (http://www.uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pd
>>> f) is available, But on edk2 master branch current version of Shell 
>>> is still showing
>> 2.1.
>>> 
>>> File:ShellPkg/Include/Protocol/EfiShell.h
>>> 
>>> enum ShellVersion {
>>>  SHELL_MAJOR_VERSION = 2,
>>>  SHELL_MINOR_VERSION = 1
>>> };
>>> 
>>> 
>>> 
>>> Please tell if I am looking at correct file, actually I want to 
>>> update my shell to 2.2, but it looks like edk2 master branch doesn't 
>>> support shell
>> specification 2.2.
>>> 
>>> Is my understanding correct?
>>> 
>>> 
>>> 
>>> Thanks & Regards,
>>> Meenakshi
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>> https://lists.01.org/mailman/listinfo/edk2-devel
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel