From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ml01.01.org (Postfix) with ESMTP id 459F11A1DF5 for ; Fri, 5 Aug 2016 12:46:06 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 05 Aug 2016 12:46:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,474,1464678000"; d="scan'208";a="1009238203" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga001.jf.intel.com with ESMTP; 05 Aug 2016 12:46:07 -0700 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.32]) by ORSMSX101.amr.corp.intel.com ([169.254.8.239]) with mapi id 14.03.0248.002; Fri, 5 Aug 2016 12:46:05 -0700 From: "Rothman, Michael A" To: Tim Lewis CC: "Carsey, Jaben" , Meenakshi Aggarwal , "edk2-devel@lists.01.org" Thread-Topic: [edk2] Shell version 2.2 Thread-Index: AQHR71IAFXtvGcG51EqlepxukzILkw== Date: Fri, 5 Aug 2016 19:46:05 +0000 Message-ID: <8EE61E8F-8085-4D3C-8A99-2CF467695058@intel.com> References: <7236196A5DF6C040855A6D96F556A53F3DA5B3@msmail.insydesw.com.tw> , <7236196A5DF6C040855A6D96F556A53F3DA697@msmail.insydesw.com.tw> In-Reply-To: <7236196A5DF6C040855A6D96F556A53F3DA697@msmail.insydesw.com.tw> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 Subject: Re: Shell version 2.2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2016 19:46:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I think the ver should reflect the spec version on which the shell was buil= t. I'm not sure why it would be 2.1 if built on 2.2 compliant code. Thanks, Michael A. Rothman --------------------------------------------------------------- Let no excuse be a barrier to your success. > On Aug 5, 2016, at 12:16 PM, Tim Lewis wrote: >=20 > Yes, but they are the same numbers. So I think this is probably a=20 >=20 > The specification says (in the Shell protocol section's Related Defintiio= ns): >=20 > #define EFI_SHELL_MAJOR_VERSION 2 > #define EFI_SHELL_MINOR_VERSION 2 >=20 > And, from ver.c: >=20 > ShellPrintHiiEx ( > 0, > gST->ConOut->Mode->CursorRow, > NULL, > STRING_TOKEN (STR_VER_OUTPUT_SIMPLE), > gShellLevel3HiiHandle, > gEfiShellProtocol->MajorVersion, > gEfiShellProtocol->MinorVersion > ); >=20 > And the shell protocol instance comes from ShellProtocol.c (see below): >=20 > EFI_SHELL_PROTOCOL mShellProtocol =3D { > EfiShellExecute, > EfiShellGetEnv, > EfiShellSetEnv, > EfiShellGetAlias, > EfiShellSetAlias, > EfiShellGetHelpText, > EfiShellGetDevicePathFromMap, > EfiShellGetMapFromDevicePath, > EfiShellGetDevicePathFromFilePath, > EfiShellGetFilePathFromDevicePath, > EfiShellSetMap, > EfiShellGetCurDir, > EfiShellSetCurDir, > EfiShellOpenFileList, > EfiShellFreeFileList, > EfiShellRemoveDupInFileList, > EfiShellBatchIsActive, > EfiShellIsRootShell, > EfiShellEnablePageBreak, > EfiShellDisablePageBreak, > EfiShellGetPageBreak, > EfiShellGetDeviceName, > (EFI_SHELL_GET_FILE_INFO)FileHandleGetInfo, //* > (EFI_SHELL_SET_FILE_INFO)FileHandleSetInfo, //* > EfiShellOpenFileByName, > EfiShellClose, > EfiShellCreateFile, > (EFI_SHELL_READ_FILE)FileHandleRead, //* > (EFI_SHELL_WRITE_FILE)FileHandleWrite, //* > (EFI_SHELL_DELETE_FILE)FileHandleDelete, //* > EfiShellDeleteFileByName, > (EFI_SHELL_GET_FILE_POSITION)FileHandleGetPosition, //* > (EFI_SHELL_SET_FILE_POSITION)FileHandleSetPosition, //* > (EFI_SHELL_FLUSH_FILE)FileHandleFlush, //* > EfiShellFindFiles, > EfiShellFindFilesInDir, > (EFI_SHELL_GET_FILE_SIZE)FileHandleGetSize, //* > EfiShellOpenRoot, > EfiShellOpenRootByHandle, > NULL, > SHELL_MAJOR_VERSION, > SHELL_MINOR_VERSION, >=20 > // New for UEFI Shell 2.1 > EfiShellRegisterGuidName, > EfiShellGetGuidName, > EfiShellGetGuidFromName, > EfiShellGetEnvEx > }; >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ca= rsey, Jaben > Sent: Friday, August 05, 2016 12:10 PM > To: Tim Lewis ; Meenakshi Aggarwal ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: Re: [edk2] Shell version 2.2 >=20 > Tim, >=20 > Yes, ver command would output that the version of the shell is different. >=20 > The #define below is specifically the version of the Protocol, not the ve= rsion of the spec. >=20 > It could have been a miss on the part of the committee, but that was hoe = I interpreted the non-change to the protocol version. >=20 > -Jaben >=20 >> -----Original Message----- >> From: Tim Lewis [mailto:tim.lewis@insyde.com] >> Sent: Friday, August 5, 2016 11:36 AM >> To: Carsey, Jaben ; Meenakshi Aggarwal=20 >> ; edk2-devel@lists.01.org > devel@ml01.01.org> >> Subject: RE: Shell version 2.2 >> Importance: High >>=20 >> Jaben -- >>=20 >> Are there no shell commands where the standard command-line parameters=20 >> have changed? >>=20 >> Tim >>=20 >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 >> Carsey, Jaben >> Sent: Friday, August 05, 2016 10:26 AM >> To: Meenakshi Aggarwal ; edk2-=20 >> devel@lists.01.org >> Cc: Carsey, Jaben >> Subject: Re: [edk2] Shell version 2.2 >>=20 >> I think that that version (2.1) is correct for the version of the=20 >> protocol. The protocol API was not changed for the UEFI Shell 2.2. >>=20 >> That is the current version and should support the 2.2 spec. >>=20 >> -Jaben >>=20 >>> -----Original Message----- >>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf=20 >>> Of Meenakshi Aggarwal >>> Sent: Friday, August 5, 2016 2:20 AM >>> To: edk2-devel@lists.01.org >>> Subject: [edk2] Shell version 2.2 >>> Importance: High >>>=20 >>> Hi, >>>=20 >>>=20 >>> I can see UEFI shell specification 2.2 >>> (http://www.uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pd >>> f) is available, But on edk2 master branch current version of Shell=20 >>> is still showing >> 2.1. >>>=20 >>> File:ShellPkg/Include/Protocol/EfiShell.h >>>=20 >>> enum ShellVersion { >>> SHELL_MAJOR_VERSION =3D 2, >>> SHELL_MINOR_VERSION =3D 1 >>> }; >>>=20 >>>=20 >>>=20 >>> Please tell if I am looking at correct file, actually I want to=20 >>> update my shell to 2.2, but it looks like edk2 master branch doesn't=20 >>> support shell >> specification 2.2. >>>=20 >>> Is my understanding correct? >>>=20 >>>=20 >>>=20 >>> Thanks & Regards, >>> Meenakshi >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel