From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: devel@edk2.groups.io, samer@elhajmahmoud.com
Cc: Pete Batard <pete@akeo.ie>, Leif Lindholm <leif@nuviainc.com>
Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe
Date: Mon, 13 Apr 2020 13:27:59 +0200 [thread overview]
Message-ID: <8a129b98-62c4-cc2c-9481-d8b2569512a8@arm.com> (raw)
In-Reply-To: <20200411155611.632-1-samer@elhajmahmoud.com>
On 4/11/20 5:56 PM, Samer El-Haj-Mahmoud via groups.io wrote:
> Switch RaspberryPi from using a private GraphicsConsoleDxe to
> the common GraphicsConsoleDxe in MdeModulePkg.
>
> Samer El-Haj-Mahmoud (3):
> Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe
> Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe
> Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe
>
Thanks Samer
The only thing missing from these patches is setting the following
feature PCD in the DSCs somewhere:
gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE
This is needed because the generic GraphicsConsoleDxe has UGA support as
well (which Andrei ripped out for the RPi clone, I suppose), and it is
enabled by default, unless you set the PCD to FALSE to disable it.
Can you incorporate this into patches 1 and 2, and resend? Thanks.
prev parent reply other threads:[~2020-04-13 11:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 15:56 [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe Samer El-Haj-Mahmoud
2020-04-11 15:56 ` [edk2-platform][PATCH v1 1/3] Platform/RaspberryPi/RPi4: " Samer El-Haj-Mahmoud
2020-04-11 19:45 ` Ard Biesheuvel
2020-04-11 19:47 ` Ard Biesheuvel
2020-04-11 19:56 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-04-14 16:28 ` Andrei Warkentin
2020-04-11 15:56 ` [edk2-platform][PATCH v1 2/3] Platform/RaspberryPi/RPi3: " Samer El-Haj-Mahmoud
2020-04-11 15:56 ` [edk2-platform][PATCH v1 3/3] Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe Samer El-Haj-Mahmoud
2020-04-13 11:27 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a129b98-62c4-cc2c-9481-d8b2569512a8@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox