From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.13240.1586777284052043885 for ; Mon, 13 Apr 2020 04:28:04 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C887830E; Mon, 13 Apr 2020 04:28:02 -0700 (PDT) Received: from [10.37.8.50] (unknown [10.37.8.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A39C53F73D; Mon, 13 Apr 2020 04:28:01 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe To: devel@edk2.groups.io, samer@elhajmahmoud.com References: <20200411155611.632-1-samer@elhajmahmoud.com> Cc: Pete Batard , Leif Lindholm From: "Ard Biesheuvel" Message-ID: <8a129b98-62c4-cc2c-9481-d8b2569512a8@arm.com> Date: Mon, 13 Apr 2020 13:27:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200411155611.632-1-samer@elhajmahmoud.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/11/20 5:56 PM, Samer El-Haj-Mahmoud via groups.io wrote: > Switch RaspberryPi from using a private GraphicsConsoleDxe to > the common GraphicsConsoleDxe in MdeModulePkg. > > Samer El-Haj-Mahmoud (3): > Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe > Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe > Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe > Thanks Samer The only thing missing from these patches is setting the following feature PCD in the DSCs somewhere: gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE This is needed because the generic GraphicsConsoleDxe has UGA support as well (which Andrei ripped out for the RPi clone, I suppose), and it is enabled by default, unless you set the PCD to FALSE to disable it. Can you incorporate this into patches 1 and 2, and resend? Thanks.