From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.8600.1589187771798252070 for ; Mon, 11 May 2020 02:02:51 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8373D1FB; Mon, 11 May 2020 02:02:50 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 054BB3F305; Mon, 11 May 2020 02:02:48 -0700 (PDT) Subject: Re: [PATCH edk2-platforms v3 0/5] BCM genet fixes To: devel@edk2.groups.io Cc: Pete Batard , Jared McNeill , Andrei Warkentin , Samer El-Haj-Mahmoud References: <20200511070656.32141-1-ard.biesheuvel@arm.com> From: "Ard Biesheuvel" Message-ID: <8a12bb5b-28f7-1b64-e764-75cfdb2971ef@arm.com> Date: Mon, 11 May 2020 11:02:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200511070656.32141-1-ard.biesheuvel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/11/20 9:06 AM, Ard Biesheuvel wrote: > This fixes the multicast/broadcast/promisc handling, and switches to > ordinary page allocations for RX buffers. Patch #1 is cosmetic only. > > Changes since v2: > - fix MDF filter handling (fixes issue reported by Samer) > - add patch to deal with ExitBootServices() so we don't leave the RX DMA > ring running when we enter the OS > > https://github.com/pftf/edk2-platforms/tree/rpi4_genet_v3_ardb > Apologies for the spam - I ran into another DMA issue with the original contribution, I'll have a v4 out today. > Cc: Pete Batard > Cc: Jared McNeill > Cc: Andrei Warkentin > Cc: Samer El-Haj-Mahmoud > > Ard Biesheuvel (5): > Silicon/Broadcom/BcmGenetDxe: whitespace/cosmetic cleanup > Silicon/Broadcom/BcmGenetDxe: add support for broadcast filtering > Silicon/Broadcom/BcmGenetDxe: fix multicast/broadcast handling > Silicon/Broadcom/BcmGenetDxe: avoid uncached memory for streaming DMA > Silicon/Broadcom/BcmGenetDxe: shut down devices on ExitBootServices() > > .../Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf | 8 + > .../Drivers/Net/BcmGenetDxe/GenetUtil.h | 8 + > .../Drivers/Net/BcmGenetDxe/DriverBinding.c | 38 +- > .../Drivers/Net/BcmGenetDxe/GenetUtil.c | 715 ++++++++++-------- > .../Drivers/Net/BcmGenetDxe/SimpleNetwork.c | 20 +- > 5 files changed, 441 insertions(+), 348 deletions(-) >