From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.7085.1593079301996415359 for ; Thu, 25 Jun 2020 03:01:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CIwK+Gec; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593079301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mi8Y6SeZ2EBr8/FGahMRnJvF7D1QroJboKUBnMs6pgM=; b=CIwK+Gecgg5MsAcNWC3sJYk4DlGNjRA291T5Zi0ffsykSOHrPLNCOL1/fW+j1HE8U9MEJs OIUgpZUdxlV9rOh6IWKUzCVk9foy975x1a9BU6cLmfqN6k0GmTXLfwY6WCfkgYX4jdPP1z cU1YKLvN3++khcy3d28y3TNYKWfJiJc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-TmbjoOfGM4SbWzgc5lsO8g-1; Thu, 25 Jun 2020 06:01:31 -0400 X-MC-Unique: TmbjoOfGM4SbWzgc5lsO8g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC8B1107ACF6; Thu, 25 Jun 2020 10:01:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-16.ams2.redhat.com [10.36.115.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 663517FEA5; Thu, 25 Jun 2020 10:01:29 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools/Conf: Remove C-Code-File.AcpiTable rule To: devel@edk2.groups.io, pierre.gondois@arm.com Cc: bob.c.feng@intel.com, liming.gao@intel.com, nd@arm.com References: <20200625081922.66596-1-pierre.gondois@arm.com> From: "Laszlo Ersek" Message-ID: <8a2134d9-eff9-2e39-02a3-df1211db349c@redhat.com> Date: Thu, 25 Jun 2020 12:01:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200625081922.66596-1-pierre.gondois@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 06/25/20 10:19, PierreGondois wrote: > From: Pierre Gondois > > When trying to build a module with the MODULE_TYPE > set to: > MODULE_TYPE = AcpiTable > > the build fails with the following error: > [ModulePath].inf(-1): error 3001: MODULE_TYPE AcpiTable is > not supported for EDK II, valid values are: > BASE SEC PEI_CORE PEIM DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER > DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION > USER_DEFINED HOST_APPLICATION SMM_CORE MM_STANDALONE > MM_CORE_STANDALONE > > Indeed, the "SUP_MODULE_LIST" variable available in > edk2/BaseTools/Source/Python/Common/DataType.py does not > include any "AcpiTable". > The "C-Code-File.AcpiTable" rule described in > edk2/BaseTools/Conf/build_rule.template might be outdated. > Plus there is no mention of "AcpiTable" module in the > INF specification. > > Signed-off-by: Pierre Gondois > --- > > The changes can be seen at: https://github.com/PierreARM/edk2/commits/831_Remove_C_AcpiTable_build_rule_v1 > > Notes: > v1: > - Remove AcpiTable rule. [Pierre] > > BaseTools/Conf/build_rule.template | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template > index 0822b681fcd9f61c6508e6f93ffc31fa70fd7059..32984eb3f33fd9d110da54975fc90325addb8ecc 100755 > --- a/BaseTools/Conf/build_rule.template > +++ b/BaseTools/Conf/build_rule.template > @@ -437,26 +437,6 @@ > "$(ASL)" $(ASL_FLAGS) $(ASL_OUTFLAGS)${dst} $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iiii > -AmlToHex $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.aml > > -[C-Code-File.AcpiTable] > - > - ?.c > - > - > - $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.acpi > - > - > - $(MAKE_FILE) > - > - > - "$(ASLCC)" $(DEPS_FLAGS) /Fo$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(ASLCC_FLAGS) $(DEPS_FLAGS) $(INC) ${src} > - "$(ASLDLINK)" /OUT:$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj > - "$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(GENFW_FLAGS) > - > - > - "$(ASLCC)" $(DEPS_FLAGS) -c -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS) $(DEPS_FLAGS) $(INC) ${src} > - "$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj > - "$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll $(GENFW_FLAGS) > - > [Acpi-Table-Code-File] > > ?.aslc, ?.act > Should we remove "?.act" from under "Acpi-Table-Code-File", too? Because, if you run "git-blame" on the file, the code being removed comes originally from commit f0373115cc9c ("Add the special build rule for AcpiTable C Source file.", 2008-09-01). And that commit added "?.act" under "Acpi-Table-Code-File". (I don't know if the "?.act" addition in that commit was due to bad patch structuring (i.e., if it was unrelated to AcpiTable modules, and should have been a separate patch), or somehow indeed related to AcpiTable modules. The commit doesn't explain.) Thanks Laszlo