From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (EUR03-AM7-obe.outbound.protection.outlook.com [40.107.105.47]) by mx.groups.io with SMTP id smtpd.web10.50271.1675679700792863884 for ; Mon, 06 Feb 2023 02:35:01 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=PMd8Ezm6; spf=pass (domain: arm.com, ip: 40.107.105.47, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lNzpwXy1yfGY6RKw68n3oF8H4J6tXMzI2rdCGP2Jgco=; b=PMd8Ezm68Q89h/CFSxfoX4O0KX/9S9PYWQykwYM5J3n/SeBzVKaIJua4hpaTKK6fSW54eWBgf6O+BAKWDx6MUfXxhQ/hfbFhy+MbW5mBHwwXQaAOV0R7lC3M7akOwuaUmhavK41ebdRaDllWixaGlg7vKw/ZmnonGJ3n/DrnFiA= Received: from DUZPR01CA0128.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bc::21) by DB4PR08MB9406.eurprd08.prod.outlook.com (2603:10a6:10:3f2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 10:34:57 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4bc:cafe::84) by DUZPR01CA0128.outlook.office365.com (2603:10a6:10:4bc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 10:34:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32 via Frontend Transport; Mon, 6 Feb 2023 10:34:57 +0000 Received: ("Tessian outbound 0d7b2ab0f13d:v132"); Mon, 06 Feb 2023 10:34:57 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0eaf515f2cd76eb9 X-CR-MTA-TID: 64aa7808 Received: from f1c6f8bacbe3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 01524AAE-0824-45B6-9609-9268DD32B22C.1; Mon, 06 Feb 2023 10:34:50 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f1c6f8bacbe3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Feb 2023 10:34:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iNtFO7Lk6sJ5da0roLRI2SMvoxR5cUmTiqTnQ46XRzNrN8Ej7I+dRpMKtolUcFKgDXiM4nCGEla/7IDyKqUGArvpBAg4IMHjvnzcyVawar99Ef/82re3ndrgYvtitl4IOhfz1SqDqAQ7iuLdZnt+8/Uo5+TuQ5ijEO3+WkLiQcpsOuwinxriLhwedyRWITGW8h5y/+imMZ1H3h5eimG8RvA8XxrXrIEAT9aPJhOqhMeX8gPPgu1ablLNky3jAFFVgSovukEYkmRScGG6J78hcIbo8uAA3UA5LSZ+drQlxcNOtGJdk8EJC18ggUnOUJTldeZWIMA7fjDi4vohxk+xFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lNzpwXy1yfGY6RKw68n3oF8H4J6tXMzI2rdCGP2Jgco=; b=OPcMvWF1TQxwPfpIFhotsExwqMYBDMuv+uK8lXNwoPCHw0Ru0hFSN6YIHiqmtaRgq326HIFZ2rcmMjUQEJjjaTmpGYNXciKWm2p+1ln+6wqeGJ/QXXr7GHERgtNRQpPIZVJUw5SFYxOzUe0C12FEABIUqx5tS8IMVWVIPI2+nZNQRLRBUHdRcMseSdPTEcCGEErKmrPMgm0Nb6lLGjlSOQ6+MZLb3sIyrDns49j4KPdCY/sSOTknY9c+OY5EXtx9Dss6b3A42viWkBn3pXZKKVZ/us/3lK8qj6QkIMFz3N7yipNc5v8VsQHQpXPwgKG2PUMk9iv1DytmL593yTcSPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lNzpwXy1yfGY6RKw68n3oF8H4J6tXMzI2rdCGP2Jgco=; b=PMd8Ezm68Q89h/CFSxfoX4O0KX/9S9PYWQykwYM5J3n/SeBzVKaIJua4hpaTKK6fSW54eWBgf6O+BAKWDx6MUfXxhQ/hfbFhy+MbW5mBHwwXQaAOV0R7lC3M7akOwuaUmhavK41ebdRaDllWixaGlg7vKw/ZmnonGJ3n/DrnFiA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAVPR08MB9435.eurprd08.prod.outlook.com (2603:10a6:102:317::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 10:34:48 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::22bf:7afd:6f9a:9066]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::22bf:7afd:6f9a:9066%5]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 10:34:48 +0000 Message-ID: <8a23858d-8772-bf07-ab8e-4141669403b2@arm.com> Date: Mon, 6 Feb 2023 10:34:46 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] MdePkg:IORT header update for IORT Rev E.e spec To: Name , devel@edk2.groups.io, Alexei.Fedorov@arm.com, pierre.gondois@arm.com, michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com Cc: Swatisri Kantamsetti , "nd@arm.com" References: <13bc39429583f0129b2935970df6489191004ad2.1674671138.git.swatisrik@nvidia.com> From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO6P265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::11) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAVPR08MB9435:EE_|DBAEUR03FT043:EE_|DB4PR08MB9406:EE_ X-MS-Office365-Filtering-Correlation-Id: 25756cfa-e954-4a76-e2f4-08db082dcaca x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YfbZLWHRqu6SsGob+iak4kiA2/t4MkskpuRWwTr/octALFN+1jHQ7ev+yMuW7ibHjt4a4IN2SIFsPMiIzrgTCZSY/aVF0RktaRpvEwXeRX6Lcb66Bjcr0aO9dz8T2yhqUUH9ZpHLOC2NyJe9GsuG8y8I2x+meVduZchMuPMYbUPaBySCL+idPs5jtc++iIHIFSVSNSc4ki0bfDSHwUZ7MO7L9/xSNvMmyI7dV+ggM+CeMjGcEO5jTCGKsdK6VuPXC60Jfqcd1TQLRkwzfsqWwKtJ5dkSR+SpYdlfFkFa1fLKKA3VCSD2eH1EQzenfURMRzkoVVXrwQSaLxJHXLBIhNKnXQTWGBGIjnOly2JCIM7iqbk7YhayvwHOsfkHsgMTcXlWjGS++dGZN3q91TQvF6M0/xxQuQP6vI1cpcEDdVn3PwiDpkdJF78rJ7CNBEolWml3iqic7SetXMnFokCgkm8QJGaPd1ic9iKzYuyaQWt5lr/MyunaV6N4VXGqW7vCks3v3RX3xx6SigWMpKYHKau6Y/nuR3l+1g4jxGKGW+QnP740/MHGeoPYhn/4OE6hsSfHEolejey/ecjzBLAgjJ2wjGP7I6Zz7ogmChMFsJNTwSfSHRh+vfjVxj5I8ZQQyi25EFmcHeY45Yhm5RG/t8Xz3rJLqYxasS6T3KJjl78Fh5Rja0I8/QrFLH5k3M0HkG2LXssuflmBTJsLkQ1gjfzXrtZuStuYSKdv9J107OAzbMqT3I+mdPrCSZwXjfArJAVAZtiXiJ2CGm7PCDDMnzCG6grthP4ywTnGGYq9+XfvwS28NSvbt7HscEIQe5Fs X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(376002)(346002)(366004)(396003)(451199018)(86362001)(83380400001)(4326008)(8676002)(316002)(54906003)(41300700001)(8936002)(66556008)(66476007)(66946007)(6506007)(2616005)(53546011)(186003)(26005)(6512007)(6486002)(478600001)(31696002)(36756003)(44832011)(2906002)(15650500001)(5660300002)(38100700002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9435 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d9cbc0c9-0ae5-42c7-aa13-08db082dc526 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l2IXuABkYzkuOfqmKg/gOiKypx7NWtrbYJKifkJ1BmOXHxE2JwQUdaE+WmX/fzasO/eWBFWQMZYJygGEUsM6foJVC9DhhMAckb6gI219Ao9VrCqybvHpgtiKnVkR/PxfSxafhJfWwAkDVeNYZSYqx3bFurxM1tQM9Ufe3l4qmIZ8blUtqyxVTSacUilPCK9kTDz6ODoWVlbJ9y5s3sF/HqPHTfqZCwNdgxEOXBD5GSr9W1JnYsWI5cR59pn0Ro2pXQCWJXT9j2pXrlxZzhOjnMKv76VktkOLgC2Fe71XbwBWK0pReQKwsIercuSAYfR7qrmbeNFIqh2M2HGpphuRoAHMVOhSn0j8AyRppA/hs4THTbJMhj6SHf9r8iKHphheMKVzBHf7f4DNWHQJFvRw9bwYTTQCNK0M6QPGPg0HgaM8Gbo8euvjVaP/ZhR6Dh3bcIdkZVe0Vuyf14D1UWVXJnVCK7HqDSFlBXvHE13eS4BCkPfhsQp2iLrVCJCUOFrkG7Cg+B2ut7icwlZ0Cc+aFnSAEaGIG5P/o26H2wGXTnB/GhNE2JVvgrJgDe9YcgKLki5OSKm/oYsH2mxaNED2LEzOVfYyUUGGdd3faF4giU3U2qORFKZEGeZBwzJ/6EkxANtUUq4EgheMiZjvirkijKkxObyeSLSpaf2alCJ20pGxsc/Ol0YPaJSiHgS3sk8u8h5KKyI85bcinjnvAX+sjoNjXBQH6qa9WtPXwEcL1wtCwm1a0MnKkq3n8CsaatLzOvS8iYF5Y1H7LjGcC5CvtQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199018)(46966006)(36840700001)(478600001)(6486002)(26005)(186003)(6512007)(2616005)(53546011)(5660300002)(40480700001)(41300700001)(8936002)(336012)(6506007)(31686004)(316002)(54906003)(356005)(4326008)(8676002)(70206006)(70586007)(83380400001)(36860700001)(47076005)(82740400003)(31696002)(82310400005)(81166007)(86362001)(44832011)(2906002)(36756003)(15650500001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 10:34:57.1901 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25756cfa-e954-4a76-e2f4-08db082dcaca X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9406 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Swatisri, Thank you for this patch. This patch must be 1/2 to prevent git bisect from failing. Otherwise these changes look good to me. With that addressed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 25/01/2023 06:40 pm, Name wrote: > From: Swatisri Kantamsetti > > The IO Remapping Table, Platform Design Document, Revision E.e, > Sept 2022 (https://developer.arm.com/documentation/den0049/ee) > added flags in SMMUv3 node for validity of ID mappings for MSIs > related to control interrupts. > > Therefore, update the IORT header file to: > - increment IORT table revision to 6 > - add support for DeviceId valid flag > > Signed-off-by: Swatisri Kantamsetti > --- > MdePkg/Include/IndustryStandard/IoRemappingTable.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/IoRemappingTable.h b/MdePkg/Include/IndustryStandard/IoRemappingTable.h > index f48a4a95cd..544aa67a05 100644 > --- a/MdePkg/Include/IndustryStandard/IoRemappingTable.h > +++ b/MdePkg/Include/IndustryStandard/IoRemappingTable.h > @@ -9,6 +9,8 @@ > @par Reference(s): > - IO Remapping Table, Platform Design Document, Revision E.d, Feb 2022 > (https://developer.arm.com/documentation/den0049/) > + - IO Remapping Table, Platform Design Document, Revision E.e, Sept 2022 > + (https://developer.arm.com/documentation/den0049/) > > @par Glossary: > - Ref : Reference > @@ -24,6 +26,7 @@ > #define EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 0x0 > #define EFI_ACPI_IO_REMAPPING_TABLE_REVISION_04 0x4 // Deprecated > #define EFI_ACPI_IO_REMAPPING_TABLE_REVISION_05 0x5 > +#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION_06 0x6 > > #define EFI_ACPI_IORT_TYPE_ITS_GROUP 0x0 > #define EFI_ACPI_IORT_TYPE_NAMED_COMP 0x1 > @@ -59,6 +62,7 @@ > #define EFI_ACPI_IORT_SMMUv3_FLAG_COHAC_OVERRIDE BIT0 > #define EFI_ACPI_IORT_SMMUv3_FLAG_HTTU_OVERRIDE BIT1 > #define EFI_ACPI_IORT_SMMUv3_FLAG_PROXIMITY_DOMAIN BIT3 > +#define EFI_ACPI_IORT_SMMUv3_FLAG_DEVICEID_VALID BIT4 > > #define EFI_ACPI_IORT_SMMUv3_MODEL_GENERIC 0x0 > #define EFI_ACPI_IORT_SMMUv3_MODEL_HISILICON_HI161X 0x1