Re: [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt

["Rebecca Cran" <rebecca@bsdio.com>]

Could I have some reviews of this v2 patch please?


Thanks.

Rebecca Cran


On 5/3/22 14:07, Rebecca Cran wrote:
> The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using
> the console difficult, for example when using the UiApp.
>
> Since the extra output should no longer be needed, delete the DEBUG
> lines.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>   ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c | 12 ------------
>   1 file changed, 12 deletions(-)
>
> diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
> index 01ec6f68bd93..013506976f91 100644
> --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
> +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
> @@ -815,18 +815,6 @@ LcdGraphicsBlt (
>     HorizontalResolution = This->Mode->Info->HorizontalResolution;
>     VerticalResolution   = This->Mode->Info->VerticalResolution;
>   
> -  DEBUG ((
> -    DEBUG_INFO,
> -    "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n",
> -    BltOperation,
> -    DestinationX,
> -    DestinationY,
> -    Width,
> -    Height,
> -    HorizontalResolution,
> -    VerticalResolution
> -    ));
> -
>     // Check we have reasonable parameters
>     if ((Width == 0) || (Height == 0)) {
>       DEBUG ((DEBUG_ERROR, "LcdGraphicsBlt: ERROR - Invalid dimension: Zero size area.\n"));