From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web12.305.1652718086689491658 for ; Mon, 16 May 2022 09:21:27 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=dpgDKbzQ; spf=pass (domain: bsdio.com, ip: 66.111.4.29, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id F09DB5C0533; Mon, 16 May 2022 12:07:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 16 May 2022 12:07:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1652717225; x= 1652803625; bh=UUkB+Vmg7QGiYI/09C5+Jmdt7lyxZ18fhe099vvth8A=; b=d pgDKbzQNadlrIdbc3MR29UY4XaIp4V5zxBhnOqlUFofvLtWPduM74yLIluR6WY69 2VOZ+Q1q9aW8mi95M6WbAF455vIMeSBeP0FBcGHivVjYATKQhiPkgS3t32FkYIL1 GRZ5UqX7s4L39JeNujbmjOGdkRR+H74qmEoQ4DYuDW1YLJcy9IdJWRhtGbOHwumn XSKPm7mITOLkvcaRZgaxAxv+QMMU+YyF8mTzM3CjRtI5z4VhXHcAL52jF+0vMDDn zGW3WOca7z9OHierNMEKr+U7O3572sD33oFsbyhAhILEdesMKgnywU1dE4se4xUN G0cLXWnBlA7Y1z/u/3GXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1652717225; x=1652803625; bh=UUkB+Vmg7QGiYI/09C5+Jmdt7lyx Z18fhe099vvth8A=; b=zbYm6ih0walEsxVuVeAzAoJWdYXrz+cG3tkjnj+0x7mz PjidfNvss1pJzr/hd8xmjFsJCzaxF0yu7Hvy3FgCFourdzyjizFA1u431DoLSgIz EtWEz62pkF/J5epZpB1BYnhcrqMkW/7dKd2rCFGPF6jLFRkXyJTNIVVK02whwIF4 B7EyPpW8CVTYnJ9cWvOSoihw6VyKfmGqG2Q6OXCRkkk3u3lYAwKf3fT/nnQrlske xF7+gbkX3+AB8WmC+YHrK0rBnPTIHjFM2m9nibxChVzK6KbcSZAIQu54iMUe43aQ gU09hRvxLA6+WQJ12RwoCU8ZskyG7Xjp7S2J0ECdCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheehgdelhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvfhfhjggtgfesthejre dttdefjeenucfhrhhomheptfgvsggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghs ughiohdrtghomheqnecuggftrfgrthhtvghrnhepleduvedtledtvedvuedugeeuudeiie dtueduvdffueekfeejffduvdetjeevffdvnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 16 May 2022 12:07:04 -0400 (EDT) Message-ID: <8a41e4e2-d929-49bc-f3ad-495ee61f395f@bsdio.com> Date: Mon, 16 May 2022 10:07:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt To: devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel References: <20220503200756.11664-1-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: <20220503200756.11664-1-rebecca@bsdio.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Could I have some reviews of this v2 patch please? Thanks. Rebecca Cran On 5/3/22 14:07, Rebecca Cran wrote: > The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using > the console difficult, for example when using the UiApp. > > Since the extra output should no longer be needed, delete the DEBUG > lines. > > Signed-off-by: Rebecca Cran > --- > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c > index 01ec6f68bd93..013506976f91 100644 > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c > @@ -815,18 +815,6 @@ LcdGraphicsBlt ( > HorizontalResolution = This->Mode->Info->HorizontalResolution; > VerticalResolution = This->Mode->Info->VerticalResolution; > > - DEBUG (( > - DEBUG_INFO, > - "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n", > - BltOperation, > - DestinationX, > - DestinationY, > - Width, > - Height, > - HorizontalResolution, > - VerticalResolution > - )); > - > // Check we have reasonable parameters > if ((Width == 0) || (Height == 0)) { > DEBUG ((DEBUG_ERROR, "LcdGraphicsBlt: ERROR - Invalid dimension: Zero size area.\n"));