* [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt
@ 2022-05-03 20:07 Rebecca Cran
2022-05-16 16:07 ` Rebecca Cran
2022-05-16 16:26 ` [edk2-devel] " Sami Mujawar
0 siblings, 2 replies; 5+ messages in thread
From: Rebecca Cran @ 2022-05-03 20:07 UTC (permalink / raw)
To: devel, Leif Lindholm, Ard Biesheuvel; +Cc: Rebecca Cran
The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using
the console difficult, for example when using the UiApp.
Since the extra output should no longer be needed, delete the DEBUG
lines.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
index 01ec6f68bd93..013506976f91 100644
--- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
+++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
@@ -815,18 +815,6 @@ LcdGraphicsBlt (
HorizontalResolution = This->Mode->Info->HorizontalResolution;
VerticalResolution = This->Mode->Info->VerticalResolution;
- DEBUG ((
- DEBUG_INFO,
- "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n",
- BltOperation,
- DestinationX,
- DestinationY,
- Width,
- Height,
- HorizontalResolution,
- VerticalResolution
- ));
-
// Check we have reasonable parameters
if ((Width == 0) || (Height == 0)) {
DEBUG ((DEBUG_ERROR, "LcdGraphicsBlt: ERROR - Invalid dimension: Zero size area.\n"));
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt
2022-05-03 20:07 [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt Rebecca Cran
@ 2022-05-16 16:07 ` Rebecca Cran
2022-05-16 16:26 ` [edk2-devel] " Sami Mujawar
1 sibling, 0 replies; 5+ messages in thread
From: Rebecca Cran @ 2022-05-16 16:07 UTC (permalink / raw)
To: devel, Leif Lindholm, Ard Biesheuvel
Could I have some reviews of this v2 patch please?
Thanks.
Rebecca Cran
On 5/3/22 14:07, Rebecca Cran wrote:
> The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using
> the console difficult, for example when using the UiApp.
>
> Since the extra output should no longer be needed, delete the DEBUG
> lines.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
> index 01ec6f68bd93..013506976f91 100644
> --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
> +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c
> @@ -815,18 +815,6 @@ LcdGraphicsBlt (
> HorizontalResolution = This->Mode->Info->HorizontalResolution;
> VerticalResolution = This->Mode->Info->VerticalResolution;
>
> - DEBUG ((
> - DEBUG_INFO,
> - "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n",
> - BltOperation,
> - DestinationX,
> - DestinationY,
> - Width,
> - Height,
> - HorizontalResolution,
> - VerticalResolution
> - ));
> -
> // Check we have reasonable parameters
> if ((Width == 0) || (Height == 0)) {
> DEBUG ((DEBUG_ERROR, "LcdGraphicsBlt: ERROR - Invalid dimension: Zero size area.\n"));
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [edk2-devel] [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt
2022-05-03 20:07 [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt Rebecca Cran
2022-05-16 16:07 ` Rebecca Cran
@ 2022-05-16 16:26 ` Sami Mujawar
2022-06-18 2:45 ` Rebecca Cran
1 sibling, 1 reply; 5+ messages in thread
From: Sami Mujawar @ 2022-05-16 16:26 UTC (permalink / raw)
To: Rebecca Cran, devel
[-- Attachment #1: Type: text/plain, Size: 154 bytes --]
Hi Rebecca,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 196 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt
2022-05-16 16:26 ` [edk2-devel] " Sami Mujawar
@ 2022-06-18 2:45 ` Rebecca Cran
2022-06-22 14:58 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Rebecca Cran @ 2022-06-18 2:45 UTC (permalink / raw)
To: Sami Mujawar, devel, Leif Lindholm, Ard Biesheuvel
It looks like this hasn't been pushed. Could someone commit/push it please?
--
Rebecca Cran
On 5/16/22 10:26, Sami Mujawar wrote:
> Hi Rebecca,
>
> Thank you for this patch.
> These changes look good to me.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt
2022-06-18 2:45 ` Rebecca Cran
@ 2022-06-22 14:58 ` Ard Biesheuvel
0 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2022-06-22 14:58 UTC (permalink / raw)
To: edk2-devel-groups-io, Rebecca Cran
Cc: Sami Mujawar, Leif Lindholm, Ard Biesheuvel
On Sat, 18 Jun 2022 at 04:45, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> It looks like this hasn't been pushed. Could someone commit/push it please?
>
Merged as #2999
>
> --
>
> Rebecca Cran
>
>
> On 5/16/22 10:26, Sami Mujawar wrote:
> > Hi Rebecca,
> >
> > Thank you for this patch.
> > These changes look good to me.
> >
> > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> >
> > Regards,
> >
> > Sami Mujawar
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-22 14:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-03 20:07 [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt Rebecca Cran
2022-05-16 16:07 ` Rebecca Cran
2022-05-16 16:26 ` [edk2-devel] " Sami Mujawar
2022-06-18 2:45 ` Rebecca Cran
2022-06-22 14:58 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox