From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81])
 by mx.groups.io with SMTP id smtpd.web12.11035.1593785328544547085
 for <devel@edk2.groups.io>;
 Fri, 03 Jul 2020 07:08:48 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ToVzzykJ;
 spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1593785327;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GRnkvaFlkfX7e/7uJFHCROj+jkvmEopgnYQ0qnw8k20=;
	b=ToVzzykJIIxRcZuusl57JeWPXVmXxAPdBbjCOXIkwa7FzoaXB0Ewhkmm1sHsCdrvxf2Hog
	tzf9iYUNS+IIz5Z1hCDJBBrutaODJ3NhJzKwsJK32EFTimP9ka5Gq/2TJmyHetsX7FsbeF
	Hpzbe2PyryRKF+hCIYMsBK39C4oeq4M=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-261-cTwWWZFMPX-U4_MBiR3w6A-1; Fri, 03 Jul 2020 10:08:44 -0400
X-MC-Unique: cTwWWZFMPX-U4_MBiR3w6A-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 03FCCBFC0;
	Fri,  3 Jul 2020 14:08:43 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-238.ams2.redhat.com [10.36.114.238])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 1644E7167C;
	Fri,  3 Jul 2020 14:08:41 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 00/11] Introduce LsiScsi driver to OvmfPkg
To: devel@edk2.groups.io, glin@suse.com
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>
References: <20200701040448.14871-1-glin@suse.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <8a64fff1-7d34-fd03-3faa-7f9cc90eac32@redhat.com>
Date: Fri, 3 Jul 2020 16:08:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200701040448.14871-1-glin@suse.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi Gary,

On 07/01/20 06:04, Gary Lin wrote:
> This patch series implement the driver for LSI 53C895A SCSI controller
> for OVMF so that the user can access the storage devices connected to
> QEMU "lsi" controller. The driver is disabled by default since LSI
> 53C895A is considered as a legacy device. To enable the driver, please
> add "-D LSI_SCSI_ENABLE" when building OvmfPkg.
> 
> The patch series is also available in my git branch:
> https://github.com/lcp/edk2/tree/ovmf-lsi-v1
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>

I've queued your series for review; please give me some time to get to
it. I hope I can review the patches next week.

Thanks
Laszlo

> 
> Gary Lin (11):
>   OvmfPkg/LsiScsiDxe: Create the empty driver
>   OvmfPkg/LsiScsiDxe: Install the skeleton of driver binding
>   OvmfPkg/LsiScsiDxe: Report the name of the driver
>   OvmfPkg/LsiScsiDxe: Probe PCI devices and look for LsiScsi
>   OvmfPkg/LsiScsiDxe: Install stubbed EXT_SCSI_PASS_THRU
>   OvmfPkg/LsiScsiDxe: Report Targets and LUNs
>   OvmfPkg/LsiScsiDxe: Open PciIo protocol and initialize the device
>   OvmfPkg/LsiScsiDxe: Map DMA buffer
>   OvmfPkg/LsiScsiDxe: Examine the incoming SCSI Request Packet
>   OvmfPkg/LsiScsiDxe: Process the SCSI Request Packet
>   Maintainers.txt: Add myself as the reviewer for LsiScsi driver
> 
>  Maintainers.txt                            |    4 +
>  OvmfPkg/Include/IndustryStandard/LsiScsi.h |   80 ++
>  OvmfPkg/LsiScsiDxe/LsiScsi.c               | 1130 ++++++++++++++++++++
>  OvmfPkg/LsiScsiDxe/LsiScsi.h               |  199 ++++
>  OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf          |   46 +
>  OvmfPkg/OvmfPkg.dec                        |    8 +
>  OvmfPkg/OvmfPkgIa32.dsc                    |    4 +
>  OvmfPkg/OvmfPkgIa32.fdf                    |    3 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                 |    4 +
>  OvmfPkg/OvmfPkgIa32X64.fdf                 |    3 +
>  OvmfPkg/OvmfPkgX64.dsc                     |    4 +
>  OvmfPkg/OvmfPkgX64.fdf                     |    3 +
>  12 files changed, 1488 insertions(+)
>  create mode 100644 OvmfPkg/Include/IndustryStandard/LsiScsi.h
>  create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsi.c
>  create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsi.h
>  create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
>