From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.groups.io (mail03.groups.io [45.79.227.220]) by spool.mail.gandi.net (Postfix) with ESMTPS id D2C8A941286 for ; Fri, 12 Apr 2024 08:32:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hKyCxKce47WSYv9YByKZBsXxWj1nPEiqbw337nlCqB8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1712910720; v=1; b=r6jsPzmvpQa+YcjpLkPa6szmOaxVW5kNq5/jHCw8rS5ywBK5TNuVP3Mmvk0bFB2XEx2llWYF QcaPPtdLbD/Verqz3U3zkP94V/m1byx2nLzG/rHELa0LTRwLVSKj/saZsXrPQ+Apwyvjnu49JsX xs6sVTJ6n6lqzMZsUnJIgn6mo0/3O9F7wwgTZFcUaBw70r4jhJPPUfoOPHLnxhI5PIi5BaElILY BHLlwGGYpRG9py/c3aGe3ELjIUiMsC6YxhgpVxLKEgziWN9faXBAzmgo23ErQP2YB9V+1itPu3q abo7+HmJXGftxGNml7rIdqmiu+mTiPqxdGf6UMIo0nLSg== X-Received: by 127.0.0.2 with SMTP id HfNrYY7687511xRAffAfZ45j; Fri, 12 Apr 2024 01:32:00 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mx.groups.io with SMTP id smtpd.web10.42254.1712910714532748777 for ; Fri, 12 Apr 2024 01:31:54 -0700 X-CSE-ConnectionGUID: VVLiis36SaG+ResKT0LCNA== X-CSE-MsgGUID: KX73T4M6QM6qRTVQ03ijXw== X-IronPort-AV: E=McAfee;i="6600,9927,11041"; a="18965192" X-IronPort-AV: E=Sophos;i="6.07,195,1708416000"; d="scan'208";a="18965192" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2024 01:31:45 -0700 X-CSE-ConnectionGUID: ubP70J2HQAeErtfoRBQNTA== X-CSE-MsgGUID: LnQkzGODTBWor45cVSrYwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,195,1708416000"; d="scan'208";a="58594585" X-Received: from cindykux-mobl.gar.corp.intel.com ([10.225.33.115]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2024 01:31:40 -0700 From: "Cindy Kuo" To: devel@edk2.groups.io Cc: Cindy Kuo , Jiewen Yao , Rahul Kumar , Dandan Bi , Ming Tan , Arthur Chen , Xiao X Chen , Tina Chen Subject: [edk2-devel] [PATCH v4 0/1] SecurityPkg/OpalPasswordDxe: Update UI according to UEFI spec Date: Fri, 12 Apr 2024 16:31:29 +0800 Message-ID: <8a6534ad58af4caf89d7d11725ab15fdcb1e424e.1712910291.git.cindyx.kuo@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 12 Apr 2024 01:31:54 -0700 Resent-From: cindyx.kuo@intel.com Reply-To: devel@edk2.groups.io,cindyx.kuo@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: CE05o08bHL2LCnYWVQvzFwlLx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=r6jsPzmv; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.227.220 as permitted sender) smtp.mailfrom=bounce@groups.io REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4735 Should not call HiiGetBrowserData() and HiiSetBrowserData() in FORM_OPEN call back function. Those APIs are called within OpalHiiSetBrowserData/OpalHiiGetBrowserData which have been used by OpalHii.c. Change callback action from FORM_OPEN to RETRIEVE. Cc: Jiewen Yao Cc: Rahul Kumar Cc: Dandan Bi Cc: Ming Tan Cc: Arthur Chen Cc: Xiao X Chen Cc: Tina Chen Signed-off-by: CindyX Kuo --- SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c index 8035f44ebe..56ada1a9f3 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c @@ -632,7 +632,7 @@ DriverCallback ( HiiKey.Raw = QuestionId; HiiKeyId = (UINT8)HiiKey.KeyBits.Id; - if (Action == EFI_BROWSER_ACTION_FORM_OPEN) { + if (Action == EFI_BROWSER_ACTION_RETRIEVE) { switch (HiiKeyId) { case HII_KEY_ID_VAR_SUPPORTED_DISKS: DEBUG ((DEBUG_INFO, "HII_KEY_ID_VAR_SUPPORTED_DISKS\n")); -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117661): https://edk2.groups.io/g/devel/message/117661 Mute This Topic: https://groups.io/mt/105478921/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-