From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.63]) by mx.groups.io with SMTP id smtpd.web10.10355.1676448113796651034 for ; Wed, 15 Feb 2023 00:01:53 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=LEoAdN4K; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.63, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jyvbJhs1IRvipAzjZr4v0LvPlvDpSc0tzXU2yBLBDyjYb4A2xv9rzo9PJ1yJ7XVs3a36sRgNmfZXZhNtgeo9LylQLgEgC0AX8jHErGksgbqMi+NFChbmlRjEAId56ZyA1p+SaUcJbsna1M+cVoVYrn12PLogD5op05hxej5pe1IyreBhIoWPJfUcaqeX9kgFmFn7+5nMbpVAuFlY5V/rnTlHZ16PwN41E04seknHDGC9KhDV693SwXH2CwLPrWDrHD4UV1a4BpULISHGaBrFYeFrd+KpV+HMxC+0bccCYKotrEl3T1f1/rohgi3kkhDlVEfDIDoNLAHHdsSE9h8iNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NQ28MGTe3ingUiujkfmGDSHjOh++SAyJufLSh/vAThc=; b=AqH5pIpLF6x9UO98zQFY8Ald4/alOz01SafR2LVh8Y+EAVWA2td8xN27RTvLxfw2cTVsjPEUxM9yVfdYy9BWOOAg2iRnM2vp0hbs7xpAzftatphvrv7zIgXdldqfP2fAeC/mSIB56Yd1IDMMNkAvG5OfigsclmEYyQeoW8Xfri15enKKfgvXYqV1MMYf/XM1ItlktydI9upGVUt0ctW2FDofD6+3upcTYYq4B65N6vuGlnAmRMv5wn4WMPLXI0yL4ARxMZwRoj5H3s/su1RcNvwB7TM3KZDViAR3ync+P3ciEXwf57bI+YjivGXAxBBajJfHpMC52YOzHalRYOtOOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQ28MGTe3ingUiujkfmGDSHjOh++SAyJufLSh/vAThc=; b=LEoAdN4K3uUGYQ8bDRyeuRqTc78mjZyZiIbKICKXrJqrv5oBAxBw+TuzXq2TfzSvZqkF9meXzkl+DnPC1pJGSyf29QLBA0Ltd8HbBRwTpcFuFyTUhIJrOX7/eDr+bqEHjxb3uXdc6lNaOaLMYXYRfPJQy5itFloOZxDCfuulQx0= Received: from DS7PR03CA0284.namprd03.prod.outlook.com (2603:10b6:5:3ad::19) by DM4PR12MB5232.namprd12.prod.outlook.com (2603:10b6:5:39c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 08:01:51 +0000 Received: from DM6NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3ad:cafe::cf) by DS7PR03CA0284.outlook.office365.com (2603:10b6:5:3ad::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26 via Frontend Transport; Wed, 15 Feb 2023 08:01:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT011.mail.protection.outlook.com (10.13.172.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.12 via Frontend Transport; Wed, 15 Feb 2023 08:01:51 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 15 Feb 2023 02:01:49 -0600 Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 15 Feb 2023 02:01:47 -0600 From: "Abdul Lateef Attar" To: CC: Paul Grimes , Garrett Kirkendall , Abner Chang , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann Subject: [PATCH v5 2/6] UefiCpuPkg: Adds SmmSmramSaveStateLib library class Date: Wed, 15 Feb 2023 13:31:39 +0530 Message-ID: <8a65c7d913cc013bc647a385bc753df8b73192e7.1676447938.git.abdattar@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Return-Path: AbdulLateef.Attar@amd.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT011:EE_|DM4PR12MB5232:EE_ X-MS-Office365-Filtering-Correlation-Id: afaad80c-9f30-4780-40dc-08db0f2ae56a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0IlOW/qJfSYQda9KqPO+EHAX6lTYDDA3OhAXLxwSiCD07r6x3LluJtv8GhraTHH+JCO7sYivArDqqO/M+iAfpz+/Ozy3GgpnmvVaDwYC34eT8X+gMyFMq05EHxzigOOxZY/B4cNuQhB9wwBfN9HJNdBkeEekA5s8cBDDKVkgEZrM4vdbJpTGxQvfmTDPh2jZygp1TQZpXUDRiUP9ug5ZbkJgDnfsqqeVc47/hUmdGo4klDIoI2eVmMsz7dAYDd2e2MikyfTgZ2MSUoU01G7E4p/rc0hS9LbSNCEhjKC05AC4JjbdcKoP7sutM85mQEWCuXw+DyilcsI7OoZYnTtlGsOCyes2xfMd484FFxsPQHCU8ehmWMdWWuxtz9yVAIRl+EKWnaEpRERCJ7dMR92UCFvoArXBBpx246rpIEQQWu7Pj08OL2WXb0IHFYgtasRVWbb9jkHevDCGHxPY88QSg7wWrgmq35lmA9z8x/6D1vdWqASkcvU2oYyNOFlMkrr5bt0ndvQxirTlTmFXo45ovackHU2p5HZd0/1GU8qzMQmPW8tKZIMPY0+RjLJeC8TVQzC5jF3wHWhqRSTtFJSHd2VFehEziBQaofUplnrfqtSJNjyQYPAltM1hZN4+hWukVKUqY254KteA6QjOl76SGXX49/Su+vibkMnktfvk+hfr6xgF2UXKbuk1ohhzqfrEBvc+zxO2gv3MmIfyIFsprJx9ZrxJ96Mu/zMWWQGqOzV9emfSO9cxxwO2Tgtuuh8D X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199018)(40470700004)(46966006)(36840700001)(8936002)(41300700001)(356005)(5660300002)(82740400003)(6916009)(8676002)(4326008)(2906002)(81166007)(70206006)(82310400005)(70586007)(36860700001)(40480700001)(316002)(966005)(336012)(2616005)(478600001)(426003)(54906003)(40460700003)(6666004)(7696005)(36756003)(47076005)(26005)(186003)(213903007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 08:01:51.4264 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afaad80c-9f30-4780-40dc-08db0f2ae56a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5232 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4182 Adds SmmSmramSaveStateLib Library class in UefiCpuPkg.dec. Adds function declaration header file. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul Lateef Attar Reviewed-by: Abner Chang --- UefiCpuPkg/UefiCpuPkg.dec | 4 ++ .../Include/Library/SmmSmramSaveStateLib.h | 70 +++++++++++++++++++ 2 files changed, 74 insertions(+) create mode 100644 UefiCpuPkg/Include/Library/SmmSmramSaveStateLib.h diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec index cff239d5283e..1de90b677828 100644 --- a/UefiCpuPkg/UefiCpuPkg.dec +++ b/UefiCpuPkg/UefiCpuPkg.dec @@ -2,6 +2,7 @@ # This Package provides UEFI compatible CPU modules and libraries. # # Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -65,6 +66,9 @@ [LibraryClasses.IA32, LibraryClasses.X64] ## @libraryclass Provides function for manipulating x86 paging structu= res. CpuPageTableLib|Include/Library/CpuPageTableLib.h =20 + ## @libraryclass Provides functions for manipulating Smram savestate r= egisters. + SmmSmramSaveSateLib|Include/Library/SmmSmramSaveStateLib.h + [Guids] gUefiCpuPkgTokenSpaceGuid =3D { 0xac05bf33, 0x995a, 0x4ed4, { 0xaa,= 0xb8, 0xef, 0x7a, 0xe8, 0xf, 0x5c, 0xb0 }} gMsegSmramGuid =3D { 0x5802bce4, 0xeeee, 0x4e33, { 0xa1,= 0x30, 0xeb, 0xad, 0x27, 0xf0, 0xe4, 0x39 }} diff --git a/UefiCpuPkg/Include/Library/SmmSmramSaveStateLib.h b/UefiCpuPkg= /Include/Library/SmmSmramSaveStateLib.h new file mode 100644 index 000000000000..46bc6381bcde --- /dev/null +++ b/UefiCpuPkg/Include/Library/SmmSmramSaveStateLib.h @@ -0,0 +1,70 @@ +/** @file +Library that provides service to read/write CPU specific smram save state = registers. + +Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
+Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+ +SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef SMM_SMRAM_SAVE_STATE_LIB_H_ +#define SMM_SMRAM_SAVE_STATE_LIB_H_ + +#include +#include + +/** + Read an SMM Save State register on the target processor. If this functi= on + returns EFI_UNSUPPORTED, then the caller is responsible for reading the + SMM Save Sate register. + + @param[in] CpuIndex The index of the CPU to read the SMM Save State. = The + value must be between 0 and the NumberOfCpus field= in + the System Management System Table (SMST). + @param[in] Register The SMM Save State register to read. + @param[in] Width The number of bytes to read from the CPU save stat= e. + @param[out] Buffer Upon return, this holds the CPU register value rea= d + from the save state. + + @retval EFI_SUCCESS The register was read from Save State. + @retval EFI_INVALID_PARAMTER Buffer is NULL. + @retval EFI_UNSUPPORTED This function does not support reading Reg= ister. + @retval EFI_NOT_FOUND If desired Register not found. +**/ +EFI_STATUS +EFIAPI +SmramSaveStateReadRegister ( + IN UINTN CpuIndex, + IN EFI_SMM_SAVE_STATE_REGISTER Register, + IN UINTN Width, + OUT VOID *Buffer + ); + +/** + Writes an SMM Save State register on the target processor. If this func= tion + returns EFI_UNSUPPORTED, then the caller is responsible for writing the + SMM Save Sate register. + + @param[in] CpuIndex The index of the CPU to write the SMM Save State. = The + value must be between 0 and the NumberOfCpus field = in + the System Management System Table (SMST). + @param[in] Register The SMM Save State register to write. + @param[in] Width The number of bytes to write to the CPU save state. + @param[in] Buffer Upon entry, this holds the new CPU register value. + + @retval EFI_SUCCESS The register was written to Save State. + @retval EFI_INVALID_PARAMTER Buffer is NULL. + @retval EFI_UNSUPPORTED This function does not support writing Reg= ister. + @retval EFI_NOT_FOUND If desired Register not found. +**/ +EFI_STATUS +EFIAPI +SmramSaveStateWriteRegister ( + IN UINTN CpuIndex, + IN EFI_SMM_SAVE_STATE_REGISTER Register, + IN UINTN Width, + IN CONST VOID *Buffer + ); + +#endif --=20 2.25.1