From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0064.outbound.protection.outlook.com [104.47.37.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9307D21D491B2 for ; Wed, 2 Aug 2017 04:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9zlvRM4k+laMGyk3icugukXV+jl0eNF9CYRjcmKB9Rk=; b=XJ2hKf3dCWGLhOknKpgWQ9ZxccquLSxK3Agyu1qnoVQvR4ByFgNF2mKPY0LcBHzzzsqIaz7nzhl8D0a9awGUNsYN7Nh6qXkTXgolJK4kVJFJ2WpqOsDCj445QhtIGaptczc+gKU5KptF0DaXgLFjcxM5Xs6HgVM4EulvX5w6kY4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from wsp094023wss.amd.com (165.204.77.1) by CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.22; Wed, 2 Aug 2017 11:23:05 +0000 Cc: brijesh.singh@amd.com, Tom Lendacky , Jordan Justen , Ard Biesheuvel To: Laszlo Ersek , edk2-devel@lists.01.org References: <1501529474-20550-1-git-send-email-brijesh.singh@amd.com> <1501529474-20550-4-git-send-email-brijesh.singh@amd.com> <58dc46c4-59ae-4743-214a-df25b138303b@redhat.com> From: Brijesh Singh Message-ID: <8a9d77fe-3831-c644-381f-d5e18fa8a3ca@amd.com> Date: Wed, 2 Aug 2017 06:22:59 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <58dc46c4-59ae-4743-214a-df25b138303b@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CO2PR07CA0045.namprd07.prod.outlook.com (10.174.192.13) To CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) X-MS-Office365-Filtering-Correlation-Id: 73340021-46fc-42eb-2838-08d4d998d927 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR12MB0151; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 3:d03VlOFfO0sXbh2Ir8y8Wt2DiAx+fnfnRe2PEzRGwFTJsPoGPnGHc/+lKB8j+8RisV/mq3MNPfzaYXarB3ayis6Yp4qt79CBcH3oyJzeHOsuxbqKB0RY78hRXMNoCt1yDel6sy8lXtm8D8J/yjhKUZoSkp2X7bHnoUCig32aGSLLzkc/+mAN9lw0EhX+B2vRmbro+ianosIaY/XPoZJZHLRwbSuWABRZ+DWsRSaX4mT7gW5HHhvuKJHXbY3NzB/xSJq7CvoO22PksTYBlIvxxSAgb68DWEpm4RegR6jlZu4kmGzeNThKRWyI7ZlR0h+8o+CRhiHhzScdXo3Lui09UVNWzcmIuAxyWWVX8J/vbIicOTTffP7uWE/VLtbsjFIpGEdDZ7AHQP1ZWFoXVaWszt6IoDL+5o1ZSii5Zw1pXorjsaj3OooboJXNxoedIUcItF4Ku+w8T8MdOks8/Lz62i0SahGlLMqTPCBqmeed7NdlGCBaxUA7wydTWqIV58lc4sWcciMWaeajheyZcMdiXs6Blr1C0wy1nNavs6b0HpMF62OqxLtv6JnTuaiaYtkZiRgBZsr55ZbzjlKakt50CA9hwcrW5jp42RsuiZyq8ziN5wOLt+XVwdtyx3UTM973yT9HIM1Htnqp+eZ21OZjYbD9rk+tbvEBbrVO6cE4J3qLUAQwQEaNi+lcpEoAQZtvHeWXNZpr7Kd36oOYoZqXeQMASBxGW9AMXcJF8Bh2VNOiGitia+jW+dzPLab5Z54rgr/E920Mlf7nvmsY10OtVv+Cjl1CZ7mTfVZcvVqx9EZSAY8er2S27JlRsvFZAzPAXuah94cikAweLHIZUBOGEQ== X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY1PR12MB0151: X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 25:n1yWG8Bfwfmt7Ujhq0Xs7S3TIZpOu0wlcGctfHVLU+x7TyY4eK5h7DO7im+eO9T6RuQa7TaWs+7Vg60MOKG9cwJWVQfe5y3l8seWRRqLIRMwCjCvs0PC+wHlagVZspa0m+koJ4heVeTAbnqEA+z96yXyCVguWHX2uAWRiGVRUYNLasPbitlEuSkU9u067sqjVv7lXV7OXI8n3bwyoTc3HOuO2vA2/ggviiGKz2lkFRLfNRbcS/zoeqxdVxS5IhlxRSerQETRH79dq8BReEoh2ynCcIy++ybuYcceecIOd4huKAvzOGs98CttCJ1PBXGiiZ2im2QD4tSMVAb7P5OgPvtUU+qWp5p2lsZ6RlzZ8+J7DXS6ykaPfWplfbnIyptMDr10YgouGA4PFfP3ppBidXCVkujB5qQWZ3DR7d7DytbzrFFNB8f7U+Ib9jIxbU2/xJ1+7jFWYhJUlHUCtnSoZ0Y+PM4sOwlSp7rCvfSWOWwie1kEQ8z/L4rFrkWJ6u2duRGYRO+FFYxJpKfTlYQi94jzM3Eaz76s+e1LMzkhbmTknh5uuFizOg5/3wKKJImYQttXzUpcPBYXMcRaioxjNWL3Mn01FfshsIjrrq67twppO09CG1dl1UyYnpuwiRMKSe2GuaTgWnn8OvqRzuG9wFKdzQxZew0Y9wmMYRPwcxutJJxR1zUzq7FRbrMLJjsupIjDPgOU3/HlLASABNys2DbIwRS4f2ZsZiX/DJcRxQ+Legb2YgkiqWy9abvZ5K7ModOqIUXu8hIHghtuLSV1+o63FGAx+MafxG+PnxpbAIi1lxKLNG5nmR6Lok5x8aud4W9l38/HrPvjzgHgg/YL/axnVMHAKMISLUAp/A7Xdx3jmT6GkkbrKk9Ciyod//ZvDY1xyOrWoclh/YQuwyVVY8VyrCNDflXdJFsayZUsxhg= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 31:v4BWAw3tG8io49X5eqhjXgguMU8SBhiVmbBCYFjj/WFyBlfnepDCS+nQlsIQOdrj/ZpHlM9IZUWZlrHnmMMdo+5Ky4iPLluJdsfJOSMrqo28yfQvfHnzZp4YtD00rXWh01+Ew055wcfpthT0eQEnfifc5fNKqTA1RhXsVrF0aaml9aUoZT7Ff1cp76rE0+uhHLn3B2BoI5FVEK/1c4kT5hWyke9QkCCSEe5prdh63x8bXFvq+6vsL0iVJp7YM6JtF6E3wGZrlQ0QXRdgPAYAOxMunPojxCUu06MFbWz1qYVisyHYNfGSSXqKAdTthDDrw/97khsF4qMdbfAdf/IMeDP5KwxtkhueLqUyO+vZfYFwaFhIuwYgVMTmygDwYC96oB16hVmbO40YpMpo5tMJGNd+ydmukiLpy+yxZCLt3PvBRp7WVNClBqhmCe0gCQj+1tjspGaizuKuLrfRziigCau4TPPaledpadRlXkhem9iwz65vdvP1o+NQJPekJESt7NzRKVlR5gEWi+V9FYVjeJ6yA6ggxaKL5j+nx2uSnVpkzEm/AxZpfRQEdHKrgjVP1D6JnwhlQtHjXAjnRMe4L6Nv9q7Dye9pKlQPoUmIXmamR857DJo+bM+BpcMz0UrhdnauEju0J2Dg23kODNmNhcqN8nNk8YdJXVDLSm+e0YY= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 20:fBb7Gf/lf8ndS+XlfRCxdP7ANdWweUJBOx8WrxibMEKstcL599Au0UfP2ZBR6EKcad1qa5FyIQNp78plXYy6N5xRbF3qku7j+NuZRL6B1eabveSz6U/nyuu5xOGHOOutJqdG6WN65OqPlVnFpB8pwczOdAl91UGZBlt2RhTh/JU2+IuuSYu+KLEc9v+OnhsYm64jR+6AYfsRSiNCVngcnECcnwuZOJ3o/5M9wxRPh49+95MJgBWXG9+nQZ2WW76UhYeRzjPj3Oo/iaE7+LS8N4pvdmM6rALxymFU1NBFjxKWE0mGf1g3xjcsEciCFjLALabZVnQjMPdj6QLkgbiiEWQNPXg9YNQPmXlGWUoAAp9In4N/2diWPfrn4vPn6uzTByGnYU/Qf1LE1pBmcYzWM93vVeKeNYj1C0EXdSsd3q/9MkOVsTauIwqYHvUw2EENwNZ2bqHheUTRi2vtz8h8lnzkbi7BWlmTKKREz9RHZjV8DljtlBYnM9tuEvJP6Yvc X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123560025)(20161123562025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR12MB0151; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR12MB0151; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUxOzQ6WjVoSkoyV0poR3BjcGx0blJVdW9xVU81aVdD?= =?utf-8?B?ZjA4SFN0VmRxNHRNVy84eHVRdTZRZDNoY1AxZlhIdGY1Wmp6TU9qYi91aHht?= =?utf-8?B?ZEVGanFQZytiK2tLRnRqSnA4WnRYUmpHd3R1OU9SSWtTQkxsM0Faczlpc0xx?= =?utf-8?B?Nmw3NS9rdGpOMHdLT3huRXkrZUs2Z1pwMFQrZkRpVWRDL2E4aHhxZ1JrN3p1?= =?utf-8?B?MWNVVUZ0eUJUVFRsb1pWWCs0UXoxWWxBTmQxRWFHY04wSGZodU0wQk16UnNu?= =?utf-8?B?SXo5Znh1bHFPVG9PeEh5S3ZnKzJld3dEbGZYV2p2TEs4NDJCWjI5NnlqaWFW?= =?utf-8?B?NmRYejV0czVTaXI4ZUZ5SWVVV3dLdzM0YXBBZ0pqdFloMUltRlJ0WDFQbWty?= =?utf-8?B?c2hET2hlaWtSV2hVbzl3YzNKakQ5QWVTYmRzU1padUVCWnR6T0hpSXViOWNn?= =?utf-8?B?VnJWc0VhdHVWYmZtbW9HeEl2bmloL1I4RnBiWkkvOUQ4cmQ1ZXl5ejByWWUy?= =?utf-8?B?Zi9VWUFoYWZkTEQ5cDkzQmwra3dSeHBoVE5SYVJHZTByMjJKeVdKa1M0TUhN?= =?utf-8?B?aWN2dVA1OTVNSWhzZnVDUCt0OW9RWVE5alBNQTdKcUVhcm0rZmxwNEZLSTRY?= =?utf-8?B?RnhzcWxtUUFyL3J1VzlLNkw2NTB6NWVBZ21mN0lVczBSMlBHRHVjckRuWWlO?= =?utf-8?B?SS8xTTBNeFdQU0xIcUYrS1AyRDc3dGEzVWdlZitpdGxWODJjd0t0dWdVU0lT?= =?utf-8?B?d1Fia1FKMGlUa2ZiYWJFV3EvREtxQWdrQTdNSkpUS3c1UkdmeFpTUUdoR2JF?= =?utf-8?B?S2FmNXNyZU1vd0R5ckprUXhPUmtxYTF1MHpIYzB1Qk1mS1NEOWJvdzhSWmJV?= =?utf-8?B?REZhNnpueXl1K0RBUDVqV1Y1WUdLSEsyUkhXelpMQS95cGhhaGRVN0ZPMzZF?= =?utf-8?B?Zlo2c25XY29QL3FOMXlUUEZZc1JieHBrbTNCTk1xcEYva3JkK1FuMWpNVEdt?= =?utf-8?B?djY1ay9MYTFyQUNqUGFvQ25aK3BkZDRYU25Bb25CSTZsYUlJQ2tKZmIyZWJt?= =?utf-8?B?ZnptSW02c2tKS011T0xBVmh6Q3dLQ1hXTjM4TURxSjdhemxyaGNFLzRBc3cy?= =?utf-8?B?UnM4WEhPNWtwVXZ1aEV1VU9QSkV6Sms1c1NwVk9XSGJiMHFTbmcvczhqZGN4?= =?utf-8?B?ZHB0Z1Z4L0lDbnJrazU2czFDY2paTmc4YlFLNFpzbGZoN2RUTml0WU9OVDhW?= =?utf-8?B?S1lON1BwTTllLzZHS25Sd1BSSGpPMlN5M0YrMW9QUDFjZCtXSEk4cjN1NXBk?= =?utf-8?B?NEU3T05aZ1RkR1NmM0I1NW5qYmRBTXBGVWp2UVEzS25mb0pnbWFtK1lyUHJr?= =?utf-8?B?QWp4YUtjaWNKNEg3VmNKbTVBTC84MzJHQXJ0dWtEc000emNJWGZqQittOThW?= =?utf-8?B?ajU0YVRQV3hSZDlFQkdPMWY1dlNWd2ZOWE41ZHMydGpucWJlall6YmVoRWdL?= =?utf-8?B?ZFQ0U09uR2dHMVpwK1hOOHlvT2JUVHArNDdIMy95cjd2N2dzcnpGbE4relNN?= =?utf-8?B?QmFDU3kwMVZlUWIvZGdta205SnVDUT09?= X-Forefront-PRVS: 0387D64A71 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(39860400002)(39850400002)(39410400002)(39840400002)(39400400002)(39450400003)(199003)(377454003)(57704003)(24454002)(189002)(65806001)(65956001)(66066001)(36756003)(189998001)(83506001)(47776003)(53936002)(97736004)(53546010)(23676002)(478600001)(106356001)(105586002)(54356999)(25786009)(110136004)(6246003)(7350300001)(4326008)(76176999)(38730400002)(50466002)(229853002)(305945005)(4001350100001)(6666003)(7736002)(65826007)(86362001)(42186005)(230700001)(53416004)(81166006)(81156014)(8676002)(64126003)(31686004)(5660300001)(101416001)(2906002)(6486002)(2950100002)(68736007)(33646002)(54906002)(31696002)(3846002)(50986999)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0151; H:wsp094023wss.amd.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUxOzIzOjYwQUFKQXQ5Si9lREpKSnBWVHVKWEZ1Z2RS?= =?utf-8?B?K2FuYmNEZHZScU5RK21iOGRxcTFxSEdGM1VQaXBlWkxaeTRhNENMc01sTDZl?= =?utf-8?B?YVgraFJxd0tQbStJUW5QTFZrbHcrREZOZFNPUFhiUDNHUVFIMVdCc3B2Vk9P?= =?utf-8?B?Y1V1VnB3N2MrTExWaHdJVmV6VDIwSjg5eHl6c1JVcWVqblRmWHZKTCticERh?= =?utf-8?B?dXNZL29KcXQyejY2azJySjVGNUdRRXpzUGRjcXduNWhhQ3REbk1kTFdLNUNT?= =?utf-8?B?aGpCaHJMdDUvL043RXJvRnExQm9DWkQzdDk4djhSdGZEQXAxb1RzL3NOSmlo?= =?utf-8?B?MjJOdFVZdFdxRUY3Q05rUXBDaVQwT2Y3MGdwZ0FtY3h0eTNUV0c0Y2pzQnE4?= =?utf-8?B?NVBlRGk5eExiYmE0K2Y2SkhxWmhmM09xQ2RZeTVQamI2ejNCeUd3WjhiVTRo?= =?utf-8?B?UXdPdTE4c2swZS9BV1dKODgyeVg0NW1DU0ZXN2MxcXR1WGowOEJiMGRTK1Zk?= =?utf-8?B?cCtIYkkxUStlcnIwY0xEY3NnVnZ0cEluZnFqUEphSkdMRVJjaDB0SHpLV05Q?= =?utf-8?B?WDBVVFZ1SzBDSWxSWXhWSHJvYmxIdjRBUlVUeTNVWXN0UUJWUFFVNUkyUGg2?= =?utf-8?B?TXU1Nlk0SlZxL2hobCtrSTZJMDdNNlJWZ3VIYVFnWUw2eEthNGxnRFpsajhy?= =?utf-8?B?SUIvbVV0V2VESUFlT1R5bzV4MWNRUHJkZzQ1UHFJYnJ2VW9zVlBBOGZRNnZT?= =?utf-8?B?Y0xmQXI5RzBnMWlUaWVLZjRGcUR5a0dvY0RLbUZKeC9temc3ZUhMeTdDMklm?= =?utf-8?B?dExKRXZ3Y054dEtKWXRQTkF2QzM1S1l2bjU1ZVpkQjZsWEhlWm9ZWTRvZWp0?= =?utf-8?B?Mk5oMmRmWjQydUFHRkt1WmxQRllHM3pEczBDYndzUW9jaFk5NGxzMG4zWWpS?= =?utf-8?B?MDhWN3M0TVJ0WG9rQXVBeUpLZjZ0UzZQOXFtV2F4TndjTHFDMG5nZGRDSVNO?= =?utf-8?B?bmZ3b0FMME9DR0lIS1c3QWpIZi91Q2hEVVphYVVrelRlRno2NlN6empOK3Nw?= =?utf-8?B?dVczZDBUb2dNdjYwRlJ4WXNwejdJUkVCUHE5bkxHUDZkUVhGaUJuSENHUDRX?= =?utf-8?B?RDZKRkZUNHZNcHJlYXlHQnhYVnlvb3ZMeW10YXdtRUlNcmJLZmNUeFZMSXp3?= =?utf-8?B?bktLZ3RUc2JuY1BRcWd0UWpna2N6Wk9LcDhFb0xWUGNiZ3VvNnZUd2JCVEdW?= =?utf-8?B?TkFCem1lanI3ekpkM2FVbEhsMVdqWjVodkxqRmlUcW5hbWE5NUZTWmFsSFdB?= =?utf-8?B?NVFseU93RUE5S3ZSdGxLV1djMTFIMjFYWDJoaHFMQm5BNzRoTGtza3NqNTBv?= =?utf-8?B?aCtVd3dZazJYOGNWdzZTR2Njbk9SUURyQXQ0ZUVMcW8zU1NGeEFicGdPSmtt?= =?utf-8?B?UVpDcDZoWnNTVmtjS3Y4Tk1ibGtwVTJNWHVKWCtOQllteW9sTW5IQ0ZMajJj?= =?utf-8?B?bldoZTh6c2xIWE5EZ09DVUI1WG5yY2FSUDJUTHM5eHhSRlFrdS9yRm9YNmlH?= =?utf-8?B?RVp6dzdKWWpqWk9zZ0QrdVI4Rmc0TUxmeDVzL2xwTmY4cXF1Sit3TVBuczZT?= =?utf-8?B?WFVkanBxbC9FQlVXZTFPQ1I1Q2pHWGlub3BLTnhpdXM4TEVRSmt6TENFOXVV?= =?utf-8?B?ckQzdHRHZmdnbTMrM08wWWVNdG5HUkFaTXhjSDRFZHVBUWhBYUdvZG9zVldx?= =?utf-8?B?TkpUcFBTMlpnS3h4MVZJQXRRRURrdEJtK1dJL3RZM0NkdjFMRXEvS2RFL3V6?= =?utf-8?B?QTIvdnNiam1NVE9mMVdOSkZySkMrRk9aRjV3cTdPVmQzWFJ0ZDZkUGhTb1pP?= =?utf-8?B?VEhOa3lhZ2g2ZmZZaWx6ajJQc3h0TUhuT2JsWVRQYmFiVUJoWkJtOU1lRkxm?= =?utf-8?B?RGJsbEw0Slc4SSs4MUpkU0ZzSkNlaUg5R1A5dmdGMkt1c21CUThuUzRVT1Ba?= =?utf-8?B?QXViazltaXpQTy9GeG9TUlg3K3k2YWtZclRSWFozOGo0T3dWcTA1MjdsdWVr?= =?utf-8?B?WTNmTjZNYVJBczZ4SDh1cnc2S0pPQ3VoSFJFWHFtam1KMERFalRzaStnVHVB?= =?utf-8?B?Qnc9PQ==?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUxOzY6dzd3UFBMWXZNZ1JMczhEdDVjZ2FKaU9FZlU0?= =?utf-8?B?SkZYaVBncG5tdWhpMUVkR3MrcnNWamZJQnRFRUJGYnBBYXRUOVhlTmNFNzAz?= =?utf-8?B?Rkx6TXFXQ2hVcElQQXpqN1VKR3BIWlVOanVoWlkza2RzOGJpTzlqbDVNaEg5?= =?utf-8?B?STBqTXloakJqeDRmdWVHczJFOUtpR2VLK1NmNVV2dGtXRWtsQ2hxMTJzRE5h?= =?utf-8?B?dnpNUEdhRDNKNmdBbEFvYTlKdjVHYjdKQ1ExcGRLVHJyMW14L1d2WTJBN1JP?= =?utf-8?B?WXEwaW1LZkVJaGgvOU9yekNlVXdNeFhrVVZnQkZ6L0FtMGlIckZJMWVGOWVs?= =?utf-8?B?aExUakJxVzNDVDJUZmU2YkFZMFMvK294QkdkL2duYU52OFhDUTMzTGM5aVJ1?= =?utf-8?B?d1pkRURKd09rV2lIL3o0dzFWdUthQWVJSmllbU1aYkloa3QxQUgzZzJpQVBr?= =?utf-8?B?QWtna3M4R0RwemJJZEUzeFphQ2JGZTR6U3I5bEh5d3dZRlhwWUVsK2FUSVM1?= =?utf-8?B?RXpHT2xWQS9iV1RVWkk4OHNJYmhlRnJUbWRNNUdkS1dkV1FhZHFnNWVpMG0y?= =?utf-8?B?ZUs5bG1INndpcGVVZTVjb2dQbkNUQXhBTzV4Z000c29aOHNjUWRRVkV2cEdK?= =?utf-8?B?OEpxa3g1VFEvUVBFT2Z6Y2g2QThzaHdXZjJwYzdPc2ZTR1B5U09tZ3hpVW0y?= =?utf-8?B?aHpaWklKQllNSnM1Q2ZpWGVNaEN2emI4bnEvNGRSR2xlVERHZ0hjU3M0dlVx?= =?utf-8?B?bFAxZHNyVUdBMUFGNjYzY21xM0c2bStMcFVkRnBRd0M3VlM4U1Y3NXNMNHdK?= =?utf-8?B?ZS9WWDErckpDaXZlSUtvTW1wem0yanJDN0g1VHJKU2dYcnJlbmExYnlWT21u?= =?utf-8?B?cFcwWkZPNEJ5NTYzRW8vZTFmNFBmc04ybDhtdUJleE0vMFR1SkdUYTM3bnZo?= =?utf-8?B?QWl4aEZqdEV4NnA0c091RVdlTldtZGwydWdDMThYMGRwZDc0cGZyOGhMZFhj?= =?utf-8?B?UnExL1EyZUFrK3BLT0s2Wlk0K0RvL1pqMk9ZVGFXNnJQTjZqNmRveFpTYzlN?= =?utf-8?B?RUtRaWNMRWd2Y05jTXRKbVBVYy92UjFSQk5CQlZsbzlEdE92S0ZveTdRZFlW?= =?utf-8?B?S055clQzbmJ0b1hQSnplMGY1cjBHVFZGZkZ0V3RGRk9zUk41bXRvZjhXZWUr?= =?utf-8?B?cTBiMUU0cjRXSnordWVMQjBCTHBXSmk2a2ExTlN4RkV4WENEQnk5TU1jemd3?= =?utf-8?B?bFd3ZnlCVDdTdlFNdnRUWHZ3UUZxRmlnR3JaeFJqa0xvTmdqR3plUmtoNEN6?= =?utf-8?B?MHJZOGE0RTlaTlAvZi9rMVViS1hSeDN4ODZ4NGJkeHIxTS9PQWdVVkZyd0hs?= =?utf-8?Q?NRFKTL1?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 5:mm4wLVHKahbHu6VC2m+ZF4tA2I9VUUpWSpt7c/DT4x9fi/TvlOkqEpjh2e22IzPhPDcJHgjighjim/VVNUr6MihznETbcuL+HMvxUoOqpq+bi/+K9TI9lZVXkWR4gxwgUKcn4crtVBEJmYYoPjbdmupu2ISlCcV7me0EbpyXeJL34XlPvXH2La6j+W0FfH698h8HHz1BcLOIR6PBxbwMSChHswRHb7lDJLPj4uIp3BTGPgG+44Q2STmeUcttDurguMyhGvP6Uep0iXjaAVtA1dlil7ZldeoAe9jnl3QHp5V4igPyVKeYnnBFCdTGd38hPkOQ8xegvsGi9zWrD329dW0Edw88SJuBU3QZlVBhsgIwPmYxcybzloNfKfsgipZxCgSfix81BBjtUGE9ULAhZ1iRbl/KkqRu2m9QZJ3T5D0+w9ps4deMFP74/r6xmGeHXkpsedrTKqzgK/5CIVuPs1vdprfBpGkfhOFVlZCfXgICkyYzNObjhvfeMnmlIiNJ; 24:eIxlWtP+wZwsVHGoIH3M8w9+Ql5XtDN49U3FDdU1IeaOS+TB7sSs9R9J9Jl7MGLV9osJWdowqk+c1eWNKDgDOdOx7Ye9zJStj8uNZtC5J4Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 7:j8DYBVC9EEIZLjv9Sej1iOthbm7qV2JsG33jl9+mOzm5muqMnk29Jm8ByQT+Wo7xDu3cDnkJoetT2HverylqTYhqqaYKB5pJrB38Jat/ycKLmpY/s2E16vE0S4uwC0PYuWj3mKuQv7m89UiKcsffmTIiVuwCKn4LPGKX0iuMFu9q1uwrZFX1iKv0Y4nVjlL/wApAdbA/7m221W+LWOT7GmhZHCMZtyQIcrQ+f+tEs+LLFdGUIfVduEyucKxSo9GQm+NLH2ngy8lD9z/0+bemrqyNzQ6kRd8eYJIoKK6ASYg76s/gnQMkOh2vJK6fos5ozG/uFIlIOOFieY5mtDaGtUMoSxczyfJIOLRpOXgGSLIvhn/Xx5Ivf/kAW8xBJyKc0+WYMzxi4vZXGZNxTHrLnjNIINSZwm7KNiw8p60jiBjqViTZC4N7H9vGJ1qmGuyf2lKEk9Mrv8p/nitZjZaM0loMM7+nOCfKnyjecl8wGYlsE1PDExGGIxHrHIsAIMCMtKjYJUknk35w17gS46jg302NWAK03ZzeBur6+/bhEkYKHjr+7aGiqdOA83Z8ujxOn4RrvpDoamFuwjUhnpMFMAzawBUUaFbKehkLGlUxopyl2gJ1wB/tIBn27noGoQXoiZxcPD9oVoQVgXnKO6yLgDh5OiT1nHfNa4HnkRnufCIb0/T0JZ58Uq4dIQ90kTtDrfLL61xmv9tAVhkgAKmWlNbKWlwMQpmjFiQfSKUEXm45OWsNikEowsHlv0SUQM0z1Q6wpLGGCKJf4M4M4fIyn9AlueNUZrDJ2WJcrLqWn0w= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 20:Kha5yapq9A+1+dHJhSDiIIldbczoYcZO9O/bsgFdRHo0w5a0wtScKM6Bq3P/nzzQmz+Zf0S7IawGEjtv3yE39x/+JV8kPpeNYQZi1J1pt/AdCdyHwqzyDAPEdZ3px2BDex8PLgltB/L7pt6oRSMoqlk8pkxx65CCYso7z8e/HX8+R1r9UShOnWaoBbB+2MsFlOmHIaTqYhc0iGhLWQLzLhVT3+pMkE0Oj4cVKe3NsOKNBwNEzLgbzgpPfJDf251C X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2017 11:23:05.7248 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0151 Subject: Re: [PATCH v1 3/4] OvmfPkg: IommuDxe: Zero the shared page(s) on Unmap() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2017 11:20:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 8/2/17 2:37 AM, Laszlo Ersek wrote: > // >> + // Zero the shared memory so that hypervisor no longer able to get intelligentable >> + // data. >> + // >> + SetMem ((VOID *) (UINTN)MapInfo->DeviceAddress, MapInfo->NumberOfBytes, 0); > Please use ZeroMem(). > > Furthermore, ZeroMem() should occur just before every FreePages() call: > - when Unmap() releases the implicitly allocated bounce buffer > - when FreeBuffer() releases the explicitly allocated common buffer > (I thought I spelled this out in my previous email(s), but in > retrospect it seems I only intended to :/ ) > - in the virtio drivers' exit-boot-services callbacks, FreeBuffer() > can't be called (only Unmap(), after the virtio reset), so the > ZeroMem() should be done manually there. Not sure why do we need to ZeroMem() when FreeBuffer() is called for explicitly allocated common buffer ? I thought before calling the FreeBuffer() on common buffer, client will call Unmap() which will restore the C-bit state on the common buffer and also update the contents (i.e now common buffer will contain encrypted data).