From: "Laszlo Ersek" <lersek@redhat.com>
To: gaoliming <gaoliming@byosoft.com.cn>, devel@edk2.groups.io
Cc: "'Agyeman Prince'" <prince.agyeman@intel.com>,
"'Chasel Chiu'" <chasel.chiu@intel.com>,
"'Deepika Kethi Reddy'" <deepika.kethi.reddy@intel.com>,
"'Jeremy Soller'" <jeremy@system76.com>,
"'Kathappan Esakkithevar'" <kathappan.esakkithevar@intel.com>,
"'Kelly Steele'" <kelly.steele@intel.com>,
"'Michael D Kinney'" <michael.d.kinney@intel.com>,
"'Nate DeSimone'" <nathaniel.l.desimone@intel.com>,
"'Philippe Mathieu-Daudé'" <philmd@redhat.com>,
"'Rangasai V Chaganty'" <rangasai.v.chaganty@intel.com>,
"'Yi Qian'" <yi.qian@intel.com>,
"'Zailiang Sun'" <zailiang.sun@intel.com>
Subject: Re: 回复: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add OrderedCollectionLib class resolution
Date: Mon, 18 Jan 2021 08:56:21 +0100 [thread overview]
Message-ID: <8ab2ada7-2b48-a7c1-00f2-568a902def02@redhat.com> (raw)
In-Reply-To: <003701d6ed3a$91c2b0f0$b54812d0$@byosoft.com.cn>
On 01/18/21 02:38, gaoliming wrote:
> Laszlo:
> Can you add OrderedCollectionLib library instance into edk2-platforms\Platform\Intel\MinPlatformPkg\Include\Dsc\CoreCommonLib.dsc?
OK, I'll do that.
Thanks
Laszlo
>
> All Intel MinPlatform includes this file. Once this file is updated, their OpenBoardPkg.dsc doesn't need to be changed. That means below DSCs can keep no change.
>
> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: bounce+27952+70213+4905953+8761045@groups.io
>> <bounce+27952+70213+4905953+8761045@groups.io> 代表 Laszlo Ersek
>> 发送时间: 2021年1月13日 16:29
>> 收件人: devel@edk2.groups.io
>> 抄送: Agyeman Prince <prince.agyeman@intel.com>; Chasel Chiu
>> <chasel.chiu@intel.com>; Deepika Kethi Reddy
>> <deepika.kethi.reddy@intel.com>; Jeremy Soller <jeremy@system76.com>;
>> Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>; Kelly Steele
>> <kelly.steele@intel.com>; Michael D Kinney <michael.d.kinney@intel.com>;
>> Nate DeSimone <nathaniel.l.desimone@intel.com>; Philippe Mathieu-Daudé
>> <philmd@redhat.com>; Rangasai V Chaganty
>> <rangasai.v.chaganty@intel.com>; Yi Qian <yi.qian@intel.com>; Zailiang Sun
>> <zailiang.sun@intel.com>
>> 主题: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add
>> OrderedCollectionLib class resolution
>>
>> The edk2 patch
>>
>> ShellPkg/ShellCommandLib: add ShellSortFileList
>>
>> for BZ#3151 will make the
>>
>> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>>
>> instance dependent on the OrderedCollectionLib class. Because the shell
>> binaries in the Intel platform DSCs consume the above UefiShellCommandLib
>> instance, resolve the OrderedCollectionLib class in them.
>>
>> Cc: Agyeman Prince <prince.agyeman@intel.com>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
>> Cc: Jeremy Soller <jeremy@system76.com>
>> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
>> Cc: Kelly Steele <kelly.steele@intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
>> Cc: Yi Qian <yi.qian@intel.com>
>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
>> | 1 +
>> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> | 1 +
>> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> | 1 +
>> Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> | 1 +
>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> | 1 +
>> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> | 1 +
>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> | 1 +
>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> | 1 +
>> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> | 1 +
>>
>> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg
>> .dsc | 1 +
>> 10 files changed, 10 insertions(+)
>>
>> diff --git
>> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
>> dsc
>> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
>> dsc
>> index 6de834565a7a..775eda4b03bc 100644
>> ---
>> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
>> dsc
>> +++
>> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
>> dsc
>> @@ -378,6 +378,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git
>> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> index 862e6a6655a3..c400173f7e0a 100644
>> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> @@ -350,6 +350,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git
>> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> index 0b30da8f9665..d76c220b9145 100644
>> ---
>> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> +++
>> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> @@ -429,6 +429,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> index 9f64dcb62724..e29c7465b1e4 100644
>> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> @@ -912,6 +912,7 @@ [Components.IA32]
>>
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
>> mandsLib.inf
>>
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
>> CommandsLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> index db144aab75ae..6fdfba9a58dc 100644
>> --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> @@ -639,6 +639,7 @@ [Components.IA32]
>>
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
>> mandsLib.inf
>>
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
>> CommandsLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> diff --git
>> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> index 77c408a326db..186e0a0df980 100644
>> --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> +++
>> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> @@ -270,6 +270,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> index 4fa3e2013120..409f31c982d7 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> @@ -1152,6 +1152,7 @@ [Components.IA32]
>>
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
>> mandsLib.inf
>>
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
>> CommandsLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>> <PcdsFixedAtBuild>
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> index 8adae2e24993..38bd825c8bdc 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> @@ -1167,6 +1167,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
>> mandsLib.inf
>>
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
>> CommandsLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>> <PcdsFixedAtBuild>
>> diff --git
>> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> index fb493973e22d..463234a3d948 100644
>> ---
>> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> +++
>> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> @@ -371,6 +371,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git
>> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
>> kg.dsc
>> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
>> kg.dsc
>> index 9a1f107fafe1..586fa848650f 100644
>> ---
>> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
>> kg.dsc
>> +++
>> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
>> kg.dsc
>> @@ -377,6 +377,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> --
>> 2.19.1.3.g30247aa5d201
>>
>>
>>
>>
>>
>
>
>
next prev parent reply other threads:[~2021-01-18 7:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 8:28 [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 1/3] Platform/BeagleBoard: add missing TimeBaseLib resolution Laszlo Ersek
2021-01-18 8:16 ` [edk2-devel] " Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution Laszlo Ersek
2021-01-15 9:27 ` Marcin Wojtas
2021-01-18 8:19 ` [edk2-devel] " Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 3/3] Intel " Laszlo Ersek
2021-01-15 23:34 ` [edk2-devel] " Nate DeSimone
2021-01-18 1:38 ` 回复: " gaoliming
2021-01-18 7:56 ` Laszlo Ersek [this message]
2021-01-18 8:16 ` Laszlo Ersek
2021-01-18 8:18 ` Laszlo Ersek
2021-01-15 8:50 ` [edk2-devel] [edk2-platforms PATCH 0/3] " Laszlo Ersek
2021-01-15 9:22 ` Ard Biesheuvel
2021-01-15 9:35 ` Laszlo Ersek
2021-01-15 22:04 ` Leif Lindholm
2021-01-18 7:41 ` Laszlo Ersek
2021-01-15 9:27 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ab2ada7-2b48-a7c1-00f2-568a902def02@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox