From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.30612.1610956593379383579 for ; Sun, 17 Jan 2021 23:56:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D1A58ifr; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610956592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eVYix6kWhwf6PRloaN9MKpka/ujzPwosFpFf9khdC0o=; b=D1A58ifr8ZDLIA5tAAOODKnqx0UcpR7v8YYBs5oIGv0fUKjPuCy/kWOw1NKKdS56d0HuxL AWXzb/KADLA30U5c0ezT3QqD2qM5OuYBJONKAE5ACyalSbZGQqr3nLBI8ZTakowTti0e31 YRvUGi+AGEeb0T0FCs53vPZZ91q0CP8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-Mh48a8aiOR-z1igTkHs9wA-1; Mon, 18 Jan 2021 02:56:29 -0500 X-MC-Unique: Mh48a8aiOR-z1igTkHs9wA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 280678066E5; Mon, 18 Jan 2021 07:56:27 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-141.ams2.redhat.com [10.36.113.141]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9AD5A60622; Mon, 18 Jan 2021 07:56:22 +0000 (UTC) Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtlZGsyLXBsYXRmb3JtcyBQQVRDSCAzLzNdIEludGVsIFBsYXRmb3JtczogYWRkIE9yZGVyZWRDb2xsZWN0aW9uTGliIGNsYXNzIHJlc29sdXRpb24=?= To: gaoliming , devel@edk2.groups.io Cc: 'Agyeman Prince' , 'Chasel Chiu' , 'Deepika Kethi Reddy' , 'Jeremy Soller' , 'Kathappan Esakkithevar' , 'Kelly Steele' , 'Michael D Kinney' , 'Nate DeSimone' , =?UTF-8?Q?'Philippe_Mathieu-Daud=c3=a9'?= , 'Rangasai V Chaganty' , 'Yi Qian' , 'Zailiang Sun' References: <20210113082843.9095-1-lersek@redhat.com> <20210113082843.9095-4-lersek@redhat.com> <003701d6ed3a$91c2b0f0$b54812d0$@byosoft.com.cn> From: "Laszlo Ersek" Message-ID: <8ab2ada7-2b48-a7c1-00f2-568a902def02@redhat.com> Date: Mon, 18 Jan 2021 08:56:21 +0100 MIME-Version: 1.0 In-Reply-To: <003701d6ed3a$91c2b0f0$b54812d0$@byosoft.com.cn> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01/18/21 02:38, gaoliming wrote: > Laszlo: > Can you add OrderedCollectionLib library instance into edk2-platforms\Platform\Intel\MinPlatformPkg\Include\Dsc\CoreCommonLib.dsc? OK, I'll do that. Thanks Laszlo > > All Intel MinPlatform includes this file. Once this file is updated, their OpenBoardPkg.dsc doesn't need to be changed. That means below DSCs can keep no change. > > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 + > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 + > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 + > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 + > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 + > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 + > > Thanks > Liming >> -----邮件原件----- >> 发件人: bounce+27952+70213+4905953+8761045@groups.io >> 代表 Laszlo Ersek >> 发送时间: 2021年1月13日 16:29 >> 收件人: devel@edk2.groups.io >> 抄送: Agyeman Prince ; Chasel Chiu >> ; Deepika Kethi Reddy >> ; Jeremy Soller ; >> Kathappan Esakkithevar ; Kelly Steele >> ; Michael D Kinney ; >> Nate DeSimone ; Philippe Mathieu-Daudé >> ; Rangasai V Chaganty >> ; Yi Qian ; Zailiang Sun >> >> 主题: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add >> OrderedCollectionLib class resolution >> >> The edk2 patch >> >> ShellPkg/ShellCommandLib: add ShellSortFileList >> >> for BZ#3151 will make the >> >> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf >> >> instance dependent on the OrderedCollectionLib class. Because the shell >> binaries in the Intel platform DSCs consume the above UefiShellCommandLib >> instance, resolve the OrderedCollectionLib class in them. >> >> Cc: Agyeman Prince >> Cc: Chasel Chiu >> Cc: Deepika Kethi Reddy >> Cc: Jeremy Soller >> Cc: Kathappan Esakkithevar >> Cc: Kelly Steele >> Cc: Michael D Kinney >> Cc: Nate DeSimone >> Cc: Philippe Mathieu-Daudé >> Cc: Rangasai V Chaganty >> Cc: Yi Qian >> Cc: Zailiang Sun >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151 >> Signed-off-by: Laszlo Ersek >> --- >> >> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc >> | 1 + >> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc >> | 1 + >> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc >> | 1 + >> Platform/Intel/QuarkPlatformPkg/Quark.dsc >> | 1 + >> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc >> | 1 + >> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc >> | 1 + >> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> | 1 + >> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> | 1 + >> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc >> | 1 + >> >> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg >> .dsc | 1 + >> 10 files changed, 10 insertions(+) >> >> diff --git >> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. >> dsc >> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. >> dsc >> index 6de834565a7a..775eda4b03bc 100644 >> --- >> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. >> dsc >> +++ >> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg. >> dsc >> @@ -378,6 +378,7 @@ [Components.X64] >> >> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 >> CommandsLib.inf >> >> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman >> dLib.inf >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> + >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi >> b/BaseOrderedCollectionRedBlackTreeLib.inf >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC >> ommandLib.inf >> >> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf >> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> diff --git >> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc >> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc >> index 862e6a6655a3..c400173f7e0a 100644 >> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc >> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc >> @@ -350,6 +350,7 @@ [Components.X64] >> >> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 >> CommandsLib.inf >> >> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman >> dLib.inf >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> + >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi >> b/BaseOrderedCollectionRedBlackTreeLib.inf >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC >> ommandLib.inf >> >> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf >> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> diff --git >> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc >> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc >> index 0b30da8f9665..d76c220b9145 100644 >> --- >> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc >> +++ >> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc >> @@ -429,6 +429,7 @@ [Components.X64] >> >> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 >> CommandsLib.inf >> >> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman >> dLib.inf >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> + >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi >> b/BaseOrderedCollectionRedBlackTreeLib.inf >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC >> ommandLib.inf >> >> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf >> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc >> b/Platform/Intel/QuarkPlatformPkg/Quark.dsc >> index 9f64dcb62724..e29c7465b1e4 100644 >> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc >> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc >> @@ -912,6 +912,7 @@ [Components.IA32] >> >> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com >> mandsLib.inf >> >> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 >> CommandsLib.inf >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> + >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi >> b/BaseOrderedCollectionRedBlackTreeLib.inf >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC >> ommandLib.inf >> >> diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc >> b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc >> index db144aab75ae..6fdfba9a58dc 100644 >> --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc >> +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc >> @@ -639,6 +639,7 @@ [Components.IA32] >> >> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com >> mandsLib.inf >> >> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 >> CommandsLib.inf >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> + >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi >> b/BaseOrderedCollectionRedBlackTreeLib.inf >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC >> ommandLib.inf >> >> diff --git >> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc >> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc >> index 77c408a326db..186e0a0df980 100644 >> --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc >> +++ >> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc >> @@ -270,6 +270,7 @@ [Components.X64] >> >> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 >> CommandsLib.inf >> >> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman >> dLib.inf >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> + >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi >> b/BaseOrderedCollectionRedBlackTreeLib.inf >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC >> ommandLib.inf >> >> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf >> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> index 4fa3e2013120..409f31c982d7 100644 >> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc >> @@ -1152,6 +1152,7 @@ [Components.IA32] >> >> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com >> mandsLib.inf >> >> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 >> CommandsLib.inf >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> + >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi >> b/BaseOrderedCollectionRedBlackTreeLib.inf >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC >> ommandLib.inf >> >> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> index 8adae2e24993..38bd825c8bdc 100644 >> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc >> @@ -1167,6 +1167,7 @@ [Components.X64] >> >> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com >> mandsLib.inf >> >> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 >> CommandsLib.inf >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> + >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi >> b/BaseOrderedCollectionRedBlackTreeLib.inf >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC >> ommandLib.inf >> >> diff --git >> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc >> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc >> index fb493973e22d..463234a3d948 100644 >> --- >> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc >> +++ >> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc >> @@ -371,6 +371,7 @@ [Components.X64] >> >> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 >> CommandsLib.inf >> >> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman >> dLib.inf >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> + >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi >> b/BaseOrderedCollectionRedBlackTreeLib.inf >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC >> ommandLib.inf >> >> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf >> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> diff --git >> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP >> kg.dsc >> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP >> kg.dsc >> index 9a1f107fafe1..586fa848650f 100644 >> --- >> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP >> kg.dsc >> +++ >> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP >> kg.dsc >> @@ -377,6 +377,7 @@ [Components.X64] >> >> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 >> CommandsLib.inf >> >> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman >> dLib.inf >> >> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL >> ib.inf >> + >> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi >> b/BaseOrderedCollectionRedBlackTreeLib.inf >> >> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC >> ommandLib.inf >> >> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf >> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> -- >> 2.19.1.3.g30247aa5d201 >> >> >> >> >> > > >