From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.311.1587382754948020250 for ; Mon, 20 Apr 2020 04:39:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Is9J2+SJ; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587382754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WFcp7KGo0v+aDpRxV4+HlLkfPgtpOLmsnWLmpF+C6OE=; b=Is9J2+SJXQeMKufcgLvmqsolqi/Sh+z2K1tKnu9HDx7/fyPlR5GZXiVCZGMUvMs83RFAkG Vd1UglC9DZRHQCb8OMwmw5RpbtN5SOnVgeXKC9khWuEjdm2t/11BO3II+aLpy08alD5jva qh+kDXGDTxbpumf5imQzGDUTMzgKFD8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-764SuuOPNwSX3ZhLdsvWdw-1; Mon, 20 Apr 2020 07:39:10 -0400 X-MC-Unique: 764SuuOPNwSX3ZhLdsvWdw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B2EBC8017F5; Mon, 20 Apr 2020 11:39:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-228.ams2.redhat.com [10.36.114.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13A33A1059; Mon, 20 Apr 2020 11:39:07 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 0/6] Mark the File parameter as OPTIONAL To: devel@edk2.groups.io, guomin.jiang@intel.com References: <20200416073354.2232-1-guomin.jiang@intel.com> From: "Laszlo Ersek" Message-ID: <8ab786ea-d813-896e-83aa-4bd6b1296b1a@redhat.com> Date: Mon, 20 Apr 2020 13:39:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200416073354.2232-1-guomin.jiang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/16/20 09:33, Guomin Jiang wrote: > File paramter should be optional according to the descritpion. > > Guomin Jiang (6): > SecurityPkg/TPM: measure UEFI images without associated device paths > again > SecurityPkg/DxeImageAuth: Mark the File parameter as option > SecurityPkg/DxeImageVerificationLib: Mark the File parameter as > OPTIONAL > MdeModulePkg/SecurityManagementLib: Mark the File parameter as > OPTIONAL > MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL > MdePkg/Security2: Mark the File parameter as OPTIONAL. > > .../Include/Library/SecurityManagementLib.h | 2 +- > .../DxeSecurityManagementLib.c | 2 +- > .../Universal/SecurityStubDxe/SecurityStub.c | 2 +- > MdePkg/Include/Protocol/Security2.h | 2 +- > .../DxeImageAuthenticationStatusLib.c | 2 +- > .../DxeImageVerificationLib.c | 2 +- > .../DxeTpm2MeasureBootLib.c | 20 +++++++++---------- > .../DxeTpmMeasureBootLib.c | 20 +++++++++---------- > 8 files changed, 26 insertions(+), 26 deletions(-) > The more I look at the pre-patch code, the more the pre-existent documentation inconsistencies irritate me. I withdraw from reviewing this series. Proceed as you and other reviewers see fit. If you prefer, go ahead and simply revert 4b026f0d5af3. If you do so, I will not review that patch either. The existent function-level comments are broken, so I don't think anyone can really rely on them for guidance. If you want to do the right thing, the whole comment mess has to be cleaned up. Up to you, but I'm out. Laszlo