From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 92655208D6141 for ; Mon, 11 Feb 2019 03:08:00 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C7D2637E2; Mon, 11 Feb 2019 11:07:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-124.rdu2.redhat.com [10.10.120.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6130F5C6A5; Mon, 11 Feb 2019 11:07:53 +0000 (UTC) To: Shenglei Zhang , edk2-devel@lists.01.org Cc: Jordan Justen , Ard Biesheuvel , Anthony Perard , Julien Grall , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20190211024809.20408-1-shenglei.zhang@intel.com> <20190211024809.20408-6-shenglei.zhang@intel.com> From: Laszlo Ersek Message-ID: <8ac1db2e-3b38-f823-bc3b-c3791cff917c@redhat.com> Date: Mon, 11 Feb 2019 12:07:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190211024809.20408-6-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 11 Feb 2019 11:07:59 +0000 (UTC) Subject: Re: [PATCH v2 05/10] OvmfPkg/README: Remove UNIXGCC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 11:08:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/11/19 03:48, Shenglei Zhang wrote: > Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc > and OvmfPkgX64.dsc. > Remove content related to UNIXGCC in README. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > Reviewed-by: Laszlo Ersek > --- > OvmfPkg/OvmfPkgIa32.dsc | 1 - > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > OvmfPkg/OvmfPkgX64.dsc | 1 - > OvmfPkg/README | 19 ------------------- > 4 files changed, 22 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index aee19b75d7..7872ead8de 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -61,7 +61,6 @@ > !endif > > [BuildOptions] > - GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 90cbd8e341..eef8ae25f3 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -61,7 +61,6 @@ > !endif > > [BuildOptions] > - GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 83d16eb00b..6d5623857c 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -61,7 +61,6 @@ > !endif > > [BuildOptions] > - GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > diff --git a/OvmfPkg/README b/OvmfPkg/README > index 68ce0750af..c014d07bfb 100644 > --- a/OvmfPkg/README > +++ b/OvmfPkg/README > @@ -402,25 +402,6 @@ main firmware (MAINFV) into RAM memory at address 0x800000. The > remaining OVMF firmware then uses this decompressed firmware > volume image. > > -=== UNIXGCC Debug === > - > -If you build with the UNIXGCC toolchain, then debugging will be disabled > -due to larger image sizes being produced by the UNIXGCC toolchain. The > -first choice recommendation is to use GCC48 or newer instead. > - > -If you must use UNIXGCC, then you can override the build options for > -particular libraries and modules in the .dsc to re-enable debugging > -selectively. For example: > - [Components] > - OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf { > - > - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG > - } > - MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { > - > - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG > - } > - > === UEFI Windows 7 & Windows 2008 Server === > > * One of the '-vga std' and '-vga qxl' QEMU options should be used. > Looks good, thanks! (+Phil) Laszlo