From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.35304.1591013303198872929 for ; Mon, 01 Jun 2020 05:08:23 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B42BF55D; Mon, 1 Jun 2020 05:08:21 -0700 (PDT) Received: from [192.168.1.69] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A5ADE3F52E; Mon, 1 Jun 2020 05:08:20 -0700 (PDT) Subject: Re: [PATCH v2 4/5] ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option To: Leif Lindholm Cc: devel@edk2.groups.io, jon@solid-run.com, Laszlo Ersek , Ray Ni , Zhichao Gao References: <20200528091741.14610-1-ard.biesheuvel@arm.com> <20200528091741.14610-5-ard.biesheuvel@arm.com> <20200601120154.GD28566@vanye> From: "Ard Biesheuvel" Message-ID: <8ac36435-18eb-4a22-5871-75b5dd3a4415@arm.com> Date: Mon, 1 Jun 2020 14:08:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200601120154.GD28566@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 6/1/20 2:01 PM, Leif Lindholm wrote: > On Thu, May 28, 2020 at 11:17:40 +0200, Ard Biesheuvel wrote: >> Without ConnectAll() being called on the boot path, the UEFI shell will >> be entered with no block devices or anything else connected, and so for >> the novice user, this is not a very accommodating environment. Now that >> we have made the UiApp the last resort on boot failure, and made the >> UEFI Shell accessible directly via the 's' hotkey if you really need >> it, let's hide it as an ordinary boot option. > > Am I being confused here, or is the word "hide" a bit unfortunate in > the above sentence? (It'll still be visible in the UiApp menu, right?) > Ah yes, the wording is slightly off now that the UEFI shell is being kept accessible via the boot manager menu rather than via a completely separate root menu option and form. > >> Signed-off-by: Ard Biesheuvel >> --- >> ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> index 85cb32f6d7cd..1e9b736993d0 100644 >> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> @@ -777,9 +777,7 @@ PlatformBootManagerAfterConsole ( >> // >> Key.ScanCode = SCAN_NULL; >> Key.UnicodeChar = L's'; >> - PlatformRegisterFvBootOption ( >> - &gUefiShellFileGuid, L"UEFI Shell", LOAD_OPTION_ACTIVE, &Key >> - ); >> + PlatformRegisterFvBootOption (&gUefiShellFileGuid, L"UEFI Shell", 0, &Key); >> } >> >> /** >> -- >> 2.17.1 >>