public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, devel@edk2.groups.io
Cc: Eric Dong <eric.dong@intel.com>,
	Rahul Kumar <rahul1.kumar@intel.com>, Ray Ni <ray.ni@intel.com>,
	Star Zeng <star.zeng@intel.com>
Subject: Re: [PATCH 1/3] UefiCpuPkg/AcpiCpuData: update comments on register table fields
Date: Fri, 15 Jan 2021 10:34:31 +0100	[thread overview]
Message-ID: <8ae9649c-6e61-d325-c0d3-3e12ae32bb97@redhat.com> (raw)
In-Reply-To: <719de765-ba4c-6737-ab15-2b8f238e5470@redhat.com>

On 01/15/21 10:28, Philippe Mathieu-Daudé wrote:
> On 1/12/21 8:19 PM, Laszlo Ersek wrote:
>> After commit e992cc3f4859 ("UefiCpuPkg PiSmmCpuDxeSmm: Reduce SMRAM
>> consumption in CpuS3.c", 2021-01-11), it is valid for a CPU S3 Data DXE
>> Driver to set "ACPI_CPU_DATA.PreSmmInitRegisterTable" and/or
>> "ACPI_CPU_DATA.RegisterTable" to 0, in case none of the CPUs needs a
>> register table of the corresponding kind, during S3 resume.
>>
>> Document this fact in the "UefiCpuPkg/Include/AcpiCpuData.h" header file.
>>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3159
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  UefiCpuPkg/Include/AcpiCpuData.h | 4 ++++
>>  1 file changed, 4 insertions(+)
> 
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> 

Thank you!
Laszlo


  reply	other threads:[~2021-01-15  9:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12 19:19 [PATCH 0/3] UefiCpuPkg, OvmfPkg: do not allocate useless register tables for S3 resume Laszlo Ersek
2021-01-12 19:19 ` [PATCH 1/3] UefiCpuPkg/AcpiCpuData: update comments on register table fields Laszlo Ersek
2021-01-13  5:00   ` Ni, Ray
2021-01-15  9:28   ` Philippe Mathieu-Daudé
2021-01-15  9:34     ` Laszlo Ersek [this message]
2021-01-12 19:19 ` [PATCH 2/3] UefiCpuPkg/CpuS3DataDxe: do not allocate useless register tables Laszlo Ersek
2021-01-13  6:12   ` Ni, Ray
2021-01-13  7:16     ` Zeng, Star
2021-01-13  8:12       ` Ni, Ray
2021-01-13  8:40         ` Zeng, Star
2021-01-13  9:16         ` Laszlo Ersek
2021-01-14  1:55         ` Zeng, Star
2021-01-14 17:35           ` Laszlo Ersek
2021-01-15  8:33             ` [edk2-devel] " Ni, Ray
2021-01-15  8:37               ` Laszlo Ersek
2021-01-19 12:52                 ` Ni, Ray
2021-01-19 13:48                   ` Laszlo Ersek
2021-01-13  9:10     ` Laszlo Ersek
2021-01-12 19:19 ` [PATCH 3/3] OvmfPkg/CpuS3DataDxe: " Laszlo Ersek
2021-01-14 12:53   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ae9649c-6e61-d325-c0d3-3e12ae32bb97@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox