From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web12.1715.1610703279138779939 for ; Fri, 15 Jan 2021 01:34:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bfy36aQU; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610703278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u0hWz5MDCNAjqnq9wzjz099fb9J00h7ByEem5UeJMtg=; b=bfy36aQUoeLNudUJazLK8LRRCktVXzBp7TY22WmzKNT379jHnhsSCD3hZsAtmdEhal9ImT WwsWUxMafZ70lAMGl7w8CZKSrF8aypwmLdCS0d2kyBwnNKsKNiYIVeXNR+unvuKGS9SKJA xAy/3QmzIDFxkoe/dnh9xLUPpClo5J0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-424-kZ3itW8MMXWgJmnYlyUxQQ-1; Fri, 15 Jan 2021 04:34:34 -0500 X-MC-Unique: kZ3itW8MMXWgJmnYlyUxQQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 66F17E76B; Fri, 15 Jan 2021 09:34:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-223.ams2.redhat.com [10.36.112.223]) by smtp.corp.redhat.com (Postfix) with ESMTP id 023627086D; Fri, 15 Jan 2021 09:34:31 +0000 (UTC) Subject: Re: [PATCH 1/3] UefiCpuPkg/AcpiCpuData: update comments on register table fields To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io Cc: Eric Dong , Rahul Kumar , Ray Ni , Star Zeng References: <20210112191934.12459-1-lersek@redhat.com> <20210112191934.12459-2-lersek@redhat.com> <719de765-ba4c-6737-ab15-2b8f238e5470@redhat.com> From: "Laszlo Ersek" Message-ID: <8ae9649c-6e61-d325-c0d3-3e12ae32bb97@redhat.com> Date: Fri, 15 Jan 2021 10:34:31 +0100 MIME-Version: 1.0 In-Reply-To: <719de765-ba4c-6737-ab15-2b8f238e5470@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01/15/21 10:28, Philippe Mathieu-Daudé wrote: > On 1/12/21 8:19 PM, Laszlo Ersek wrote: >> After commit e992cc3f4859 ("UefiCpuPkg PiSmmCpuDxeSmm: Reduce SMRAM >> consumption in CpuS3.c", 2021-01-11), it is valid for a CPU S3 Data DXE >> Driver to set "ACPI_CPU_DATA.PreSmmInitRegisterTable" and/or >> "ACPI_CPU_DATA.RegisterTable" to 0, in case none of the CPUs needs a >> register table of the corresponding kind, during S3 resume. >> >> Document this fact in the "UefiCpuPkg/Include/AcpiCpuData.h" header file. >> >> Cc: Eric Dong >> Cc: Philippe Mathieu-Daudé >> Cc: Rahul Kumar >> Cc: Ray Ni >> Cc: Star Zeng >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3159 >> Signed-off-by: Laszlo Ersek >> --- >> UefiCpuPkg/Include/AcpiCpuData.h | 4 ++++ >> 1 file changed, 4 insertions(+) > > Reviewed-by: Philippe Mathieu-Daude > Thank you! Laszlo