From: Laszlo Ersek <lersek@redhat.com>
To: shenglei <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Subject: Re: [PATCH] MdeModulePkg: Remove redundant library classes and guides in inf files
Date: Thu, 26 Jul 2018 11:16:03 +0200 [thread overview]
Message-ID: <8aebb027-b68d-78ec-1bfc-e09c95ed296e@redhat.com> (raw)
In-Reply-To: <b22fe33a9bdb3d6f394c51eff6e03b57124b0d68.1532569617.git.shenglei.zhang@intel.com>
On 07/26/18 03:57, shenglei wrote:
> Some redundant libraray classes and guides have been removed in inf files.
The typos in the commit message should please be corrected when the
patch is pushed:
- libraray -> library
- guides -> GUIDs (this was really confusing for a second)
Thanks!
Laszlo
> https://bugzilla.tianocore.org/show_bug.cgi?id=1017
> https://bugzilla.tianocore.org/show_bug.cgi?id=1035
> https://bugzilla.tianocore.org/show_bug.cgi?id=1033
> https://bugzilla.tianocore.org/show_bug.cgi?id=1012
> https://bugzilla.tianocore.org/show_bug.cgi?id=1011
>
> Cc:Star Zeng <star.zeng@intel.com>
> Cc:Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 1 -
> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf | 1 -
> MdeModulePkg/Core/Dxe/DxeMain.inf | 1 -
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 1 -
> MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> index 4aab75bab7..d067df0400 100644
> --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> @@ -60,7 +60,6 @@
> ReportStatusCodeLib
>
> [Guids]
> - gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_PRODUCES ## UNDEFINED
> gEfiDiskInfoAhciInterfaceGuid ## SOMETIMES_PRODUCES ## UNDEFINED
>
> [Protocols]
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
> index a21dd2b5ed..faf68c7d90 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
> @@ -78,7 +78,6 @@
> BaseLib
> UefiDriverEntryPoint
> DebugLib
> - PeCoffLib
>
> [Protocols]
> gEfiPciHotPlugRequestProtocolGuid ## SOMETIMES_PRODUCES
> diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf
> index 68fa0a01d9..fc8af3d293 100644
> --- a/MdeModulePkg/Core/Dxe/DxeMain.inf
> +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf
> @@ -163,7 +163,6 @@
> gEfiHiiPackageListProtocolGuid ## SOMETIMES_PRODUCES
> gEfiEbcProtocolGuid ## SOMETIMES_CONSUMES
> gEfiSmmBase2ProtocolGuid ## SOMETIMES_CONSUMES
> - gEfiBlockIoProtocolGuid ## SOMETIMES_CONSUMES
>
> # Arch Protocols
> gEfiBdsArchProtocolGuid ## CONSUMES
> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
> index a2ff773a74..f11ccb0e07 100644
> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
> @@ -66,7 +66,6 @@
> TimerLib
> HobLib
> SmmMemLib
> - DxeServicesLib
>
> [Protocols]
> gEfiDxeSmmReadyToLockProtocolGuid ## UNDEFINED # SmiHandlerRegister
> diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
> index a4184212bb..36ed80cc79 100644
> --- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
> +++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
> @@ -42,7 +42,6 @@
>
> [LibraryClasses]
> UefiBootServicesTableLib
> - MemoryAllocationLib
> UefiDriverEntryPoint
> BaseMemoryLib
> BaseLib
>
prev parent reply other threads:[~2018-07-26 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 1:57 [PATCH] MdeModulePkg: Remove redundant library classes and guides in inf files shenglei
2018-07-26 9:16 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aebb027-b68d-78ec-1bfc-e09c95ed296e@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox